Issue1225_1228

[lisphilar]

Related issues

#1225, #1228

What was changed

• Close [Fix] DataEngineer().diff() raises ValueError with pandas version 1.5.0 #1225
• Close [Fix] LinePlot().plot(), BarPlot().plot() raise incorrect error when un-expected colormap was specified #1228
• test: skip some methods of TestODEScenario for a while

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.28%.

Quality metrics	Before	After	Change
Complexity	0.96 ⭐	0.96 ⭐	0.00
Method Length	59.66 ⭐	59.21 ⭐	-0.45 👍
Working memory	6.56 🙂	6.57 🙂	0.01 👎
Quality	77.29% ⭐	77.57% ⭐	0.28% 👍

Other metrics	Before	After	Change
Lines	657	657	0

Changed files	Quality Before	Quality After	Quality Change
covsirphy/version.py	100.00% ⭐	100.00% ⭐	0.00%
covsirphy/engineering/_transformer.py	80.23% ⭐	79.97% ⭐	-0.26% 👎
covsirphy/visualization/bar_plot.py	71.07% 🙂	71.07% 🙂	0.00%
covsirphy/visualization/line_plot.py	73.51% 🙂	73.51% 🙂	0.00%
covsirphy/visualization/scatter_plot.py	80.00% ⭐	80.00% ⭐	0.00%
tests/test_science/test_ode_scenario.py	80.88% ⭐	81.86% ⭐	0.98% 👍
tests/test_visualization/test_bar.py	74.08% 🙂	74.08% 🙂	0.00%
tests/test_visualization/test_line.py	81.39% ⭐	81.39% ⭐	0.00%
tests/test_visualization/test_scatter.py	81.87% ⭐	84.92% ⭐	3.05% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
covsirphy/visualization/bar_plot.py	BarPlot.y_axis	5 ⭐	123 😞	11 😞	59.15% 🙂	Try splitting into smaller methods. Extract out complex expressions
covsirphy/visualization/line_plot.py	LinePlot.y_axis	5 ⭐	123 😞	11 😞	59.15% 🙂	Try splitting into smaller methods. Extract out complex expressions
covsirphy/visualization/scatter_plot.py	ScatterPlot.line_straight	3 ⭐	101 🙂	12 😞	62.24% 🙂	Extract out complex expressions
covsirphy/visualization/bar_plot.py	BarPlot.plot	2 ⭐	121 😞	9 🙂	66.32% 🙂	Try splitting into smaller methods
tests/test_science/test_ode_scenario.py	TestODEScenario.test_build_delete	0 ⭐	199 😞	6 ⭐	67.57% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1226 (58e279b) into master (9b135b3) will decrease coverage by 5.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
- Coverage   93.74%   88.73%   -5.02%     
==========================================
  Files          44       43       -1     
  Lines        2911     2823      -88     
==========================================
- Hits         2729     2505     -224     
- Misses        182      318     +136     

Impacted Files	Coverage Δ
covsirphy/visualization/scatter_plot.py	95.23% <0.00%> (-4.77%)	⬇️
covsirphy/__version__.py	100.00% <100.00%> (ø)
covsirphy/engineering/_transformer.py	100.00% <100.00%> (ø)
covsirphy/visualization/bar_plot.py	100.00% <100.00%> (ø)
covsirphy/visualization/line_plot.py	100.00% <100.00%> (ø)
covsirphy/science/ode_scenario.py	15.54% <0.00%> (-53.79%)	⬇️
covsirphy/util/alias.py	82.75% <0.00%> (-10.35%)	⬇️
covsirphy/dynamics/dynamics.py	89.82% <0.00%> (-1.33%)	⬇️
covsirphy/util/error.py	76.28% <0.00%> (-1.29%)	⬇️
covsirphy/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.