Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate error handling of colormap to Matplotlib #1310

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Conversation

lisphilar
Copy link
Owner

Related issues

#1309

What was changed

Close #1309 by delegating error handling of colormap to Matplotlib.

@lisphilar lisphilar added the bug Something isn't working label Dec 4, 2022
@lisphilar lisphilar added this to the Release v3.0.0 milestone Dec 4, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.34%.

Quality metrics Before After Change
Complexity 0.45 ⭐ 0.39 ⭐ -0.06 👍
Method Length 48.69 ⭐ 47.67 ⭐ -1.02 👍
Working memory 6.02 ⭐ 6.15 ⭐ 0.13 👎
Quality 82.51% 82.17% -0.34% 👎
Other metrics Before After Change
Lines 118 108 -10
Changed files Quality Before Quality After Quality Change
covsirphy/visualization/scatter_plot.py 80.00% ⭐ 80.69% ⭐ 0.69% 👍
tests/test_visualization/test_scatter.py 87.01% ⭐ 85.56% ⭐ -1.45% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
covsirphy/visualization/scatter_plot.py ScatterPlot.line_straight 3 ⭐ 101 🙂 12 😞 62.24% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lisphilar lisphilar merged commit 92d5614 into main Dec 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue1309 branch December 4, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] incorrect error handling of ScatterPlot().plot(colormap)
1 participant