Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #1350 #1351

Merged
merged 3 commits into from
Feb 4, 2023
Merged

close #1350 #1351

merged 3 commits into from
Feb 4, 2023

Conversation

lisphilar
Copy link
Owner

@lisphilar lisphilar commented Feb 4, 2023

Related issues

#1350

What was changed

Close #1350 by supress the following warning, referencing geopandas/geopandas#2645 and pandas-dev/pandas#48673

FAILED tests/test_engineering/test_engineer.py::test_with_actual_data - DeprecationWarning:
In a future version, `df.iloc[:, i] = newvals` will attempt to set the values inplace
instead of always setting a new array.
To retain the old behavior, use either `df[df.columns[i]] = newvals` or,
if columns are non-unique, `df.isetitem(i, newvals)`

@lisphilar lisphilar added the bug Something isn't working label Feb 4, 2023
@lisphilar lisphilar added this to the Release v3.0.0 milestone Feb 4, 2023
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 4, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.19%.

Quality metrics Before After Change
Complexity 7.47 ⭐ 7.49 ⭐ 0.02 👎
Method Length 170.29 😞 172.00 😞 1.71 👎
Working memory 9.80 🙂 9.82 🙂 0.02 👎
Quality 52.12% 🙂 51.93% 🙂 -0.19% 👎
Other metrics Before After Change
Lines 187 189 2
Changed files Quality Before Quality After Quality Change
covsirphy/gis/_layer.py 52.12% 🙂 51.93% 🙂 -0.19% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
covsirphy/gis/_layer.py _LayerAdjuster.register 10 🙂 492 ⛔ 12 😞 36.93% 😞 Try splitting into smaller methods. Extract out complex expressions
covsirphy/gis/_layer.py _LayerAdjuster._align_layers 10 🙂 183 😞 10 😞 50.06% 🙂 Try splitting into smaller methods. Extract out complex expressions
covsirphy/gis/_layer.py _LayerAdjuster._prepare_layers 8 ⭐ 157 😞 9 🙂 56.40% 🙂 Try splitting into smaller methods
covsirphy/gis/_layer.py _LayerAdjuster.all 1 ⭐ 141 😞 8 🙂 67.17% 🙂 Try splitting into smaller methods
covsirphy/gis/_layer.py _LayerAdjuster.__init__ 3 ⭐ 120 😞 7 🙂 70.01% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lisphilar lisphilar merged commit ec0947d into main Feb 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the issue1350 branch February 4, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DeprecationWarning with choroplethmap
1 participant