Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue#1 - Long-term ODE simulation shows negative number of cases #4

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

lisphilar
Copy link
Owner

@lisphilar lisphilar commented Jun 3, 2020

I think this was caused by non-dimensional ODE.
However, to keep development speed, I will close this issue with a minor change of codes.

It is necessary to revise the codes of classes to simulate ODE models and to perform dimensionalized numerical simulations later.

Advantage of non-dimensional system:

  • we can estimate the parameter values efficiently and compare the parameter values
  • we can compare the parameter values with that of the other countries easily

Dis-advantage of non-dimensional system (may be root cause of issue#1):

  • substraction in diferencial equations reduces the accuracy of numerical simulation
  • it is difficult to determine the minimum value of dydt
  • dimensionalization of simulated values increases error with actual values

@lisphilar lisphilar added the bug Something isn't working label Jun 3, 2020
@lisphilar lisphilar merged commit a892f2b into master Jun 3, 2020
@lisphilar lisphilar deleted the issue1 branch June 3, 2020 14:36
@lisphilar lisphilar linked an issue Jun 3, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long-term ODE simulation shows negative number of cases
1 participant