fixing dokuwiki-template-bootstrap3 #600 #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See giterlizzi/dokuwiki-template-bootstrap3#600 : Tagfilter didn't work with the bootstrap3 template.
Problem analysis:
tagfilter plugin's code relies on the containing
<div>
havingclass="table"
, cf.tagfilter/script.js
Line 118 in a5f406a
the bootstrap3 plugin changes that class, cf. https://github.com/giterlizzi/dokuwiki-template-bootstrap3/blob/b1c8c9aa7c0663a9edd387b9901e62c022896e31/Template.php#L1547-L1549
Solutions
This is a fix for it.
However may I ask: Can arbitrary similar problems occur with other templates?