Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom indent size #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow custom indent size #1

wants to merge 1 commit into from

Conversation

vtta
Copy link
Collaborator

@vtta vtta commented Aug 11, 2019

I prefer to indent using 2 spaces, so I made this change to allow changing indent size via changing indent-size to desired value in add-indent-size.
I hope this will be helpful to other people who also prefer custom indent settings.😉

@vtta vtta changed the title allow define indent size allow custom indent size Aug 11, 2019
@lassik
Copy link
Member

lassik commented Aug 11, 2019

Awesome, thank you! I didn't know people are using this right now; I've been putting off work on it.

Lisp code is almost universally indented using 2 spaces, as you prefer. I think we should change it to always indent with 2 spaces for that reason. I haven't really seen any Lisp/Scheme code that uses a different indent size, and that's great for consistency. What do you think?

@vtta
Copy link
Collaborator Author

vtta commented Aug 11, 2019

Yeah, I would like that very much🤗

@lassik
Copy link
Member

lassik commented Aug 11, 2019

Great. Let's do it. Are you using this with Chicken 4 or Chicken 5? The master branch is using 4 but the lassik-chicken5 branch should be fully functional.

@lassik
Copy link
Member

lassik commented Aug 11, 2019

I gave you write access to the repo in case you are interested in hacking on Lisp formatting. Lisp-Scheme collaboration is not popular at the moment so having more people on board is great :)

@vtta
Copy link
Collaborator Author

vtta commented Aug 11, 2019

Thanks for all your work and allowing me onboard😁
I'm using chicken @4.13.0 from macports currently, I will give Chicken 5 a try.
Actually I'm a rookie reading SICP, and most of my scheme experience is with MIT/GNU Scheme.
I will put some work into Chicken, figuring out the differences and dive into all those macro magics. 😅

@vtta
Copy link
Collaborator Author

vtta commented Aug 11, 2019

I noticed a glitch with the indentation of let statement.
Desired:

(let ((a definition-of-a)
      (b definition-of-b))
  (do something))

Got:

(let ((a definition-of-a)
       (b definition-of-b))
  (do something))

When I figure it out I will merge all those commits together.

@lassik
Copy link
Member

lassik commented Aug 17, 2019

You're right, that let is currently incorrect.

Sorry about the delay responding, too many concurrent projects... Awesome that you're going through SICP, it's a great book :) If you don't mind, I can merge the Chicken 5 changes into the master branch so we can develop from that foundation. It'll be somewhat confusing to maintain separate Chicken 4 and Chicken 5 branches as development progresses.

If somebody is using an OS that doesn't have Chicken 5 yet, I can get in touch with the distributors about helping to ship it there.

@vtta
Copy link
Collaborator Author

vtta commented Aug 19, 2019

That would be great. I'm always longing for the latest software😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants