Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some bash machinery so that scripts/* can be invoked from any directory successfully. Added .envrc for direnv. #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mcarifio
Copy link

First, lispx is neat, ty.

Second, no one asked me for a pull request, so cherrypick what you like or ignore it all.

Third, pre-commit unfortunately works nicely with direnv and this pull request contains .js files and .lock files I didn't intend. Maybe there's a way to remove those from the pull request, but as of this paragraph I don't know exactly how to do that. About to give that a go. But be aware you can't just blindly apply all the changes.

Finally, the real contribution is modifying scripts/* so that you can invoke them from anywhere in the project layout. Direnv adds scripts to PATH and the scripts themselves will find assets relative to BASH_SOURCE, the pathname of the running script. Bash is explicitly invoked so I use a bashism rather than $0.

@mcarifio
Copy link
Author

I believe I've removed the offending .js and .lock files from this pull request and it can be applied in total if desired. But you have to do some mental gymnastics to get there from the history of operations above, ugh. I guess if I really knew what I was doing, I'd craft the pull request into a different branch so you could experiment with it first. My gitfu isn't that strong, but maybe yours is.

Yeah, it sucks when my "improvements" force you to do work. Sorry 'bout that. The glass is half full? Quarter maybe? Eighth? A drop? You'll love the additions, trust me. No, really.

@manuel
Copy link
Contributor

manuel commented Apr 10, 2024

Thanks for the PR. I do have some overhauls of the build process planned. I will look into your changes once that's done.

@mcarifio
Copy link
Author

At your leisure, good follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants