Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where a command would hang due to closed connection #26

Merged

Conversation

atugushev
Copy link
Collaborator

Fixes #25

@GinTR1k GinTR1k self-assigned this Sep 8, 2020
@atugushev atugushev closed this Sep 8, 2020
@atugushev atugushev reopened this Sep 8, 2020
@atugushev
Copy link
Collaborator Author

Reopened to restart github actions.

@codecov-commenter
Copy link

Codecov Report

Merging #26 into master will increase coverage by 0.03%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   82.10%   82.14%   +0.03%     
==========================================
  Files          26       26              
  Lines        1280     1305      +25     
  Branches       79       82       +3     
==========================================
+ Hits         1051     1072      +21     
  Misses        185      185              
- Partials       44       48       +4     
Impacted Files Coverage Δ
ansq/tcp/connection.py 60.96% <85.71%> (-0.02%) ⬇️
ansq/tcp/exceptions.py 97.56% <100.00%> (+0.12%) ⬆️
tests/test_send_commands.py 100.00% <100.00%> (ø)
tests/test_convert_to_bytes.py 97.05% <0.00%> (-2.95%) ⬇️
ansq/utils.py 83.72% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd54721...4040594. Read the comment docs.

@GinTR1k GinTR1k force-pushed the 25-fix-hangs-on-closed-connection branch from 4040594 to 254854d Compare September 10, 2020 11:02
@atugushev atugushev force-pushed the 25-fix-hangs-on-closed-connection branch from cc37708 to 22574dd Compare September 10, 2020 13:37
@GinTR1k GinTR1k merged commit cb4c722 into list-family:master Sep 16, 2020
@atugushev atugushev deleted the 25-fix-hangs-on-closed-connection branch September 16, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hangs on message publish if nsqd connection is suddenly closed
3 participants