Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add firefox support #23

Merged
merged 2 commits into from
May 14, 2016
Merged

add firefox support #23

merged 2 commits into from
May 14, 2016

Conversation

fulesdle
Copy link
Contributor

add firefox support

@fulesdle fulesdle mentioned this pull request May 13, 2016
@listen1
Copy link
Owner

listen1 commented May 13, 2016

非常棒的PR!firefox用户有福了!

在合并主线前一点小建议:
加入我的歌单后的版本后firefox内显示似乎会出现两个兼容性问题:
1)需要加入moz-extension为url前缀的支持:
app.js:18
$compileProvider.imgSrcSanitizationWhitelist(/^\s*(https?|ftp|mailto|chrome-extension|moz-extension):/);
2) 关于页中下载备份文件会产生Error: chrome.downloads is undefined,似乎firefox没有支持chrome的下载功能?

@fulesdle
Copy link
Contributor Author

1. add moz-extension whitelist

$compileProvider.imgSrcSanitizationWhitelist(/^\s*(https?|ftp|mailto|chrome-extension|moz-extension):/);

2. Firefox 47.0 已经支持 chrome.downloads

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/downloads

3. 建议修改项目名称 listen1_WebExtensions

因为主流浏览器都会加入 WebExtensions 支持, 这样开发者可能会更多. 谢谢

@listen1 listen1 merged commit 5a0ad8f into listen1:master May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants