-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复网易云导入歌单大于1000首失败问题,更改音乐详情页背景图片 #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
第一次pr,操作不熟练,见谅 |
歌曲详情页背景由纯白变为歌曲背景。 背景图片添加了滤镜,模糊处理,并加了一个跟随系统主题色变化的蒙版,保证歌词显示清晰 这个功能加上后音乐详情页视觉变动比较大,并不是所有人都喜欢,可以考虑变为一个开关
在深空灰主题下某些背景图歌词不是很清晰,修改一下颜色亮度,更清晰
使用async库concat函数对异步代码控制更加简洁,对原有代码修改更少
Ericwyn
pushed a commit
to Ericwyn/listen1_chrome_extension
that referenced
this pull request
Sep 22, 2020
* 更新 netease.js * Revert "更新 netease.js" This reverts commit 647e223. * 更新 netease.js 修复网易云音乐导入歌单超过1000首时失败问题 * Revert "更新 netease.js" This reverts commit 13066b1. * 修复网易云导入歌单大于1000首失败 网易云音乐歌单超过1000首会失败,传入id过多会被服务器拒绝 * 音乐详情页背景变为歌曲图片 歌曲详情页背景由纯白变为歌曲背景。 背景图片添加了滤镜,模糊处理,并加了一个跟随系统主题色变化的蒙版,保证歌词显示清晰 这个功能加上后音乐详情页视觉变动比较大,并不是所有人都喜欢,可以考虑变为一个开关 * 修改简约白当前歌词颜色 * 修改深空灰主题下歌词显示颜色 在深空灰主题下某些背景图歌词不是很清晰,修改一下颜色亮度,更清晰 * 优化大于1000首歌的bug处理 使用async库concat函数对异步代码控制更加简洁,对原有代码修改更少 Co-authored-by: YueShangGuan <YueShangGuan@users.noreply.github.com> Co-authored-by: Listen 1 <githublisten1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
网易云音乐歌单超过1000首会失败,因传入id过多,数据包太大会被服务器拒绝数据。修改为拆分歌单,1000首发送一次请求获取,获取所有数据后再统一显示
具体内容可查看我的博客:网易云音乐歌单过长无法导入