Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lyric font settings #701

Merged
merged 7 commits into from
Nov 26, 2021
Merged

Conversation

mikelxk
Copy link
Collaborator

@mikelxk mikelxk commented Nov 25, 2021

P.S: in the now playing window, click on singer and album doesn't seem to work.

@listen1
Copy link
Owner

listen1 commented Nov 25, 2021

P.S: in the now playing window, click on singer and album doesn't seem to work.

fixed it! thanks.

@listen1
Copy link
Owner

listen1 commented Nov 25, 2021

I think we'd better change font size/weight text input to select option, it's easy for users.

PS: If there's a preview under that would be nicer, user can preview lyric font size/weight in real time. You can refer qq music settings of lyric.

@mikelxk
Copy link
Collaborator Author

mikelxk commented Nov 25, 2021

I changed font weight to select, however I don't think change the font size to select is a good option:
There's no conventional name mapping for font size and I want user to choose from any accurate value of font size they want not just " small" " medium" "large" "x-large", also I will be really redundant if I create a dropdown on different pixel value.
Anyway, I think user a least have better knowledge on font size compared to font weight.

src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
@listen1 listen1 merged commit 18f0f8a into listen1:next Nov 26, 2021
@mikelxk mikelxk mentioned this pull request Jan 18, 2022
22 tasks
@mikelxk mikelxk deleted the lyric-font-settings branch March 10, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants