use consitent border radius #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mikelxk
commented
Dec 12, 2021
mikelxk
commented
- Use a consistent 4px border radius on in page element (i.e., buttons) and 8px on windows or dialogs.
- 馃啓 tailwindcss
- Also, my netease tab seem completely messed up with cover with unrestricted size.
|
my platform page is fixe in next branch |
listen1
added a commit
that referenced
this pull request
Dec 13, 2021
* feat: add tailwind initial css, fix some style bug * feat: sidebar migration * feat: navigation migration * feat: footer cover/singer/control migration * feat: draggable bar, menu toggle migration * feat: move playerbar popup to component * feat: upgrade tailwind to v3 * feat: move volume bar to component * chore: move playerbar related css to component * feat: souce tab to component * feat: hot playlist filter migration * fix: source tab in search page style error * feat: move track row to component * feat: move button with icon to component * feat: login migration * feat: settings page migration * feat: now playing page migration * feat: migrate track row styles * feat: move common css remain to component * chore: remove common.css * chore: yarn run format * fix: dialog style error * style: minor adjust sidebar and scroll related * fix: open login button background * fix: search rows align error * fix: adjust dialog header align * style: adjust playlist padding * fix: sidebar top margin too large * fix: remove sidebar title margin inline * fix: my platform playlist show error * use consitent border radius (#735) * style: change setting content line height to 2rem * fix: now playing background transition effect * fix: my platform cursor pointer * fix: zindex not reset after drag finish bug * style: set some vue-feather icons stroke width 2 * style: now playing title font size normal * style: larger play control icons * fix: theme odd/even bg color * style: playerbar large title, fix cover hover icon color * fix: song title truncate not working bug * fix: listen1 logo size when playlist empty * style: add gap between playlist covers * style: playerbar control icon * style: local music icon, cursor pointer Co-authored-by: MikeLxk <mike.lxk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.