feat: V3 comment #738
Merged
feat: V3 comment #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A little bit related, can we also add support for description on tracks and playlists? |
good idea, we can create a new pr for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add comment list in now playing page. Support hotest/newest order, pagination.
Current Progress
Finish comment api for all platforms and basic hotest comment list show.
Pagination/Order is not supported.
Still consider add checkbox in settings to disable comment function (some users prefer pure music playing)
Detected Problems
Special Thanks to
洛雪音乐播放器：https://github.com/lyswhut/lx-music-desktop
Most of comment related code is refered from repo. After merged, I'll add it to readme docs.
BTW, it's best open source music player codebase I found so far.