升级程序到v2.0.0 #20
Closed
升级程序到v2.0.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is beautiful UI for Listen1. Add Download Function. Add Global Shortcut
# Conflicts: # app/package.json # package.json
|
非常棒的更新，这个PR是对项目非常大的贡献，感谢！ 由于这个PR涉及的改动比较多，可能需要几天时间来review，分步并入项目。PR中引入了下载音乐的功能，可能会对主项目造成一定的困扰，我建议暂时在PR中删除这部分的代码，您的个人fork中可以保留这一功能的分支。希望能理解这个项目背负的压力和做出这样选择的初衷。 其中涉及chrome插件版的改动很有价值，主要是解决了主页滚动条的闪动bug，这部分我会直接在chrome_extension项目中merge，并标明代码贡献人。这样桌面版也只需要更新submodule就能够解决这一问题。 |
listen1
requested changes
Feb 15, 2018
This was referenced Feb 25, 2018
Closed
Closed
修复自动获取链接有效下载链接
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
整理程序代码
修改UI样式
添加快捷键响应
添加下载功能