new(error.go): catch exec.ExitError and return error #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, I suggest removing what my commit adds and instead catching it further up: if err := npmPackageLockOnly.Run(); err != nil {
if e, ok := err.(*exec.ExitError); !ok {
fmt.Printf("npm subprocess terminated with status code %s\n", e.ProcessState)
}
return []byte{}, pkgcontext.OutputErrorf(ctx, err, "couldn't generate the package-lock.json file")
} |
leodido
reviewed
Feb 10, 2023
| @@ -29,6 +30,9 @@ func Error(ctx context.Context, input error) error { | |||
| if e, ok := input.(net.Error); ok && e.Timeout() { | |||
| return context.DeadlineExceeded | |||
| } | |||
| if e, ok := input.(*exec.ExitError); ok { | |||
| return fmt.Errorf("subprocess terminated with status code %s", e.ProcessState) | |||
There was a problem hiding this comment.
The e instance contains also the Stderr byte slice.
We could think of appending it to this error string.
Can you send a screenshot of what the Stderr byte slice contains so we can decide?
There was a problem hiding this comment.
I suggest to:
- check if
len(e.Stderr) > 0 - if so, append it to the error with
string(e.Stderr)
Signed-off-by: Francesco Di Donato <didonato.fr@gmail.com>
Signed-off-by: Francesco Di Donato <didonato.fr@gmail.com>
didof
force-pushed
the
fix/could-not-generate-the-package-lockjson
branch
from
cb33a6c
to
030d4dd
Compare
leodido
approved these changes
Feb 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input to the
in(package.json) command is invalid, there is little that can be done. It can happen, however, that it is valid but makes (incorrectly in my opinion) assumptions about the presence of certain executables on the host. This is the case ofnode-sdk, as seen in #62.After internal analysis with @leodido, I propose a simple casting of the error in order to give more information about why the failure occurred.
Fixes #67
Signed-off-by: Francesco Di Donato didonato.fr@gmail.com