Adds unsafeCss for composing values into css
#474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some documentation about what common security issues to be aware of, would be a nice addition |
rictic
reviewed
Jan 23, 2019
| export const unsafeCss = (value: any) => { | ||
| return new CSSResult(String(value), constructionToken); | ||
| }; | ||
|
|
||
| const textFromCSSResult = (value: CSSResult) => { | ||
| if (value instanceof CSSResult) { | ||
| return value.cssText; |
There was a problem hiding this comment.
Consider mentioning unsafeCss in the error message here.
src/lib/css-tag.ts
Outdated
| @@ -37,6 +44,10 @@ export class CSSResult { | |||
| } | |||
| } | |||
|
|
|||
| export const unsafeCss = (value: any) => { | |||
There was a problem hiding this comment.
Prefer unknown to any here (and generally).
src/lib/css-tag.ts
Outdated
| @@ -37,6 +44,10 @@ export class CSSResult { | |||
| } | |||
| } | |||
|
|
|||
| export const unsafeCss = (value: any) => { | |||
There was a problem hiding this comment.
Documentation? Maybe:
/**
* Wrap a value for interpolation in a css tagged template literal.
*
* This is unsafe because untrusted CSS text can be used to phone home
* or exfiltrate data to an attacker controlled site. Take care to only use
* this with trusted input.
*/
* add docs * refine error message
@kenchris: Good point. Some documentation was added to the function, but I've also filed lit/lit.dev#868 to add some further detail and examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451 and #471. Non-literal values can now be included in styling with
cssby using theunsafeCssfunction. This is named "unsafe" so users know this they must use this carefully to avoid security issues.