-
Notifications
You must be signed in to change notification settings - Fork 880
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[starter-kits] Fix starter kits so
npm run serve
isn't `npm run doc…
…s:serve` (#2300) We want to specify no root directory, such that the README.md instructions make sense. Therefore, by navigating the localhost:8000/dev/index.html as written, you now get your authored element and a much better experience. Previously `npm run serve` was serving the docs directory preventing access to the component. * Add something on root url, so that folks don't get a 404. We recommend in the README.md that the user navigates to /dev/index.html. However you expect `npm run serve` to not 404. Add a tiny stub document that points users in the right direction. Co-authored-by: Andrew Jakubowicz <ajakubowicz@google.com>
- Loading branch information
1 parent
4d522d8
commit 8b9dcb4
Showing
5 changed files
with
28 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@lit/lit-starter-js': patch | ||
'@lit/lit-starter-ts': patch | ||
--- | ||
|
||
Fix starter kits so `npm run serve` serves the root directory, and add a link to the `/dev/index.html` component example from `/`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!DOCTYPE html> | ||
|
||
<html> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<title>Lit Starter Kit</title> | ||
</head> | ||
<body> | ||
<a href="/dev/index.html">Component Demo</a> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!DOCTYPE html> | ||
|
||
<html> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<title>Lit Starter Kit</title> | ||
</head> | ||
<body> | ||
<a href="/dev/index.html">Component Demo</a> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters