Add missing await in task.ts (#3847)

* Add missing await in task.ts * Changeset * Add a test that performTask awaits.
lit · Apr 28, 2023 · b362585 · b362585
1 parent cd75977
commit b362585
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/.changeset/friendly-grapes-melt.md b/.changeset/friendly-grapes-melt.md
@@ -0,0 +1,5 @@
+---
+'@lit-labs/task': patch
+---
+
+Add a missing await in performTask
diff --git a/packages/labs/task/src/task.ts b/packages/labs/task/src/task.ts
@@ -166,7 +166,7 @@ export class Task<
   protected async performTask() {
     const args = this._getArgs?.();
     if (this.shouldRun(args)) {
-      this.run(args);
+      await this.run(args);
     }
   }
 

diff --git a/packages/labs/task/src/test/task_test.ts b/packages/labs/task/src/test/task_test.ts
@@ -582,4 +582,23 @@ suite('Task', () => {
 
     assert.equal(el.taskObservedValue, 'bar');
   });
+
+  test('performTask waits on the task', async () => {
+    const el = getTestElement({
+      args: () => [el.a],
+    });
+    await renderElement(el);
+    let taskComplete = false;
+    (async () => {
+      el.a = 'z';
+      // @ts-expect-error: We're testing the behavior of a protected method
+      await el.task.performTask();
+      taskComplete = true;
+    })();
+    await tasksUpdateComplete();
+    assert.isFalse(taskComplete);
+    el.resolveTask();
+    await tasksUpdateComplete();
+    assert.isTrue(taskComplete);
+  });
 });