[infra] Add BROWSERS to cache key for all WTR tests (#3549)

Our WTR config uses the `BROWSERS` environment variable as a way to specify a subset of browsers to test. E.g. if you just want to test in chromium and firefox, you can do `BROWSERS=chromium,firefox npm test`. In order to prevent wireit from sharing cached successes across runs with different browsers, we need to tell it about the `BROWSERS` variable, using the `env` feature: https://github.com/google/wireit#indicating-external-environment-variables
lit · Jan 4, 2023 · d1f9d14 · d1f9d14
1 parent c77220e
commit d1f9d14
Show file tree

Hide file tree

Showing 18 changed files with 147 additions and 0 deletions.
diff --git a/.changeset/modern-pans-jam.md b/.changeset/modern-pans-jam.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/labs/context/package.json b/packages/labs/context/package.json
@@ -117,6 +117,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -126,6 +131,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     }

diff --git a/packages/labs/gen-wrapper-react/test-output/package.json b/packages/labs/gen-wrapper-react/test-output/package.json
@@ -72,6 +72,11 @@
         "../../../tests:build"
       ],
       "command": "node ../../../tests/run-web-tests.js \"tests/tests.js\" --config ../../../tests/web-test-runner.config.js",
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "output": []
     }
   }

diff --git a/packages/labs/gen-wrapper-vue/test-output/package.json b/packages/labs/gen-wrapper-vue/test-output/package.json
@@ -59,6 +59,11 @@
       ],
       "files": [],
       "command": "node ../../../tests/run-web-tests.js \"tests/**/tests.js\" --config ../../../tests/web-test-runner.config.js",
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "output": []
     }
   }

diff --git a/packages/labs/motion/package.json b/packages/labs/motion/package.json
@@ -125,6 +125,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -134,6 +139,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     }

diff --git a/packages/labs/observers/package.json b/packages/labs/observers/package.json
@@ -139,6 +139,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -148,6 +153,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     }

diff --git a/packages/labs/react/package.json b/packages/labs/react/package.json
@@ -121,6 +121,11 @@
         "../../reactive-element:build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -131,6 +136,11 @@
         "build:rollup",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     }

diff --git a/packages/labs/router/package.json b/packages/labs/router/package.json
@@ -68,6 +68,11 @@
         "build:rollup",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -78,6 +83,11 @@
         "build:rollup",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },

diff --git a/packages/labs/scoped-registry-mixin/package.json b/packages/labs/scoped-registry-mixin/package.json
@@ -120,6 +120,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -129,6 +134,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     }

diff --git a/packages/labs/ssr/package.json b/packages/labs/ssr/package.json
@@ -98,6 +98,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [
         "web-test-runner.config.js",
         "../../tests/web-test-runner.config.js"
@@ -110,6 +115,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [
         "web-test-runner.config.js",
         "../../tests/web-test-runner.config.js"

diff --git a/packages/labs/task/package.json b/packages/labs/task/package.json
@@ -118,6 +118,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -127,6 +132,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     }

diff --git a/packages/labs/testing/package.json b/packages/labs/testing/package.json
@@ -53,6 +53,11 @@
       "dependencies": [
         "build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [
         "web-test-runner.config.js"
       ],

diff --git a/packages/labs/virtualizer/package.json b/packages/labs/virtualizer/package.json
@@ -92,6 +92,11 @@
         "build",
         "../../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [
         "web-test-runner.config.js"
       ],

diff --git a/packages/lit-element/package.json b/packages/lit-element/package.json
@@ -209,6 +209,11 @@
         "build:ts",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -219,6 +224,11 @@
         "build:rollup",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },

diff --git a/packages/lit-html/package.json b/packages/lit-html/package.json
@@ -417,6 +417,11 @@
         "build:ts",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -428,6 +433,11 @@
         "build:version-stability-test",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },

diff --git a/packages/lit/package.json b/packages/lit/package.json
@@ -284,6 +284,11 @@
         "build:ts",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -297,6 +302,11 @@
         "build:rollup",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },

diff --git a/packages/localize/package.json b/packages/localize/package.json
@@ -53,6 +53,11 @@
         "build",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [
         "web-test-runner.config.js"
       ],

diff --git a/packages/reactive-element/package.json b/packages/reactive-element/package.json
@@ -273,6 +273,11 @@
         "build:babel",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },
@@ -284,6 +289,11 @@
         "build:babel",
         "../tests:build"
       ],
+      "env": {
+        "BROWSERS": {
+          "external": true
+        }
+      },
       "files": [],
       "output": []
     },