Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Sources not inlined in sourcemap #3107

Closed
gberaudo opened this issue Jun 30, 2022 · 1 comment · Fixed by #3198
Closed

[infra] Sources not inlined in sourcemap #3107

gberaudo opened this issue Jun 30, 2022 · 1 comment · Fixed by #3198
Assignees

Comments

@gberaudo
Copy link

Which package(s) are affected?

Localize (@lit/localize)

Description

The tsconfig.json of serveral lit packages do not use the inlineSources: true configuration. This is inconsistent with the other packages and make lit-localize original source not available for debugging.

Here is the list of packages:

  • localize-tools;
  • localize;
  • tests.

I prepared a commit with the fix locally but I don't have the Google CLA signed yet.
It will certainly be faster if someone with accepted CLA creates the pull request.

Reproduction

I detected the issue while using the parceljs v2 bundler.

Workaround

None

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

Failing in 0.11.3

Browser/OS/Node environment

This is independent of the browser.

@justinfagnani justinfagnani changed the title Sources not inlined in sourcemap [infra] Sources not inlined in sourcemap Jun 30, 2022
@justinfagnani
Copy link
Collaborator

Thanks for the good report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants