Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[localize & labs/testing] Inline TS source in JS source map #3198

Merged
merged 3 commits into from Aug 5, 2022

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Aug 4, 2022

Fixes #3107

Both localize and labs/testing packages were missing inlineSources: true in their tsconfig. This PR fixes that.

Also added declarationMap: true for localize.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

🦋 Changeset detected

Latest commit: 6ba9940

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit-labs/testing Patch
@lit/localize Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -1% - +2% (-0.16ms - +0.38ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 66.61ms - 72.57ms
  • lit-html-kitchen-sink: unsure 🔍 -1% - +0% (-0.28ms - +0.03ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +2% (-0.31ms - +0.15ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.61ms - +1.50ms)
    this-change vs tip-of-tree
  • reactive-element-list: slower ❌ 0% - 2% (0.07ms - 1.07ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 548.82ms - 580.26ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-1.79ms - +2.41ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +1% (-4.50ms - +3.72ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.90ms - +2.27ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-3.47ms - +7.75ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 535.15ms - 569.99ms
  • reactive-element-list: unsure 🔍 -1% - +3% (-4.14ms - +15.95ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
66.61ms - 72.57ms-

update

VersionAvg timevs
548.82ms - 580.26ms-

update-reflect

VersionAvg timevs
535.15ms - 569.99ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
24.10ms - 24.30ms-unsure 🔍
-1% - +0%
-0.28ms - +0.03ms
unsure 🔍
-1% - +0%
-0.32ms - +0.02ms
tip-of-tree
tip-of-tree
24.21ms - 24.44msunsure 🔍
-0% - +1%
-0.03ms - +0.28ms
-unsure 🔍
-1% - +1%
-0.20ms - +0.15ms
previous-release
previous-release
24.21ms - 24.48msunsure 🔍
-0% - +1%
-0.02ms - +0.32ms
unsure 🔍
-1% - +1%
-0.15ms - +0.20ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
73.47ms - 76.38ms-unsure 🔍
-2% - +3%
-1.79ms - +2.41ms
unsure 🔍
-6% - +1%
-4.92ms - +0.80ms
tip-of-tree
tip-of-tree
73.10ms - 76.12msunsure 🔍
-3% - +2%
-2.41ms - +1.79ms
-unsure 🔍
-7% - +1%
-5.26ms - +0.52ms
previous-release
previous-release
74.52ms - 79.45msunsure 🔍
-1% - +7%
-0.80ms - +4.92ms
unsure 🔍
-1% - +7%
-0.52ms - +5.26ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
24.86ms - 25.26ms-unsure 🔍
-1% - +2%
-0.16ms - +0.38ms
unsure 🔍
-4% - +1%
-0.95ms - +0.31ms
tip-of-tree
tip-of-tree
24.77ms - 25.13msunsure 🔍
-2% - +1%
-0.38ms - +0.16ms
-unsure 🔍
-4% - +1%
-1.05ms - +0.19ms
previous-release
previous-release
24.78ms - 25.98msunsure 🔍
-1% - +4%
-0.31ms - +0.95ms
unsure 🔍
-1% - +4%
-0.19ms - +1.05ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
7.79ms - 8.06ms-unsure 🔍
-4% - +2%
-0.31ms - +0.15ms
unsure 🔍
-2% - +2%
-0.18ms - +0.19ms
tip-of-tree
tip-of-tree
7.81ms - 8.19msunsure 🔍
-2% - +4%
-0.15ms - +0.31ms
-unsure 🔍
-2% - +4%
-0.14ms - +0.31ms
previous-release
previous-release
7.79ms - 8.05msunsure 🔍
-2% - +2%
-0.19ms - +0.18ms
unsure 🔍
-4% - +2%
-0.31ms - +0.14ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
273.09ms - 279.67ms-unsure 🔍
-2% - +1%
-4.50ms - +3.72ms
unsure 🔍
-2% - +1%
-6.14ms - +2.84ms
tip-of-tree
tip-of-tree
274.32ms - 279.23msunsure 🔍
-1% - +2%
-3.72ms - +4.50ms
-unsure 🔍
-2% - +1%
-5.18ms - +2.66ms
previous-release
previous-release
274.98ms - 281.09msunsure 🔍
-1% - +2%
-2.84ms - +6.14ms
unsure 🔍
-1% - +2%
-2.66ms - +5.18ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
45.79ms - 47.88ms-unsure 🔍
-1% - +3%
-0.61ms - +1.50ms
unsure 🔍
-4% - +3%
-1.75ms - +1.46ms
tip-of-tree
tip-of-tree
46.26ms - 46.53msunsure 🔍
-3% - +1%
-1.50ms - +0.61ms
-unsure 🔍
-4% - +1%
-1.81ms - +0.64ms
previous-release
previous-release
45.76ms - 48.20msunsure 🔍
-3% - +4%
-1.46ms - +1.75ms
unsure 🔍
-1% - +4%
-0.64ms - +1.81ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
88.80ms - 91.87ms-unsure 🔍
-1% - +3%
-0.90ms - +2.27ms
unsure 🔍
-1% - +2%
-0.92ms - +2.22ms
tip-of-tree
tip-of-tree
89.27ms - 90.05msunsure 🔍
-2% - +1%
-2.27ms - +0.90ms
-unsure 🔍
-1% - +1%
-0.55ms - +0.48ms
previous-release
previous-release
89.36ms - 90.02msunsure 🔍
-2% - +1%
-2.22ms - +0.92ms
unsure 🔍
-1% - +1%
-0.48ms - +0.55ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
44.94ms - 45.56ms-slower ❌
0% - 2%
0.07ms - 1.07ms
unsure 🔍
-2% - +1%
-1.03ms - +0.67ms
tip-of-tree
tip-of-tree
44.29ms - 45.07msfaster ✔
0% - 2%
0.07ms - 1.07ms
-unsure 🔍
-4% - +0%
-1.63ms - +0.13ms
previous-release
previous-release
44.64ms - 46.22msunsure 🔍
-1% - +2%
-0.67ms - +1.03ms
unsure 🔍
-0% - +4%
-0.13ms - +1.63ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
531.45ms - 541.77ms-unsure 🔍
-1% - +1%
-3.47ms - +7.75ms
unsure 🔍
-1% - +2%
-2.74ms - +8.50ms
tip-of-tree
tip-of-tree
532.27ms - 536.67msunsure 🔍
-1% - +1%
-7.75ms - +3.47ms
-unsure 🔍
-0% - +1%
-2.38ms - +3.86ms
previous-release
previous-release
531.51ms - 535.94msunsure 🔍
-2% - +1%
-8.50ms - +2.74ms
unsure 🔍
-1% - +0%
-3.86ms - +2.38ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
621.48ms - 631.76ms-unsure 🔍
-1% - +3%
-4.14ms - +15.95ms
unsure 🔍
-1% - +2%
-5.46ms - +9.39ms
tip-of-tree
tip-of-tree
612.08ms - 629.34msunsure 🔍
-3% - +1%
-15.95ms - +4.14ms
-unsure 🔍
-2% - +1%
-14.10ms - +6.22ms
previous-release
previous-release
619.29ms - 630.01msunsure 🔍
-1% - +1%
-9.39ms - +5.46ms
unsure 🔍
-1% - +2%
-6.22ms - +14.10ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@augustjk augustjk merged commit 0162fba into main Aug 5, 2022
@augustjk augustjk deleted the localize-inline-source branch August 5, 2022 21:27
@lit-robot lit-robot mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[infra] Sources not inlined in sourcemap
3 participants