Add prefix to stable properties to avoid collisions with short user properties

[kevinpschaaf]

Add prefix to stable properties to avoid collisions with short user properties.

Also centralizes per-package class prefixes to validate prefixes aren't duplicated since the rollup configs tend to be copy/pasted and it'd be easy to forget to choose a new unique prefix for a new package.

Fixes #1925

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• lit-html-kitchen-sink: unsure 🔍 -2% - +2% (-0.74ms - +0.66ms)
  ^{this-change vs tip-of-tree}

render

• lit-element-list: unsure 🔍 -1% - +1% (-0.80ms - +1.21ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -2% - +2% (-0.84ms - +0.71ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -4% - +4% (-0.49ms - +0.57ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -2% - +3% (-1.57ms - +1.86ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +1% (-1.38ms - +0.78ms)
  ^{this-change vs tip-of-tree}

update

• lit-element-list: unsure 🔍 -0% - +1% (-3.56ms - +9.02ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -3% - +2% (-2.67ms - +1.97ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -1% - +1% (-5.73ms - +3.28ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.70ms - +1.84ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -1% - +1% (-3.99ms - +8.43ms)
  ^{this-change vs tip-of-tree}

update-reflect

• lit-element-list: unsure 🔍 -1% - +1% (-7.26ms - +9.48ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -1% - +1% (-6.69ms - +10.17ms)
  ^{this-change vs tip-of-tree}

Results

lit-element-list

• Browser: chrome-headless 91.0.4472.77
• Sample size: 50
• Built by: Benchmarks #1528

• Commit: 3c439d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	96.32ms - 97.93ms	-	unsure 🔍 -1% - +1% -0.80ms - +1.21ms	faster ✔ 19% - 21% 22.93ms - 25.17ms
tip-of-tree tip-of-tree	96.31ms - 97.53ms	unsure 🔍 -1% - +1% -1.21ms - +0.80ms	-	faster ✔ 19% - 21% 23.26ms - 25.24ms
previous-release previous-release	120.39ms - 121.95ms	slower ❌ 23% - 26% 22.93ms - 25.17ms	slower ❌ 24% - 26% 23.26ms - 25.24ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	783.93ms - 792.31ms	-	unsure 🔍 -0% - +1% -3.56ms - +9.02ms	faster ✔ 8% - 9% 66.82ms - 78.26ms
tip-of-tree tip-of-tree	780.70ms - 790.08ms	unsure 🔍 -1% - +0% -9.02ms - +3.56ms	-	faster ✔ 8% - 9% 69.17ms - 81.36ms
previous-release previous-release	856.76ms - 864.55ms	slower ❌ 8% - 10% 66.82ms - 78.26ms	slower ❌ 9% - 10% 69.17ms - 81.36ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	847.97ms - 859.02ms	-	unsure 🔍 -1% - +1% -7.26ms - +9.48ms	faster ✔ 3% - 5% 25.15ms - 41.20ms
tip-of-tree tip-of-tree	846.09ms - 858.67ms	unsure 🔍 -1% - +1% -9.48ms - +7.26ms	-	faster ✔ 3% - 5% 25.72ms - 42.86ms
previous-release previous-release	880.85ms - 892.49ms	slower ❌ 3% - 5% 25.15ms - 41.20ms	slower ❌ 3% - 5% 25.72ms - 42.86ms	-

lit-html-kitchen-sink

• Browser: chrome-headless 91.0.4472.77
• Sample size: 30
• Built by: Benchmarks #1528

• Commit: 3c439d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	39.26ms - 40.35ms	-	unsure 🔍 -2% - +2% -0.84ms - +0.71ms	faster ✔ 18% - 21% 9.04ms - 10.65ms
tip-of-tree tip-of-tree	39.32ms - 40.42ms	unsure 🔍 -2% - +2% -0.71ms - +0.84ms	-	faster ✔ 18% - 21% 8.97ms - 10.59ms
previous-release previous-release	49.05ms - 50.24ms	slower ❌ 22% - 27% 9.04ms - 10.65ms	slower ❌ 22% - 27% 8.97ms - 10.59ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	100.07ms - 103.39ms	-	unsure 🔍 -3% - +2% -2.67ms - +1.97ms	faster ✔ 0% - 7% 0.19ms - 7.48ms
tip-of-tree tip-of-tree	100.47ms - 103.70ms	unsure 🔍 -2% - +3% -1.97ms - +2.67ms	-	unsure 🔍 -7% - +0% -7.11ms - +0.14ms
previous-release previous-release	102.32ms - 108.81ms	slower ❌ 0% - 7% 0.19ms - 7.48ms	unsure 🔍 -0% - +7% -0.14ms - +7.11ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	35.87ms - 36.84ms	-	unsure 🔍 -2% - +2% -0.74ms - +0.66ms	slower ❌ 1% - 6% 0.48ms - 2.04ms
tip-of-tree tip-of-tree	35.89ms - 36.89ms	unsure 🔍 -2% - +2% -0.66ms - +0.74ms	-	slower ❌ 1% - 6% 0.51ms - 2.09ms
previous-release previous-release	34.48ms - 35.70ms	faster ✔ 1% - 6% 0.48ms - 2.04ms	faster ✔ 1% - 6% 0.51ms - 2.09ms	-

lit-html-repeat

• Browser: chrome-headless 91.0.4472.77
• Sample size: 30
• Built by: Benchmarks #1528

• Commit: 3c439d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.24ms - 13.99ms	-	unsure 🔍 -4% - +4% -0.49ms - +0.57ms	faster ✔ 12% - 18% 1.79ms - 3.00ms
tip-of-tree tip-of-tree	13.20ms - 13.95ms	unsure 🔍 -4% - +4% -0.57ms - +0.49ms	-	faster ✔ 12% - 19% 1.83ms - 3.04ms
previous-release previous-release	15.54ms - 16.49ms	slower ❌ 13% - 22% 1.79ms - 3.00ms	slower ❌ 13% - 23% 1.83ms - 3.04ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	414.46ms - 419.83ms	-	unsure 🔍 -1% - +1% -5.73ms - +3.28ms	faster ✔ 28% - 29% 162.11ms - 173.09ms
tip-of-tree tip-of-tree	414.75ms - 421.98ms	unsure 🔍 -1% - +1% -3.28ms - +5.73ms	-	faster ✔ 28% - 29% 160.38ms - 172.37ms
previous-release previous-release	579.96ms - 589.53ms	slower ❌ 39% - 42% 162.11ms - 173.09ms	slower ❌ 38% - 41% 160.38ms - 172.37ms	-

lit-html-template-heavy

• Browser: chrome-headless 91.0.4472.77
• Sample size: 50
• Built by: Benchmarks #1528

• Commit: 3c439d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	66.13ms - 68.96ms	-	unsure 🔍 -2% - +3% -1.57ms - +1.86ms	faster ✔ 15% - 18% 11.86ms - 14.99ms
tip-of-tree tip-of-tree	66.43ms - 68.37ms	unsure 🔍 -3% - +2% -1.86ms - +1.57ms	-	faster ✔ 15% - 18% 12.40ms - 14.75ms
previous-release previous-release	80.30ms - 81.64ms	slower ❌ 17% - 23% 11.86ms - 14.99ms	slower ❌ 18% - 22% 12.40ms - 14.75ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	133.64ms - 136.33ms	-	unsure 🔍 -1% - +1% -1.70ms - +1.84ms	faster ✔ 11% - 14% 17.06ms - 21.41ms
tip-of-tree tip-of-tree	133.76ms - 136.06ms	unsure 🔍 -1% - +1% -1.84ms - +1.70ms	-	faster ✔ 11% - 14% 17.25ms - 21.37ms
previous-release previous-release	152.51ms - 155.93ms	slower ❌ 13% - 16% 17.06ms - 21.41ms	slower ❌ 13% - 16% 17.25ms - 21.37ms	-

reactive-element-list

• Browser: chrome-headless 91.0.4472.77
• Sample size: 50
• Built by: Benchmarks #1528

• Commit: 3c439d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	66.15ms - 67.13ms	-	unsure 🔍 -2% - +1% -1.38ms - +0.78ms	unsure 🔍 -0% - +2% -0.19ms - +1.24ms
tip-of-tree tip-of-tree	65.97ms - 67.91ms	unsure 🔍 -1% - +2% -0.78ms - +1.38ms	-	unsure 🔍 -0% - +3% -0.27ms - +1.93ms
previous-release previous-release	65.59ms - 66.64ms	unsure 🔍 -2% - +0% -1.24ms - +0.19ms	unsure 🔍 -3% - +0% -1.93ms - +0.27ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	791.70ms - 800.15ms	-	unsure 🔍 -1% - +1% -3.99ms - +8.43ms	unsure 🔍 -0% - +1% -2.74ms - +8.97ms
tip-of-tree tip-of-tree	789.15ms - 798.26ms	unsure 🔍 -1% - +1% -8.43ms - +3.99ms	-	unsure 🔍 -1% - +1% -5.20ms - +6.99ms
previous-release previous-release	788.76ms - 796.87ms	unsure 🔍 -1% - +0% -8.97ms - +2.74ms	unsure 🔍 -1% - +1% -6.99ms - +5.20ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	879.59ms - 891.47ms	-	unsure 🔍 -1% - +1% -6.69ms - +10.17ms	unsure 🔍 -1% - +1% -4.72ms - +11.16ms
tip-of-tree tip-of-tree	877.81ms - 889.78ms	unsure 🔍 -1% - +1% -10.17ms - +6.69ms	-	unsure 🔍 -1% - +1% -6.49ms - +9.46ms
previous-release previous-release	877.04ms - 887.58ms	unsure 🔍 -1% - +1% -11.16ms - +4.72ms	unsure 🔍 -1% - +1% -9.46ms - +6.49ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[AndrewJakubowicz]

Looks good to me. I also checked out locally and took a look at the minified build.