Makes properties that should remain unminified compatible with tools …

[sorvell]

…other than rollup/terser

Fixes #1970.

Note, does not appear to impact build size at all.

[changeset-bot]

🦋 Changeset detected

Latest commit: 73c3e85

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• lit-html-kitchen-sink: unsure 🔍 -0% - +3% (-0.06ms - +0.93ms)
  ^{this-change vs tip-of-tree}

render

• lit-element-list: faster ✔ 0% - 1% (0.20ms - 0.79ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -1% - +0% (-0.25ms - +0.09ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -2% - +1% (-0.22ms - +0.11ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -5% - +1% (-3.16ms - +0.51ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +0% (-0.95ms - +0.24ms)
  ^{this-change vs tip-of-tree}

update

• lit-element-list: unsure 🔍 -1% - +0% (-6.17ms - +1.13ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-1.75ms - +2.21ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -1% - +0% (-3.31ms - +1.19ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.20ms - +2.23ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -0% - +2% (-1.96ms - +10.27ms)
  ^{this-change vs tip-of-tree}

update-reflect

• lit-element-list: unsure 🔍 -1% - +1% (-3.84ms - +7.82ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -1% - +1% (-6.53ms - +8.37ms)
  ^{this-change vs tip-of-tree}

Results

lit-element-list

• Browser: chrome-headless 91.0.4472.114
• Sample size: 50
• Built by: Benchmarks #1582

• Commit: c5549b3

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	81.62ms - 81.92ms	-	faster ✔ 0% - 1% 0.20ms - 0.79ms	faster ✔ 20% - 21% 20.45ms - 21.43ms
tip-of-tree tip-of-tree	82.01ms - 82.52ms	slower ❌ 0% - 1% 0.20ms - 0.79ms	-	faster ✔ 19% - 20% 19.91ms - 20.98ms
previous-release previous-release	102.24ms - 103.18ms	slower ❌ 25% - 26% 20.45ms - 21.43ms	slower ❌ 24% - 26% 19.91ms - 20.98ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	669.23ms - 675.09ms	-	unsure 🔍 -1% - +0% -6.17ms - +1.13ms	faster ✔ 9% - 10% 67.53ms - 75.90ms
tip-of-tree tip-of-tree	672.51ms - 676.86ms	unsure 🔍 -0% - +1% -1.13ms - +6.17ms	-	faster ✔ 9% - 10% 65.50ms - 72.89ms
previous-release previous-release	740.89ms - 746.86ms	slower ❌ 10% - 11% 67.53ms - 75.90ms	slower ❌ 10% - 11% 65.50ms - 72.89ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	730.78ms - 739.43ms	-	unsure 🔍 -1% - +1% -3.84ms - +7.82ms	faster ✔ 3% - 4% 20.74ms - 32.34ms
tip-of-tree tip-of-tree	729.20ms - 737.03ms	unsure 🔍 -1% - +1% -7.82ms - +3.84ms	-	faster ✔ 3% - 4% 23.02ms - 34.03ms
previous-release previous-release	757.78ms - 765.51ms	slower ❌ 3% - 4% 20.74ms - 32.34ms	slower ❌ 3% - 5% 23.02ms - 34.03ms	-

lit-html-kitchen-sink

• Browser: chrome-headless 91.0.4472.114
• Sample size: 30
• Built by: Benchmarks #1582

• Commit: c5549b3

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.33ms - 33.57ms	-	unsure 🔍 -1% - +0% -0.25ms - +0.09ms	faster ✔ 17% - 18% 7.04ms - 7.56ms
tip-of-tree tip-of-tree	33.41ms - 33.65ms	unsure 🔍 -0% - +1% -0.09ms - +0.25ms	-	faster ✔ 17% - 18% 6.96ms - 7.48ms
previous-release previous-release	40.51ms - 40.98ms	slower ❌ 21% - 23% 7.04ms - 7.56ms	slower ❌ 21% - 22% 6.96ms - 7.48ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	80.83ms - 83.25ms	-	unsure 🔍 -2% - +3% -1.75ms - +2.21ms	faster ✔ 4% - 8% 3.74ms - 6.90ms
tip-of-tree tip-of-tree	80.24ms - 83.38ms	unsure 🔍 -3% - +2% -2.21ms - +1.75ms	-	faster ✔ 4% - 8% 3.67ms - 7.41ms
previous-release previous-release	86.34ms - 88.37ms	slower ❌ 4% - 8% 3.74ms - 6.90ms	slower ❌ 4% - 9% 3.67ms - 7.41ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.36ms - 30.00ms	-	unsure 🔍 -0% - +3% -0.06ms - +0.93ms	slower ❌ 2% - 5% 0.65ms - 1.51ms
tip-of-tree tip-of-tree	28.87ms - 29.62ms	unsure 🔍 -3% - +0% -0.93ms - +0.06ms	-	slower ❌ 1% - 4% 0.17ms - 1.12ms
previous-release previous-release	28.31ms - 28.89ms	faster ✔ 2% - 5% 0.65ms - 1.51ms	faster ✔ 1% - 4% 0.17ms - 1.12ms	-

lit-html-repeat

• Browser: chrome-headless 91.0.4472.114
• Sample size: 30
• Built by: Benchmarks #1582

• Commit: c5549b3

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.51ms - 11.74ms	-	unsure 🔍 -2% - +1% -0.22ms - +0.11ms	faster ✔ 11% - 14% 1.46ms - 1.80ms
tip-of-tree tip-of-tree	11.55ms - 11.80ms	unsure 🔍 -1% - +2% -0.11ms - +0.22ms	-	faster ✔ 11% - 13% 1.40ms - 1.76ms
previous-release previous-release	13.12ms - 13.39ms	slower ❌ 12% - 16% 1.46ms - 1.80ms	slower ❌ 12% - 15% 1.40ms - 1.76ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	347.13ms - 349.49ms	-	unsure 🔍 -1% - +0% -3.31ms - +1.19ms	faster ✔ 28% - 29% 133.52ms - 139.71ms
tip-of-tree tip-of-tree	347.45ms - 351.29ms	unsure 🔍 -0% - +1% -1.19ms - +3.31ms	-	faster ✔ 27% - 29% 132.11ms - 139.00ms
previous-release previous-release	482.06ms - 487.79ms	slower ❌ 38% - 40% 133.52ms - 139.71ms	slower ❌ 38% - 40% 132.11ms - 139.00ms	-

lit-html-template-heavy

• Browser: chrome-headless 91.0.4472.114
• Sample size: 50
• Built by: Benchmarks #1582

• Commit: c5549b3

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	55.78ms - 56.43ms	-	unsure 🔍 -5% - +1% -3.16ms - +0.51ms	faster ✔ 17% - 18% 11.18ms - 12.26ms
tip-of-tree tip-of-tree	55.62ms - 59.23ms	unsure 🔍 -1% - +6% -0.51ms - +3.16ms	-	faster ✔ 13% - 18% 8.54ms - 12.25ms
previous-release previous-release	67.39ms - 68.25ms	slower ❌ 20% - 22% 11.18ms - 12.26ms	slower ❌ 14% - 22% 8.54ms - 12.25ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	114.54ms - 117.08ms	-	unsure 🔍 -1% - +2% -1.20ms - +2.23ms	faster ✔ 11% - 13% 14.42ms - 17.76ms
tip-of-tree tip-of-tree	114.14ms - 116.45ms	unsure 🔍 -2% - +1% -2.23ms - +1.20ms	-	faster ✔ 11% - 14% 15.02ms - 18.19ms
previous-release previous-release	130.82ms - 132.98ms	slower ❌ 12% - 15% 14.42ms - 17.76ms	slower ❌ 13% - 16% 15.02ms - 18.19ms	-

reactive-element-list

• Browser: chrome-headless 91.0.4472.114
• Sample size: 50
• Built by: Benchmarks #1582

• Commit: c5549b3

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	55.36ms - 56.33ms	-	unsure 🔍 -2% - +0% -0.95ms - +0.24ms	unsure 🔍 -1% - +1% -0.82ms - +0.40ms
tip-of-tree tip-of-tree	55.85ms - 56.55ms	unsure 🔍 -0% - +2% -0.24ms - +0.95ms	-	unsure 🔍 -1% - +1% -0.37ms - +0.65ms
previous-release previous-release	55.69ms - 56.43ms	unsure 🔍 -1% - +1% -0.40ms - +0.82ms	unsure 🔍 -1% - +1% -0.65ms - +0.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	677.58ms - 685.46ms	-	unsure 🔍 -0% - +2% -1.96ms - +10.27ms	unsure 🔍 -1% - +1% -4.49ms - +6.81ms
tip-of-tree tip-of-tree	672.69ms - 682.04ms	unsure 🔍 -2% - +0% -10.27ms - +1.96ms	-	unsure 🔍 -1% - +0% -9.18ms - +3.19ms
previous-release previous-release	676.31ms - 684.41ms	unsure 🔍 -1% - +1% -6.81ms - +4.49ms	unsure 🔍 -0% - +1% -3.19ms - +9.18ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	759.65ms - 769.72ms	-	unsure 🔍 -1% - +1% -6.53ms - +8.37ms	faster ✔ 0% - 2% 0.04ms - 14.71ms
tip-of-tree tip-of-tree	758.27ms - 769.26ms	unsure 🔍 -1% - +1% -8.37ms - +6.53ms	-	faster ✔ 0% - 2% 0.64ms - 15.95ms
previous-release previous-release	766.73ms - 777.39ms	slower ❌ 0% - 2% 0.04ms - 14.71ms	slower ❌ 0% - 2% 0.64ms - 15.95ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[kevinpschaaf]

Actually, can you revert the changelog.md changes and instead do npm run changeset add?