Fix noted TODOs #2072

sorvell · 2021-08-21T01:25:42Z

Fixes doc link TODOs in LitElement and ReactiveElement
Fixes styling tests to include static bindings in lit-html and LitElement
Removes @queryAssignedNodes shim of Element.matches since this is now addressed via polyfills.

* Fixes doc link TODOs in LitElement and ReactiveElement * Fixes styling tests to include static bindings in lit-html and LitElement * Removes `@queryAssignedNodes` shim of `Element.matches` since this is now addressed via polyfills.

changeset-bot · 2021-08-21T01:25:48Z

🦋 Changeset detected

Latest commit: 7d80a64

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2021-08-21T01:33:01Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +19% (-1.18ms - +7.41ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -1% - +0% (-0.45ms - +0.35ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -7% - +3% (-2.82ms - +1.06ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -3% - +10% (-0.35ms - +1.17ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.75ms - +0.88ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-0.72ms - +0.65ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -1% - +0% (-3.88ms - +3.32ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -8% - +4% (-8.53ms - +4.95ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +0% (-4.56ms - +0.50ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.98ms - +3.63ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +0% (-6.39ms - +2.37ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-4.92ms - +3.94ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-6.88ms - +5.08ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1766
Commit: f7dee17

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	85.24ms - 85.78ms	-	unsure 🔍 -1% - +0% -0.45ms - +0.35ms	faster ✔ 21% - 22% 22.58ms - 23.97ms
tip-of-tree tip-of-tree	85.26ms - 85.85ms	unsure 🔍 -0% - +1% -0.35ms - +0.45ms	-	faster ✔ 21% - 22% 22.52ms - 23.93ms
previous-release previous-release	108.14ms - 109.42ms	slower ❌ 26% - 28% 22.58ms - 23.97ms	slower ❌ 26% - 28% 22.52ms - 23.93ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	719.46ms - 724.99ms	-	unsure 🔍 -1% - +0% -3.88ms - +3.32ms	faster ✔ 9% - 10% 70.84ms - 79.84ms
tip-of-tree tip-of-tree	720.20ms - 724.80ms	unsure 🔍 -0% - +1% -3.32ms - +3.88ms	-	faster ✔ 9% - 10% 70.83ms - 79.29ms
previous-release previous-release	794.01ms - 801.11ms	slower ❌ 10% - 11% 70.84ms - 79.84ms	slower ❌ 10% - 11% 70.83ms - 79.29ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	777.92ms - 783.82ms	-	unsure 🔍 -1% - +1% -4.92ms - +3.94ms	faster ✔ 4% - 5% 31.11ms - 41.22ms
tip-of-tree tip-of-tree	778.06ms - 784.67ms	unsure 🔍 -1% - +1% -3.94ms - +4.92ms	-	faster ✔ 4% - 5% 30.40ms - 40.95ms
previous-release previous-release	812.93ms - 821.14ms	slower ❌ 4% - 5% 31.11ms - 41.22ms	slower ❌ 4% - 5% 30.40ms - 40.95ms	-

lit-html-kitchen-sink

Browser: chrome-headless 92.0.4515.131
Sample size: 30
Built by: Benchmarks #1766
Commit: f7dee17

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	35.40ms - 38.30ms	-	unsure 🔍 -7% - +3% -2.82ms - +1.06ms	faster ✔ 27% - 36% 13.72ms - 20.28ms
tip-of-tree tip-of-tree	36.44ms - 39.02ms	unsure 🔍 -3% - +8% -1.06ms - +2.82ms	-	faster ✔ 25% - 34% 12.91ms - 19.33ms
previous-release previous-release	50.91ms - 56.80ms	slower ❌ 36% - 56% 13.72ms - 20.28ms	slower ❌ 34% - 52% 12.91ms - 19.33ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	103.85ms - 112.79ms	-	unsure 🔍 -8% - +4% -8.53ms - +4.95ms	unsure 🔍 -7% - +6% -7.49ms - +7.05ms
tip-of-tree tip-of-tree	105.06ms - 115.16ms	unsure 🔍 -5% - +8% -4.95ms - +8.53ms	-	unsure 🔍 -6% - +9% -6.08ms - +9.22ms
previous-release previous-release	102.80ms - 114.28ms	unsure 🔍 -7% - +7% -7.05ms - +7.49ms	unsure 🔍 -8% - +5% -9.22ms - +6.08ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	38.80ms - 45.65ms	-	unsure 🔍 -3% - +19% -1.18ms - +7.41ms	slower ❌ 6% - 32% 2.49ms - 11.16ms
tip-of-tree tip-of-tree	36.52ms - 41.70ms	unsure 🔍 -17% - +2% -7.41ms - +1.18ms	-	unsure 🔍 -1% - +22% +0.01ms - +7.42ms
previous-release previous-release	32.75ms - 38.05ms	faster ✔ 7% - 25% 2.49ms - 11.16ms	faster ✔ 0% - 19% 0.01ms - 7.42ms	-

lit-html-repeat

Browser: chrome-headless 92.0.4515.131
Sample size: 30
Built by: Benchmarks #1766
Commit: f7dee17

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.47ms - 12.99ms	-	unsure 🔍 -3% - +10% -0.35ms - +1.17ms	faster ✔ 4% - 15% 0.50ms - 2.05ms
tip-of-tree tip-of-tree	11.78ms - 11.86ms	unsure 🔍 -9% - +3% -1.17ms - +0.35ms	-	faster ✔ 12% - 13% 1.55ms - 1.82ms
previous-release previous-release	13.38ms - 13.63ms	slower ❌ 3% - 17% 0.50ms - 2.05ms	slower ❌ 13% - 15% 1.55ms - 1.82ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	364.28ms - 367.23ms	-	unsure 🔍 -1% - +0% -4.56ms - +0.50ms	faster ✔ 27% - 28% 134.05ms - 142.41ms
tip-of-tree tip-of-tree	365.73ms - 369.84ms	unsure 🔍 -0% - +1% -0.50ms - +4.56ms	-	faster ✔ 26% - 28% 131.78ms - 140.62ms
previous-release previous-release	500.08ms - 507.90ms	slower ❌ 37% - 39% 134.05ms - 142.41ms	slower ❌ 36% - 38% 131.78ms - 140.62ms	-

lit-html-template-heavy

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1766
Commit: f7dee17

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	59.51ms - 60.45ms	-	unsure 🔍 -1% - +1% -0.75ms - +0.88ms	faster ✔ 16% - 19% 11.39ms - 13.60ms
tip-of-tree tip-of-tree	59.25ms - 60.58ms	unsure 🔍 -1% - +1% -0.88ms - +0.75ms	-	faster ✔ 16% - 19% 11.36ms - 13.76ms
previous-release previous-release	71.47ms - 73.47ms	slower ❌ 19% - 23% 11.39ms - 13.60ms	slower ❌ 19% - 23% 11.36ms - 13.76ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	124.70ms - 128.76ms	-	unsure 🔍 -1% - +3% -0.98ms - +3.63ms	faster ✔ 10% - 13% 14.10ms - 18.50ms
tip-of-tree tip-of-tree	124.31ms - 126.49ms	unsure 🔍 -3% - +1% -3.63ms - +0.98ms	-	faster ✔ 11% - 13% 16.24ms - 19.01ms
previous-release previous-release	142.18ms - 143.88ms	slower ❌ 11% - 15% 14.10ms - 18.50ms	slower ❌ 13% - 15% 16.24ms - 19.01ms	-

reactive-element-list

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1766
Commit: f7dee17

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	58.89ms - 59.94ms	-	unsure 🔍 -1% - +1% -0.72ms - +0.65ms	unsure 🔍 -1% - +1% -0.88ms - +0.37ms
tip-of-tree tip-of-tree	59.01ms - 59.89ms	unsure 🔍 -1% - +1% -0.65ms - +0.72ms	-	unsure 🔍 -1% - +1% -0.78ms - +0.34ms
previous-release previous-release	59.32ms - 60.02ms	unsure 🔍 -1% - +1% -0.37ms - +0.88ms	unsure 🔍 -1% - +1% -0.34ms - +0.78ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	716.11ms - 722.87ms	-	unsure 🔍 -1% - +0% -6.39ms - +2.37ms	unsure 🔍 -1% - +0% -6.81ms - +3.27ms
tip-of-tree tip-of-tree	718.72ms - 724.28ms	unsure 🔍 -0% - +1% -2.37ms - +6.39ms	-	unsure 🔍 -1% - +1% -4.42ms - +4.90ms
previous-release previous-release	717.52ms - 725.00ms	unsure 🔍 -0% - +1% -3.27ms - +6.81ms	unsure 🔍 -1% - +1% -4.90ms - +4.42ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	807.70ms - 816.48ms	-	unsure 🔍 -1% - +1% -6.88ms - +5.08ms	unsure 🔍 -1% - +1% -6.61ms - +5.10ms
tip-of-tree tip-of-tree	808.93ms - 817.05ms	unsure 🔍 -1% - +1% -5.08ms - +6.88ms	-	unsure 🔍 -1% - +1% -5.46ms - +5.76ms
previous-release previous-release	808.97ms - 816.72ms	unsure 🔍 -1% - +1% -5.10ms - +6.61ms	unsure 🔍 -1% - +1% -5.76ms - +5.46ms	-

_{tachometer-reporter-action v2 for Benchmarks}

kevinpschaaf

Failing test on matches, not sure what's up since it seems like webcomponents/polyfills#400 was merged long ago.

Also cc: @arthurevans @aomarks since this is the first time we're putting website URLs in code (references to docs from devmode warnings). It would be really nice to indirect through a URL shortener so we could update links if they change. Would it be easy to make a redirect config on lit.dev so the code could link to lit.dev/msg/0001 or lit.dev/msg/method-removed and have that redirect to a configurable spot?

kevinpschaaf · 2021-08-21T01:47:29Z

packages/reactive-element/src/decorators/query-assigned-nodes.ts

-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-const ElementProto = Element.prototype as any;
-const legacyMatches =
-  ElementProto.msMatchesSelector || ElementProto.webkitMatchesSelector;


tests: ❌ @queryAssignedNodes > returns assignedNodes for slot that contains text nodes filtered by selector when Element.matches does not exist tests: TypeError: node.matches is not a function tests: at ../reactive-element/src/decorators/query-assigned-nodes.ts:60:32 tests: at Array.filter (<anonymous>) tests: at HTMLElement.get [as footerAssignedItems] (../reactive-element/src/decorators/query-assigned-nodes.ts:57:24) tests: at o.<anonymous> (../reactive-element/src/test/decorators/queryAssignedNodes_test.ts:221:40)

😭

kevinpschaaf · 2021-08-21T02:00:00Z

Also, changeset please

kevinpschaaf

I added #2078 to track whether we want to change deep lit.dev links to a flat/shortened redirectable scheme.

Address TODO fixes

916d4f0

* Fixes doc link TODOs in LitElement and ReactiveElement * Fixes styling tests to include static bindings in lit-html and LitElement * Removes `@queryAssignedNodes` shim of `Element.matches` since this is now addressed via polyfills.

sorvell requested a review from kevinpschaaf August 21, 2021 01:25

sorvell requested a review from justinfagnani as a code owner August 21, 2021 01:25

sorvell added this to the Lit RC.next milestone Aug 21, 2021

google-cla bot added the cla: yes label Aug 21, 2021

kevinpschaaf reviewed Aug 21, 2021

View reviewed changes

Steven Orvell added 2 commits August 21, 2021 10:40

Update test to not test removed shimming of matches

6404407

Add changeset

241e7f6

kevinpschaaf approved these changes Aug 23, 2021

View reviewed changes

Steven Orvell added 3 commits August 26, 2021 12:33

Merge branch 'main' into todo-fix-re-le

91a937b

Update package-locks

cac9400

Merge fix.

7d80a64

justinfagnani approved these changes Aug 27, 2021

View reviewed changes

sorvell merged commit 7adfbb0 into main Aug 27, 2021

sorvell deleted the todo-fix-re-le branch August 27, 2021 01:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix noted TODOs #2072

Fix noted TODOs #2072

sorvell commented Aug 21, 2021

changeset-bot bot commented Aug 21, 2021 •

edited

github-actions bot commented Aug 21, 2021 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

kevinpschaaf left a comment

kevinpschaaf Aug 21, 2021

kevinpschaaf commented Aug 21, 2021

kevinpschaaf left a comment

Fix noted TODOs #2072

Fix noted TODOs #2072

Conversation

sorvell commented Aug 21, 2021

changeset-bot bot commented Aug 21, 2021 • edited

🦋 Changeset detected

github-actions bot commented Aug 21, 2021 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

kevinpschaaf left a comment

Choose a reason for hiding this comment

kevinpschaaf Aug 21, 2021

Choose a reason for hiding this comment

kevinpschaaf commented Aug 21, 2021

kevinpschaaf left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Aug 21, 2021 •

edited

github-actions bot commented Aug 21, 2021 •

edited