Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lit.dev short links to dev mode warnings #2119

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Sep 1, 2021

Adds a See https://lit.dev/msg/<code> for more information. string to all warnings logged by Lit's dev mode.

Half of #2078. Other half is at lit/lit.dev#465.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2021

🦋 Changeset detected

Latest commit: 867437d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -10% - +9% (-3.30ms - +3.03ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -3% - +1% (-2.39ms - +1.12ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -4% - +13% (-1.55ms - +4.59ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -14% - +4% (-1.82ms - +0.58ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +0% (-2.93ms - +0.24ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-1.93ms - +1.06ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +2% (-8.81ms - +9.96ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -7% - +8% (-6.68ms - +7.23ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +1% (-11.98ms - +3.95ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-3.05ms - +1.47ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +2% (-8.70ms - +11.07ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -2% - +1% (-12.21ms - +5.53ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +2% (-9.67ms - +13.13ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
100.50ms - 102.62ms-unsure 🔍
-0% - +3%
-0.32ms - +2.65ms
faster ✔
19% - 21%
23.78ms - 27.45ms
tip-of-tree
tip-of-tree
99.35ms - 101.44msunsure 🔍
-3% - +0%
-2.65ms - +0.32ms
-faster ✔
20% - 22%
24.96ms - 28.61ms
previous-release
previous-release
125.68ms - 128.68msslower ❌
23% - 27%
23.78ms - 27.45ms
slower ❌
25% - 29%
24.96ms - 28.61ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
813.73ms - 828.82ms-unsure 🔍
-1% - +2%
-6.95ms - +14.23ms
faster ✔
8% - 11%
72.66ms - 98.53ms
tip-of-tree
tip-of-tree
810.21ms - 825.06msunsure 🔍
-2% - +1%
-14.23ms - +6.95ms
-faster ✔
9% - 11%
76.37ms - 102.10ms
previous-release
previous-release
896.37ms - 917.38msslower ❌
9% - 12%
72.66ms - 98.53ms
slower ❌
9% - 13%
76.37ms - 102.10ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
860.38ms - 874.41ms-unsure 🔍
-2% - +1%
-15.97ms - +6.92ms
faster ✔
4% - 6%
33.78ms - 53.16ms
tip-of-tree
tip-of-tree
862.88ms - 880.96msunsure 🔍
-1% - +2%
-6.92ms - +15.97ms
-faster ✔
3% - 5%
27.70ms - 50.19ms
previous-release
previous-release
904.18ms - 917.55msslower ❌
4% - 6%
33.78ms - 53.16ms
slower ❌
3% - 6%
27.70ms - 50.19ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.90ms - 39.67ms-unsure 🔍
-4% - +13%
-1.55ms - +4.59ms
faster ✔
15% - 30%
6.57ms - 14.77ms
tip-of-tree
tip-of-tree
34.22ms - 36.30msunsure 🔍
-12% - +4%
-4.59ms - +1.55ms
-faster ✔
21% - 31%
9.09ms - 15.29ms
previous-release
previous-release
44.54ms - 50.37msslower ❌
16% - 42%
6.57ms - 14.77ms
slower ❌
25% - 44%
9.09ms - 15.29ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
88.78ms - 98.14ms-unsure 🔍
-7% - +8%
-6.68ms - +7.23ms
unsure 🔍
-8% - +5%
-7.40ms - +4.38ms
tip-of-tree
tip-of-tree
88.04ms - 98.33msunsure 🔍
-8% - +7%
-7.23ms - +6.68ms
-unsure 🔍
-8% - +5%
-8.05ms - +4.48ms
previous-release
previous-release
91.40ms - 98.54msunsure 🔍
-5% - +8%
-4.38ms - +7.40ms
unsure 🔍
-5% - +9%
-4.48ms - +8.05ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
29.90ms - 34.13ms-unsure 🔍
-10% - +9%
-3.30ms - +3.03ms
unsure 🔍
-11% - +6%
-3.73ms - +1.89ms
tip-of-tree
tip-of-tree
29.80ms - 34.50msunsure 🔍
-9% - +10%
-3.03ms - +3.30ms
-unsure 🔍
-11% - +7%
-3.77ms - +2.21ms
previous-release
previous-release
31.09ms - 34.78msunsure 🔍
-6% - +12%
-1.89ms - +3.73ms
unsure 🔍
-7% - +12%
-2.21ms - +3.77ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.62ms - 14.34ms-unsure 🔍
-5% - +2%
-0.67ms - +0.29ms
faster ✔
9% - 15%
1.35ms - 2.40ms
tip-of-tree
tip-of-tree
13.85ms - 14.49msunsure 🔍
-2% - +5%
-0.29ms - +0.67ms
-faster ✔
8% - 14%
1.19ms - 2.19ms
previous-release
previous-release
15.47ms - 16.24msslower ❌
9% - 17%
1.35ms - 2.40ms
slower ❌
8% - 16%
1.19ms - 2.19ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
418.87ms - 428.65ms-unsure 🔍
-3% - +0%
-14.03ms - +1.18ms
faster ✔
28% - 30%
164.23ms - 182.18ms
tip-of-tree
tip-of-tree
424.36ms - 436.00msunsure 🔍
-0% - +3%
-1.18ms - +14.03ms
-faster ✔
27% - 29%
157.26ms - 176.30ms
previous-release
previous-release
589.43ms - 604.49msslower ❌
38% - 43%
164.23ms - 182.18ms
slower ❌
36% - 41%
157.26ms - 176.30ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.51ms - 57.26ms-unsure 🔍
-5% - +0%
-2.93ms - +0.24ms
faster ✔
17% - 22%
11.42ms - 15.44ms
tip-of-tree
tip-of-tree
56.42ms - 59.06msunsure 🔍
-0% - +5%
-0.24ms - +2.93ms
-faster ✔
14% - 20%
9.84ms - 14.32ms
previous-release
previous-release
68.01ms - 71.63msslower ❌
20% - 28%
11.42ms - 15.44ms
slower ❌
17% - 25%
9.84ms - 14.32ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
110.38ms - 113.34ms-unsure 🔍
-3% - +1%
-3.05ms - +1.47ms
faster ✔
12% - 16%
15.50ms - 21.24ms
tip-of-tree
tip-of-tree
110.94ms - 114.36msunsure 🔍
-1% - +3%
-1.47ms - +3.05ms
-faster ✔
11% - 16%
14.59ms - 20.57ms
previous-release
previous-release
127.78ms - 132.69msslower ❌
14% - 19%
15.50ms - 21.24ms
slower ❌
13% - 18%
14.59ms - 20.57ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
68.12ms - 70.05ms-unsure 🔍
-1% - +3%
-0.52ms - +2.01ms
unsure 🔍
-1% - +3%
-0.72ms - +1.73ms
tip-of-tree
tip-of-tree
67.52ms - 69.16msunsure 🔍
-3% - +1%
-2.01ms - +0.52ms
-unsure 🔍
-2% - +1%
-1.36ms - +0.88ms
previous-release
previous-release
67.82ms - 69.34msunsure 🔍
-2% - +1%
-1.73ms - +0.72ms
unsure 🔍
-1% - +2%
-0.88ms - +1.36ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
825.11ms - 841.41ms-unsure 🔍
-1% - +2%
-7.98ms - +15.63ms
unsure 🔍
-1% - +2%
-6.51ms - +15.80ms
tip-of-tree
tip-of-tree
820.90ms - 837.97msunsure 🔍
-2% - +1%
-15.63ms - +7.98ms
-unsure 🔍
-1% - +1%
-10.61ms - +12.26ms
previous-release
previous-release
821.00ms - 836.23msunsure 🔍
-2% - +1%
-15.80ms - +6.51ms
unsure 🔍
-1% - +1%
-12.26ms - +10.61ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
909.97ms - 932.47ms-unsure 🔍
-1% - +2%
-12.79ms - +20.06ms
unsure 🔍
-1% - +2%
-9.73ms - +19.16ms
tip-of-tree
tip-of-tree
905.61ms - 929.55msunsure 🔍
-2% - +1%
-20.06ms - +12.79ms
-unsure 🔍
-2% - +2%
-13.93ms - +16.09ms
previous-release
previous-release
907.45ms - 925.56msunsure 🔍
-2% - +1%
-19.16ms - +9.73ms
unsure 🔍
-2% - +2%
-16.09ms - +13.93ms
-

tachometer-reporter-action v2 for Benchmarks

aomarks added a commit to lit/lit.dev that referenced this pull request Sep 1, 2021
Adds a https://lit.dev/msg/<code> redirect for all warnings logged by Lit's dev mode.

Half of lit/lit#2078. Other half is at lit/lit#2119.
@aomarks aomarks merged commit 24feb43 into main Sep 1, 2021
@aomarks aomarks deleted the dev-msg-short-links branch September 1, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants