Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@labs/motion] Renames the flip() directive to animate() #2166

Merged
merged 10 commits into from
Sep 18, 2021

Conversation

sorvell
Copy link
Member

@sorvell sorvell commented Sep 17, 2021

In addition:

  • renames FlipController to AnimateController
  • renames AnimateOptions type to Options
  • renames the animate() config option animationOptions to keyframeOptions
  • renames the AnimateController animateOptions to defaultOptions

Refines various demos and refactors some internally used names.

Steven Orvell added 9 commits September 16, 2021 16:34
* `animate`: renamed `AnimateOptions` type to `Options`.
* `animate`: renamed `animationOptions` option to `keyframeOptions`
* `AnimateController`:  renamed `animateOptions` to `defaultOptions`
@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2021

🦋 Changeset detected

Latest commit: 0311073

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2021

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -1% - +1% (-0.22ms - +0.19ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +0% (-0.72ms - +0.22ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -0% - +1% (-0.09ms - +0.41ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +2% (-0.11ms - +0.21ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-1.47ms - +0.62ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-0.58ms - +0.40ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +0% (-3.45ms - +2.70ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -3% - +1% (-2.96ms - +0.89ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +1% (-3.83ms - +2.89ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -0% - +1% (-0.45ms - +1.00ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-3.80ms - +1.78ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +0% (-5.87ms - +3.18ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-2.55ms - +5.32ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
106.18ms - 109.37ms-unsure 🔍
-1% - +3%
-1.39ms - +3.11ms
faster ✔
21% - 24%
28.51ms - 33.57ms
tip-of-tree
tip-of-tree
105.33ms - 108.50msunsure 🔍
-3% - +1%
-3.11ms - +1.39ms
-faster ✔
21% - 25%
29.38ms - 34.43ms
previous-release
previous-release
136.85ms - 140.78msslower ❌
26% - 31%
28.51ms - 33.57ms
slower ❌
27% - 33%
29.38ms - 34.43ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
874.32ms - 890.23ms-unsure 🔍
-2% - +1%
-13.97ms - +8.57ms
faster ✔
8% - 10%
72.73ms - 96.22ms
tip-of-tree
tip-of-tree
876.99ms - 892.96msunsure 🔍
-1% - +2%
-8.57ms - +13.97ms
-faster ✔
7% - 10%
70.01ms - 93.54ms
previous-release
previous-release
958.11ms - 975.39msslower ❌
8% - 11%
72.73ms - 96.22ms
slower ❌
8% - 11%
70.01ms - 93.54ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
911.40ms - 928.34ms-unsure 🔍
-1% - +2%
-5.38ms - +17.47ms
faster ✔
5% - 8%
50.00ms - 76.41ms
tip-of-tree
tip-of-tree
906.15ms - 921.49msunsure 🔍
-2% - +1%
-17.47ms - +5.38ms
-faster ✔
6% - 8%
56.54ms - 81.96ms
previous-release
previous-release
972.94ms - 993.21msslower ❌
5% - 8%
50.00ms - 76.41ms
slower ❌
6% - 9%
56.54ms - 81.96ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
34.64ms - 35.08ms-unsure 🔍
-0% - +1%
-0.09ms - +0.41ms
faster ✔
16% - 17%
6.53ms - 7.24ms
tip-of-tree
tip-of-tree
34.59ms - 34.81msunsure 🔍
-1% - +0%
-0.41ms - +0.09ms
-faster ✔
16% - 17%
6.75ms - 7.34ms
previous-release
previous-release
41.47ms - 42.02msslower ❌
19% - 21%
6.53ms - 7.24ms
slower ❌
19% - 21%
6.75ms - 7.34ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
83.98ms - 85.54ms-unsure 🔍
-3% - +1%
-2.96ms - +0.89ms
faster ✔
3% - 6%
2.45ms - 5.24ms
tip-of-tree
tip-of-tree
84.04ms - 87.55msunsure 🔍
-1% - +3%
-0.89ms - +2.96ms
-faster ✔
1% - 6%
0.71ms - 4.92ms
previous-release
previous-release
87.45ms - 89.77msslower ❌
3% - 6%
2.45ms - 5.24ms
slower ❌
1% - 6%
0.71ms - 4.92ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
28.71ms - 28.95ms-unsure 🔍
-1% - +1%
-0.22ms - +0.19ms
faster ✔
0% - 2%
0.14ms - 0.70ms
tip-of-tree
tip-of-tree
28.67ms - 29.01msunsure 🔍
-1% - +1%
-0.19ms - +0.22ms
-faster ✔
0% - 2%
0.10ms - 0.71ms
previous-release
previous-release
28.99ms - 29.50msslower ❌
0% - 2%
0.14ms - 0.70ms
slower ❌
0% - 2%
0.10ms - 0.71ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
14.17ms - 15.52ms-unsure 🔍
-3% - +8%
-0.46ms - +1.14ms
faster ✔
2% - 13%
0.27ms - 2.15ms
tip-of-tree
tip-of-tree
14.09ms - 14.93msunsure 🔍
-8% - +3%
-1.14ms - +0.46ms
-faster ✔
5% - 14%
0.77ms - 2.32ms
previous-release
previous-release
15.40ms - 16.70msslower ❌
2% - 15%
0.27ms - 2.15ms
slower ❌
5% - 16%
0.77ms - 2.32ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
417.63ms - 437.47ms-unsure 🔍
-1% - +6%
-5.95ms - +23.34ms
faster ✔
26% - 31%
154.68ms - 193.01ms
tip-of-tree
tip-of-tree
408.09ms - 429.63msunsure 🔍
-5% - +1%
-23.34ms - +5.95ms
-faster ✔
28% - 33%
162.92ms - 202.16ms
previous-release
previous-release
585.00ms - 617.80msslower ❌
36% - 46%
154.68ms - 193.01ms
slower ❌
38% - 49%
162.92ms - 202.16ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.67ms - 56.23ms-unsure 🔍
-3% - +1%
-1.47ms - +0.62ms
faster ✔
18% - 19%
11.93ms - 12.71ms
tip-of-tree
tip-of-tree
55.37ms - 57.38msunsure 🔍
-1% - +3%
-0.62ms - +1.47ms
-faster ✔
16% - 19%
10.85ms - 12.94ms
previous-release
previous-release
68.00ms - 68.54msslower ❌
21% - 23%
11.93ms - 12.71ms
slower ❌
19% - 23%
10.85ms - 12.94ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
113.06ms - 114.11ms-unsure 🔍
-0% - +1%
-0.45ms - +1.00ms
faster ✔
11% - 12%
14.40ms - 15.87ms
tip-of-tree
tip-of-tree
112.81ms - 113.82msunsure 🔍
-1% - +0%
-1.00ms - +0.45ms
-faster ✔
11% - 12%
14.69ms - 16.12ms
previous-release
previous-release
128.20ms - 129.23msslower ❌
13% - 14%
14.40ms - 15.87ms
slower ❌
13% - 14%
14.69ms - 16.12ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
74.95ms - 77.62ms-unsure 🔍
-2% - +3%
-1.45ms - +2.11ms
unsure 🔍
-1% - +3%
-0.81ms - +2.31ms
tip-of-tree
tip-of-tree
74.78ms - 77.14msunsure 🔍
-3% - +2%
-2.11ms - +1.45ms
-unsure 🔍
-1% - +2%
-1.00ms - +1.85ms
previous-release
previous-release
74.73ms - 76.34msunsure 🔍
-3% - +1%
-2.31ms - +0.81ms
unsure 🔍
-2% - +1%
-1.85ms - +1.00ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
895.11ms - 916.64ms-unsure 🔍
-3% - +1%
-28.34ms - +5.80ms
unsure 🔍
-2% - +1%
-21.58ms - +11.21ms
tip-of-tree
tip-of-tree
903.91ms - 930.39msunsure 🔍
-1% - +3%
-5.80ms - +28.34ms
-unsure 🔍
-1% - +3%
-12.03ms - +24.20ms
previous-release
previous-release
898.70ms - 923.43msunsure 🔍
-1% - +2%
-11.21ms - +21.58ms
unsure 🔍
-3% - +1%
-24.20ms - +12.03ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
960.40ms - 992.92ms-unsure 🔍
-2% - +2%
-22.81ms - +18.68ms
unsure 🔍
-3% - +2%
-25.44ms - +17.76ms
tip-of-tree
tip-of-tree
965.85ms - 991.60msunsure 🔍
-2% - +2%
-18.68ms - +22.81ms
-unsure 🔍
-2% - +2%
-20.95ms - +17.41ms
previous-release
previous-release
966.28ms - 994.72msunsure 🔍
-2% - +3%
-17.76ms - +25.44ms
unsure 🔍
-2% - +2%
-17.41ms - +20.95ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani added this to the Lit RC.5 milestone Sep 18, 2021
@justinfagnani justinfagnani merged commit 94dff0a into main Sep 18, 2021
@justinfagnani justinfagnani deleted the flip-to-animate branch September 18, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants