Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reactive-element] Add queryAssignedElements decorator #2327

Merged
merged 9 commits into from
Dec 7, 2021
Merged

[reactive-element] Add queryAssignedElements decorator #2327

merged 9 commits into from
Dec 7, 2021

Commits on Dec 6, 2021

  1. Add queryAssignedElements decorator behaving as a declarative slot.as… 

    …signedElements

Add references to the new internal decorator across the monorepo packages.
    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    02ac04b View commit details
    Browse the repository at this point in the history

  2. Add QueryAssignedElementsVisitor to ts-transformers for new queryAssi… 

    …gnedElements.
    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    3534ccd View commit details
    Browse the repository at this point in the history

  3. Code review feedback. 

    `slot` instead of `slotName`.
Fix up copy pasted tests such that they are more modern, remove unused pieces.
Update the transformer tests.
    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    5437e70 View commit details
    Browse the repository at this point in the history

  4. Add changeset

    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    e114771 View commit details
    Browse the repository at this point in the history

  5. More code review feedback.

    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    f5f5353 View commit details
    Browse the repository at this point in the history

  6. Unblock ssr test breakage caused by query-assigned-elements.js not be… 

    …ing found.
    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    7a8f736 View commit details
    Browse the repository at this point in the history

  7. Address ts-transformers feedback and allow shorthand properties. 

    In this change made the transformer far more flexible. It no longer
forces string literal arguments, and instead utilizes template strings
to handle arbitrary expressions or identifiers.
    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    8413ed3 View commit details
    Browse the repository at this point in the history

  8. Transformer code review feedback: inline string literals & update tests.

    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    c3d0506 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Add feedback from Justin. 

    Some documentation updates and a missed optional chaining.
    @AndrewJakubowicz
    AndrewJakubowicz committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    b3dae4b View commit details
    Browse the repository at this point in the history