Add choose() directive

[justinfagnani]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 7545a5d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• lit-html-kitchen-sink: unsure 🔍 -13% - +4% (-4.73ms - +1.52ms)
  ^{this-change vs tip-of-tree}

render

• lit-element-list: unsure 🔍 -2% - +1% (-2.35ms - +0.95ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-1.80ms - +1.24ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -12% - +1% (-1.73ms - +0.24ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -3% - +2% (-1.66ms - +1.46ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +2% (-1.57ms - +1.34ms)
  ^{this-change vs tip-of-tree}

update

• lit-element-list: unsure 🔍 -1% - +1% (-11.13ms - +7.60ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -2% - +6% (-2.30ms - +7.14ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -2% - +2% (-5.25ms - +8.34ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -3% - +1% (-3.83ms - +2.11ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +1% (-16.54ms - +8.58ms)
  ^{this-change vs tip-of-tree}

update-reflect

• lit-element-list: unsure 🔍 -1% - +1% (-8.21ms - +8.24ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +1% (-18.04ms - +5.30ms)
  ^{this-change vs tip-of-tree}

Results

lit-element-list

• Browser: chrome-headless 96.0.4664.45
• Sample size: 50
• Built by: Benchmarks #2117

• Commit: 39d8064

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	96.92ms - 99.07ms	-	unsure 🔍 -2% - +1% -2.35ms - +0.95ms	faster ✔ 23% - 25% 28.76ms - 32.48ms
tip-of-tree tip-of-tree	97.45ms - 99.95ms	unsure 🔍 -1% - +2% -0.95ms - +2.35ms	-	faster ✔ 22% - 25% 27.95ms - 31.88ms
previous-release previous-release	127.10ms - 130.13ms	slower ❌ 29% - 33% 28.76ms - 32.48ms	slower ❌ 28% - 33% 27.95ms - 31.88ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	884.76ms - 898.31ms	-	unsure 🔍 -1% - +1% -11.13ms - +7.60ms	faster ✔ 7% - 9% 72.29ms - 90.94ms
tip-of-tree tip-of-tree	886.83ms - 899.77ms	unsure 🔍 -1% - +1% -7.60ms - +11.13ms	-	faster ✔ 7% - 9% 70.74ms - 88.95ms
previous-release previous-release	966.73ms - 979.56ms	slower ❌ 8% - 10% 72.29ms - 90.94ms	slower ❌ 8% - 10% 70.74ms - 88.95ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	987.28ms - 999.07ms	-	unsure 🔍 -1% - +1% -8.21ms - +8.24ms	faster ✔ 4% - 6% 44.19ms - 61.82ms
tip-of-tree tip-of-tree	987.43ms - 998.89ms	unsure 🔍 -1% - +1% -8.24ms - +8.21ms	-	faster ✔ 4% - 6% 44.31ms - 61.72ms
previous-release previous-release	1039.62ms - 1052.73ms	slower ❌ 4% - 6% 44.19ms - 61.82ms	slower ❌ 4% - 6% 44.31ms - 61.72ms	-

lit-html-kitchen-sink

• Browser: chrome-headless 96.0.4664.45
• Sample size: 30
• Built by: Benchmarks #2117

• Commit: 39d8064

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	41.22ms - 43.69ms	-	unsure 🔍 -4% - +3% -1.80ms - +1.24ms	faster ✔ 12% - 21% 5.55ms - 10.95ms
tip-of-tree tip-of-tree	41.86ms - 43.62ms	unsure 🔍 -3% - +4% -1.24ms - +1.80ms	-	faster ✔ 11% - 20% 5.42ms - 10.52ms
previous-release previous-release	48.31ms - 53.10ms	slower ❌ 13% - 26% 5.55ms - 10.95ms	slower ❌ 13% - 25% 5.42ms - 10.52ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	110.89ms - 118.21ms	-	unsure 🔍 -2% - +6% -2.30ms - +7.14ms	unsure 🔍 -9% - +3% -10.74ms - +3.65ms
tip-of-tree tip-of-tree	109.14ms - 115.11ms	unsure 🔍 -6% - +2% -7.14ms - +2.30ms	-	unsure 🔍 -11% - +1% -12.85ms - +0.91ms
previous-release previous-release	111.90ms - 124.29ms	unsure 🔍 -3% - +9% -3.65ms - +10.74ms	unsure 🔍 -1% - +12% -0.91ms - +12.85ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.10ms - 34.43ms	-	unsure 🔍 -13% - +4% -4.73ms - +1.52ms	faster ✔ 7% - 18% 2.60ms - 6.84ms
tip-of-tree tip-of-tree	31.72ms - 37.02ms	unsure 🔍 -5% - +15% -1.52ms - +4.73ms	-	faster ✔ 1% - 16% 0.16ms - 6.07ms
previous-release previous-release	36.18ms - 38.79ms	slower ❌ 7% - 21% 2.60ms - 6.84ms	unsure 🔍 -0% - +18% +0.16ms - +6.07ms	-

lit-html-repeat

• Browser: chrome-headless 96.0.4664.45
• Sample size: 30
• Built by: Benchmarks #2117

• Commit: 39d8064

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.30ms - 14.03ms	-	unsure 🔍 -12% - +1% -1.73ms - +0.24ms	faster ✔ 6% - 11% 0.81ms - 1.68ms
tip-of-tree tip-of-tree	13.50ms - 15.32ms	unsure 🔍 -2% - +13% -0.24ms - +1.73ms	-	unsure 🔍 -10% - +3% -1.45ms - +0.44ms
previous-release previous-release	14.68ms - 15.15ms	slower ❌ 6% - 13% 0.81ms - 1.68ms	unsure 🔍 -3% - +10% -0.44ms - +1.45ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	334.29ms - 345.00ms	-	unsure 🔍 -2% - +2% -5.25ms - +8.34ms	faster ✔ 31% - 34% 157.60ms - 175.15ms
tip-of-tree tip-of-tree	333.92ms - 342.28ms	unsure 🔍 -2% - +2% -8.34ms - +5.25ms	-	faster ✔ 32% - 34% 159.81ms - 176.03ms
previous-release previous-release	499.07ms - 512.97ms	slower ❌ 46% - 52% 157.60ms - 175.15ms	slower ❌ 47% - 52% 159.81ms - 176.03ms	-

lit-html-template-heavy

• Browser: chrome-headless 96.0.4664.45
• Sample size: 50
• Built by: Benchmarks #2117

• Commit: 39d8064

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	64.46ms - 66.66ms	-	unsure 🔍 -3% - +2% -1.66ms - +1.46ms	faster ✔ 15% - 19% 11.51ms - 14.85ms
tip-of-tree tip-of-tree	64.55ms - 66.76ms	unsure 🔍 -2% - +3% -1.46ms - +1.66ms	-	faster ✔ 15% - 19% 11.41ms - 14.75ms
previous-release previous-release	77.49ms - 79.99ms	slower ❌ 17% - 23% 11.51ms - 14.85ms	slower ❌ 17% - 23% 11.41ms - 14.75ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	139.34ms - 143.42ms	-	unsure 🔍 -3% - +1% -3.83ms - +2.11ms	faster ✔ 11% - 14% 17.40ms - 23.45ms
tip-of-tree tip-of-tree	140.07ms - 144.40ms	unsure 🔍 -2% - +3% -2.11ms - +3.83ms	-	faster ✔ 10% - 14% 16.46ms - 22.68ms
previous-release previous-release	159.57ms - 164.04ms	slower ❌ 12% - 17% 17.40ms - 23.45ms	slower ❌ 11% - 16% 16.46ms - 22.68ms	-

reactive-element-list

• Browser: chrome-headless 96.0.4664.45
• Sample size: 50
• Built by: Benchmarks #2117

• Commit: 39d8064

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.65ms - 72.53ms	-	unsure 🔍 -2% - +2% -1.57ms - +1.34ms	unsure 🔍 -2% - +2% -1.25ms - +1.74ms
tip-of-tree tip-of-tree	70.59ms - 72.82ms	unsure 🔍 -2% - +2% -1.34ms - +1.57ms	-	unsure 🔍 -2% - +3% -1.25ms - +1.97ms
previous-release previous-release	70.18ms - 72.51ms	unsure 🔍 -2% - +2% -1.74ms - +1.25ms	unsure 🔍 -3% - +2% -1.97ms - +1.25ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	914.69ms - 930.37ms	-	unsure 🔍 -2% - +1% -16.54ms - +8.58ms	unsure 🔍 -2% - +1% -15.81ms - +8.21ms
tip-of-tree tip-of-tree	916.70ms - 936.31ms	unsure 🔍 -1% - +2% -8.58ms - +16.54ms	-	unsure 🔍 -1% - +1% -13.20ms - +13.55ms
previous-release previous-release	917.24ms - 935.42ms	unsure 🔍 -1% - +2% -8.21ms - +15.81ms	unsure 🔍 -1% - +1% -13.55ms - +13.20ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1027.20ms - 1041.93ms	-	unsure 🔍 -2% - +1% -18.04ms - +5.30ms	unsure 🔍 -1% - +1% -13.02ms - +10.24ms
tip-of-tree tip-of-tree	1031.88ms - 1049.98ms	unsure 🔍 -1% - +2% -5.30ms - +18.04ms	-	unsure 🔍 -1% - +2% -7.79ms - +17.74ms
previous-release previous-release	1026.95ms - 1044.96ms	unsure 🔍 -1% - +1% -10.24ms - +13.02ms	unsure 🔍 -2% - +1% -17.74ms - +7.79ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[aomarks]

LGTM, just a couple small comments