Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choose directive jsdoc example code #2388

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

AndrewJakubowicz
Copy link
Contributor

Fix missing html tagged template literals in the choose example code.

Mirrors: lit/lit.dev#640.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2022

🦋 Changeset detected

Latest commit: 7daf4f8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -0% - +3% (-0.02ms - +0.67ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +1% (-0.59ms - +0.93ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -1% - +1% (-0.25ms - +0.39ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +1% (-0.37ms - +0.09ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -0% - +2% (-0.10ms - +1.23ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-0.92ms - +0.47ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +1% (-8.00ms - +7.80ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -4% - +1% (-3.10ms - +0.87ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +1% (-6.15ms - +2.25ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.84ms - +3.28ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-11.41ms - +5.11ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +1% (-9.63ms - +8.77ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +0% (-15.20ms - +1.80ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
76.03ms - 77.22ms-unsure 🔍
-1% - +1%
-0.59ms - +0.93ms
faster ✔
19% - 23%
18.17ms - 22.92ms
tip-of-tree
tip-of-tree
75.99ms - 76.92msunsure 🔍
-1% - +1%
-0.93ms - +0.59ms
-faster ✔
19% - 23%
18.37ms - 23.06ms
previous-release
previous-release
94.87ms - 99.47msslower ❌
24% - 30%
18.17ms - 22.92ms
slower ❌
24% - 30%
18.37ms - 23.06ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
785.63ms - 796.32ms-unsure 🔍
-1% - +1%
-8.00ms - +7.80ms
faster ✔
7% - 9%
60.57ms - 77.26ms
tip-of-tree
tip-of-tree
785.26ms - 796.90msunsure 🔍
-1% - +1%
-7.80ms - +8.00ms
-faster ✔
7% - 9%
60.16ms - 77.47ms
previous-release
previous-release
853.48ms - 866.30msslower ❌
8% - 10%
60.57ms - 77.26ms
slower ❌
8% - 10%
60.16ms - 77.47ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
879.42ms - 892.37ms-unsure 🔍
-1% - +1%
-9.63ms - +8.77ms
faster ✔
3% - 6%
31.31ms - 52.44ms
tip-of-tree
tip-of-tree
879.79ms - 892.86msunsure 🔍
-1% - +1%
-8.77ms - +9.63ms
-faster ✔
3% - 6%
30.84ms - 52.06ms
previous-release
previous-release
919.42ms - 936.13msslower ❌
4% - 6%
31.31ms - 52.44ms
slower ❌
3% - 6%
30.84ms - 52.06ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.28ms - 30.69ms-unsure 🔍
-1% - +1%
-0.25ms - +0.39ms
faster ✔
14% - 18%
4.87ms - 6.47ms
tip-of-tree
tip-of-tree
30.17ms - 30.66msunsure 🔍
-1% - +1%
-0.39ms - +0.25ms
-faster ✔
14% - 18%
4.92ms - 6.55ms
previous-release
previous-release
35.38ms - 36.92msslower ❌
16% - 21%
4.87ms - 6.47ms
slower ❌
16% - 22%
4.92ms - 6.55ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
81.28ms - 83.91ms-unsure 🔍
-4% - +1%
-3.10ms - +0.87ms
unsure 🔍
-6% - +0%
-5.19ms - +0.11ms
tip-of-tree
tip-of-tree
82.22ms - 85.20msunsure 🔍
-1% - +4%
-0.87ms - +3.10ms
-unsure 🔍
-5% - +2%
-4.17ms - +1.31ms
previous-release
previous-release
82.84ms - 87.44msunsure 🔍
-0% - +6%
-0.11ms - +5.19ms
unsure 🔍
-2% - +5%
-1.31ms - +4.17ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
24.98ms - 25.59ms-unsure 🔍
-0% - +3%
-0.02ms - +0.67ms
faster ✔
13% - 17%
3.89ms - 5.06ms
tip-of-tree
tip-of-tree
24.80ms - 25.12msunsure 🔍
-3% - +0%
-0.67ms - +0.02ms
-faster ✔
15% - 18%
4.28ms - 5.32ms
previous-release
previous-release
29.26ms - 30.26msslower ❌
15% - 20%
3.89ms - 5.06ms
slower ❌
17% - 21%
4.28ms - 5.32ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
11.35ms - 11.68ms-unsure 🔍
-3% - +1%
-0.37ms - +0.09ms
faster ✔
7% - 9%
0.81ms - 1.16ms
tip-of-tree
tip-of-tree
11.50ms - 11.81msunsure 🔍
-1% - +3%
-0.09ms - +0.37ms
-faster ✔
5% - 8%
0.68ms - 1.01ms
previous-release
previous-release
12.45ms - 12.56msslower ❌
7% - 10%
0.81ms - 1.16ms
slower ❌
6% - 9%
0.68ms - 1.01ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
308.74ms - 315.25ms-unsure 🔍
-2% - +1%
-6.15ms - +2.25ms
faster ✔
30% - 32%
136.36ms - 145.67ms
tip-of-tree
tip-of-tree
311.29ms - 316.60msunsure 🔍
-1% - +2%
-2.25ms - +6.15ms
-faster ✔
30% - 31%
134.81ms - 143.32ms
previous-release
previous-release
449.68ms - 456.34msslower ❌
43% - 47%
136.36ms - 145.67ms
slower ❌
43% - 46%
134.81ms - 143.32ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.24ms - 56.23ms-unsure 🔍
-0% - +2%
-0.10ms - +1.23ms
faster ✔
16% - 18%
10.37ms - 12.50ms
tip-of-tree
tip-of-tree
54.72ms - 55.62msunsure 🔍
-2% - +0%
-1.23ms - +0.10ms
-faster ✔
17% - 19%
10.95ms - 13.04ms
previous-release
previous-release
66.23ms - 68.11msslower ❌
19% - 23%
10.37ms - 12.50ms
slower ❌
20% - 24%
10.95ms - 13.04ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
125.00ms - 127.86ms-unsure 🔍
-1% - +3%
-0.84ms - +3.28ms
faster ✔
13% - 16%
18.66ms - 23.19ms
tip-of-tree
tip-of-tree
123.73ms - 126.69msunsure 🔍
-3% - +1%
-3.28ms - +0.84ms
-faster ✔
14% - 16%
19.85ms - 24.44ms
previous-release
previous-release
145.60ms - 149.11msslower ❌
15% - 18%
18.66ms - 23.19ms
slower ❌
16% - 20%
19.85ms - 24.44ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
57.01ms - 58.05ms-unsure 🔍
-2% - +1%
-0.92ms - +0.47ms
unsure 🔍
-1% - +2%
-0.67ms - +0.93ms
tip-of-tree
tip-of-tree
57.29ms - 58.22msunsure 🔍
-1% - +2%
-0.47ms - +0.92ms
-unsure 🔍
-1% - +2%
-0.41ms - +1.13ms
previous-release
previous-release
56.79ms - 58.01msunsure 🔍
-2% - +1%
-0.93ms - +0.67ms
unsure 🔍
-2% - +1%
-1.13ms - +0.41ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
816.88ms - 828.12ms-unsure 🔍
-1% - +1%
-11.41ms - +5.11ms
unsure 🔍
-1% - +1%
-11.82ms - +5.57ms
tip-of-tree
tip-of-tree
819.60ms - 831.70msunsure 🔍
-1% - +1%
-5.11ms - +11.41ms
-unsure 🔍
-1% - +1%
-8.95ms - +8.99ms
previous-release
previous-release
819.00ms - 832.25msunsure 🔍
-1% - +1%
-5.57ms - +11.82ms
unsure 🔍
-1% - +1%
-8.99ms - +8.95ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
932.43ms - 943.03ms-unsure 🔍
-2% - +0%
-15.20ms - +1.80ms
unsure 🔍
-1% - +1%
-8.79ms - +7.00ms
tip-of-tree
tip-of-tree
937.78ms - 951.08msunsure 🔍
-0% - +2%
-1.80ms - +15.20ms
-unsure 🔍
-0% - +2%
-3.06ms - +14.65ms
previous-release
previous-release
932.78ms - 944.48msunsure 🔍
-1% - +1%
-7.00ms - +8.79ms
unsure 🔍
-2% - +0%
-14.65ms - +3.06ms
-

tachometer-reporter-action v2 for Benchmarks

@AndrewJakubowicz AndrewJakubowicz merged commit 5860533 into main Jan 6, 2022
@AndrewJakubowicz AndrewJakubowicz deleted the fix-choose-docs branch January 6, 2022 17:36
@github-actions github-actions bot mentioned this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants