Fix bug with bindings inside of <title> elements

[justinfagnani]

Fixes #2441

I didn't add an SSR-specific test because it's evident that the problem is with <title> elements in general and the test for <title> was broken before the fix was applied.

[changeset-bot]

🦋 Changeset detected

Latest commit: cd2fa8a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-0.39ms - +0.67ms)
  ^{this-change vs tip-of-tree}

render

• lit-element-list: slower ❌ 0% - 2% (0.01ms - 1.45ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -1% - +0% (-0.35ms - +0.11ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -3% - +2% (-0.31ms - +0.17ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.59ms - +0.56ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +2% (-1.36ms - +1.00ms)
  ^{this-change vs tip-of-tree}

update

• lit-element-list: unsure 🔍 -0% - +2% (-2.76ms - +14.14ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -4% - +2% (-3.63ms - +1.97ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -1% - +1% (-3.85ms - +1.94ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.50ms - +2.43ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +1% (-10.96ms - +4.19ms)
  ^{this-change vs tip-of-tree}

update-reflect

• lit-element-list: unsure 🔍 -0% - +2% (-0.28ms - +15.47ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -1% - +1% (-9.42ms - +6.84ms)
  ^{this-change vs tip-of-tree}

Results

lit-element-list

• Browser: chrome-headless 97.0.4692.71
• Sample size: 50
• Built by: Benchmarks #2281

• Commit: 572df41

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	73.46ms - 74.56ms	-	slower ❌ 0% - 2% 0.01ms - 1.45ms	faster ✔ 19% - 21% 17.85ms - 19.38ms
tip-of-tree tip-of-tree	72.81ms - 73.75ms	faster ✔ 0% - 2% 0.01ms - 1.45ms	-	faster ✔ 20% - 22% 18.63ms - 20.06ms
previous-release previous-release	92.09ms - 93.16ms	slower ❌ 24% - 26% 17.85ms - 19.38ms	slower ❌ 25% - 27% 18.63ms - 20.06ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	709.18ms - 722.09ms	-	unsure 🔍 -0% - +2% -2.76ms - +14.14ms	faster ✔ 6% - 8% 47.60ms - 64.16ms
tip-of-tree tip-of-tree	704.50ms - 715.40ms	unsure 🔍 -2% - +0% -14.14ms - +2.76ms	-	faster ✔ 7% - 9% 54.05ms - 69.09ms
previous-release previous-release	766.34ms - 776.70ms	slower ❌ 7% - 9% 47.60ms - 64.16ms	slower ❌ 8% - 10% 54.05ms - 69.09ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	804.46ms - 817.88ms	-	unsure 🔍 -0% - +2% -0.28ms - +15.47ms	faster ✔ 3% - 5% 27.35ms - 46.17ms
tip-of-tree tip-of-tree	799.45ms - 807.69ms	unsure 🔍 -2% - +0% -15.47ms - +0.28ms	-	faster ✔ 4% - 6% 36.57ms - 52.13ms
previous-release previous-release	841.33ms - 854.52ms	slower ❌ 3% - 6% 27.35ms - 46.17ms	slower ❌ 5% - 7% 36.57ms - 52.13ms	-

lit-html-kitchen-sink

• Browser: chrome-headless 97.0.4692.71
• Sample size: 30
• Built by: Benchmarks #2281

• Commit: 572df41

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.74ms - 30.09ms	-	unsure 🔍 -1% - +0% -0.35ms - +0.11ms	faster ✔ 14% - 19% 4.91ms - 6.96ms
tip-of-tree tip-of-tree	29.89ms - 30.19ms	unsure 🔍 -0% - +1% -0.11ms - +0.35ms	-	faster ✔ 14% - 19% 4.79ms - 6.83ms
previous-release previous-release	34.84ms - 36.86ms	slower ❌ 16% - 23% 4.91ms - 6.96ms	slower ❌ 16% - 23% 4.79ms - 6.83ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	79.18ms - 82.92ms	-	unsure 🔍 -4% - +2% -3.63ms - +1.97ms	faster ✔ 1% - 8% 0.69ms - 6.43ms
tip-of-tree tip-of-tree	79.80ms - 83.96ms	unsure 🔍 -2% - +4% -1.97ms - +3.63ms	-	unsure 🔍 -7% - +0% -5.74ms - +0.27ms
previous-release previous-release	82.44ms - 86.78ms	slower ❌ 1% - 8% 0.69ms - 6.43ms	unsure 🔍 -0% - +7% -0.27ms - +5.74ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	25.24ms - 26.17ms	-	unsure 🔍 -2% - +3% -0.39ms - +0.67ms	faster ✔ 10% - 15% 3.01ms - 4.44ms
tip-of-tree tip-of-tree	25.32ms - 25.82ms	unsure 🔍 -3% - +1% -0.67ms - +0.39ms	-	faster ✔ 11% - 15% 3.26ms - 4.46ms
previous-release previous-release	28.88ms - 29.98ms	slower ❌ 12% - 17% 3.01ms - 4.44ms	slower ❌ 13% - 18% 3.26ms - 4.46ms	-

lit-html-repeat

• Browser: chrome-headless 97.0.4692.71
• Sample size: 30
• Built by: Benchmarks #2281

• Commit: 572df41

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.91ms - 11.25ms	-	unsure 🔍 -3% - +2% -0.31ms - +0.17ms	faster ✔ 11% - 13% 1.33ms - 1.70ms
tip-of-tree tip-of-tree	10.98ms - 11.32ms	unsure 🔍 -2% - +3% -0.17ms - +0.31ms	-	faster ✔ 10% - 13% 1.26ms - 1.63ms
previous-release previous-release	12.54ms - 12.66ms	slower ❌ 12% - 16% 1.33ms - 1.70ms	slower ❌ 11% - 15% 1.26ms - 1.63ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	298.70ms - 301.63ms	-	unsure 🔍 -1% - +1% -3.85ms - +1.94ms	faster ✔ 30% - 32% 130.60ms - 138.14ms
tip-of-tree tip-of-tree	298.63ms - 303.62ms	unsure 🔍 -1% - +1% -1.94ms - +3.85ms	-	faster ✔ 30% - 32% 129.14ms - 137.69ms
previous-release previous-release	431.06ms - 438.01ms	slower ❌ 43% - 46% 130.60ms - 138.14ms	slower ❌ 43% - 46% 129.14ms - 137.69ms	-

lit-html-template-heavy

• Browser: chrome-headless 97.0.4692.71
• Sample size: 50
• Built by: Benchmarks #2281

• Commit: 572df41

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	53.34ms - 54.19ms	-	unsure 🔍 -1% - +1% -0.59ms - +0.56ms	faster ✔ 16% - 18% 9.99ms - 11.77ms
tip-of-tree tip-of-tree	53.39ms - 54.16ms	unsure 🔍 -1% - +1% -0.56ms - +0.59ms	-	faster ✔ 16% - 18% 10.00ms - 11.74ms
previous-release previous-release	63.87ms - 65.43ms	slower ❌ 19% - 22% 9.99ms - 11.77ms	slower ❌ 19% - 22% 10.00ms - 11.74ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	112.84ms - 116.30ms	-	unsure 🔍 -1% - +2% -1.50ms - +2.43ms	faster ✔ 11% - 14% 14.49ms - 18.75ms
tip-of-tree tip-of-tree	113.17ms - 115.03ms	unsure 🔍 -2% - +1% -2.43ms - +1.50ms	-	faster ✔ 12% - 14% 15.53ms - 18.64ms
previous-release previous-release	129.94ms - 132.44ms	slower ❌ 12% - 17% 14.49ms - 18.75ms	slower ❌ 14% - 16% 15.53ms - 18.64ms	-

reactive-element-list

• Browser: chrome-headless 97.0.4692.71
• Sample size: 50
• Built by: Benchmarks #2281

• Commit: 572df41

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	53.02ms - 55.08ms	-	unsure 🔍 -2% - +2% -1.36ms - +1.00ms	unsure 🔍 -3% - +1% -1.60ms - +0.73ms
tip-of-tree tip-of-tree	53.67ms - 54.79ms	unsure 🔍 -2% - +3% -1.00ms - +1.36ms	-	unsure 🔍 -2% - +1% -1.03ms - +0.52ms
previous-release previous-release	53.94ms - 55.02ms	unsure 🔍 -1% - +3% -0.73ms - +1.60ms	unsure 🔍 -1% - +2% -0.52ms - +1.03ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	720.87ms - 729.97ms	-	unsure 🔍 -2% - +1% -10.96ms - +4.19ms	unsure 🔍 -1% - +1% -6.42ms - +6.96ms
tip-of-tree tip-of-tree	722.75ms - 734.86ms	unsure 🔍 -1% - +2% -4.19ms - +10.96ms	-	unsure 🔍 -1% - +2% -4.14ms - +11.45ms
previous-release previous-release	720.25ms - 730.06ms	unsure 🔍 -1% - +1% -6.96ms - +6.42ms	unsure 🔍 -2% - +1% -11.45ms - +4.14ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	829.93ms - 840.55ms	-	unsure 🔍 -1% - +1% -9.42ms - +6.84ms	unsure 🔍 -0% - +1% -3.63ms - +10.43ms
tip-of-tree tip-of-tree	830.37ms - 842.69ms	unsure 🔍 -1% - +1% -6.84ms - +9.42ms	-	unsure 🔍 -0% - +1% -3.00ms - +12.39ms
previous-release previous-release	827.22ms - 836.45ms	unsure 🔍 -1% - +0% -10.43ms - +3.63ms	unsure 🔍 -1% - +0% -12.39ms - +3.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[BalusC]

Just wondering when this will be released? I can't find a release plan within the scope of this project.

[aomarks]

Just wondering when this will be released? I can't find a release plan within the scope of this project.

We will do a release in the next day or two. We don't have a regularly scheduled release process yet, and do releases on-demand, but may move to a weekly schedule at some point.