[reactive-element] Fix type signature in queryAssignedNodes JSDoc code example.

[AndrewJakubowicz]

Fixes issue: lit/lit.dev#670

Documentation only change.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9229245

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• lit-html-kitchen-sink: unsure 🔍 -2% - +1% (-0.47ms - +0.32ms)
  ^{this-change vs tip-of-tree}

render

• lit-element-list: unsure 🔍 -0% - +2% (-0.13ms - +1.27ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -1% - +1% (-0.20ms - +0.16ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -2% - +3% (-0.27ms - +0.33ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -2% - +1% (-1.15ms - +0.76ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -2% - +1% (-0.94ms - +0.44ms)
  ^{this-change vs tip-of-tree}

update

• lit-element-list: unsure 🔍 -1% - +0% (-7.35ms - +3.31ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -3% - +3% (-2.29ms - +2.17ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -1% - +1% (-2.63ms - +3.01ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.00ms - +2.75ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -1% - +1% (-8.02ms - +5.73ms)
  ^{this-change vs tip-of-tree}

update-reflect

• lit-element-list: unsure 🔍 -0% - +1% (-2.79ms - +7.89ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -1% - +0% (-10.54ms - +3.77ms)
  ^{this-change vs tip-of-tree}

Results

lit-element-list

• Browser: chrome-headless 97.0.4692.99
• Sample size: 50
• Built by: Benchmarks #2288

• Commit: 899d025

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	103.20ms - 106.11ms	-	unsure 🔍 -1% - +2% -1.42ms - +2.04ms	faster ✔ 19% - 23% 25.42ms - 30.77ms
tip-of-tree tip-of-tree	103.40ms - 105.29ms	unsure 🔍 -2% - +1% -2.04ms - +1.42ms	-	faster ✔ 20% - 23% 25.97ms - 30.84ms
previous-release previous-release	130.50ms - 135.00ms	slower ❌ 24% - 30% 25.42ms - 30.77ms	slower ❌ 25% - 30% 25.97ms - 30.84ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	977.40ms - 997.73ms	-	unsure 🔍 -2% - +1% -19.46ms - +10.22ms	faster ✔ 6% - 8% 60.76ms - 89.35ms
tip-of-tree tip-of-tree	981.37ms - 1003.00ms	unsure 🔍 -1% - +2% -10.22ms - +19.46ms	-	faster ✔ 5% - 8% 55.67ms - 85.21ms
previous-release previous-release	1052.56ms - 1072.68ms	slower ❌ 6% - 9% 60.76ms - 89.35ms	slower ❌ 6% - 9% 55.67ms - 85.21ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1066.00ms - 1084.05ms	-	unsure 🔍 -1% - +1% -9.32ms - +14.76ms	faster ✔ 4% - 7% 43.09ms - 76.44ms
tip-of-tree tip-of-tree	1064.34ms - 1080.26ms	unsure 🔍 -1% - +1% -14.76ms - +9.32ms	-	faster ✔ 4% - 7% 46.36ms - 78.61ms
previous-release previous-release	1120.77ms - 1148.80ms	slower ❌ 4% - 7% 43.09ms - 76.44ms	slower ❌ 4% - 7% 46.36ms - 78.61ms	-

lit-html-kitchen-sink

• Browser: chrome-headless 97.0.4692.99
• Sample size: 30
• Built by: Benchmarks #2289

• Commit: bd414ca

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.70ms - 29.97ms	-	unsure 🔍 -1% - +1% -0.20ms - +0.16ms	faster ✔ 16% - 19% 5.48ms - 6.85ms
tip-of-tree tip-of-tree	29.73ms - 29.98ms	unsure 🔍 -1% - +1% -0.16ms - +0.20ms	-	faster ✔ 15% - 19% 5.46ms - 6.83ms
previous-release previous-release	35.33ms - 36.67ms	slower ❌ 18% - 23% 5.48ms - 6.85ms	slower ❌ 18% - 23% 5.46ms - 6.83ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	81.38ms - 84.58ms	-	unsure 🔍 -3% - +3% -2.29ms - +2.17ms	faster ✔ 0% - 7% 0.19ms - 5.68ms
tip-of-tree tip-of-tree	81.48ms - 84.59ms	unsure 🔍 -3% - +3% -2.17ms - +2.29ms	-	faster ✔ 0% - 6% 0.16ms - 5.59ms
previous-release previous-release	83.68ms - 88.14ms	slower ❌ 0% - 7% 0.19ms - 5.68ms	slower ❌ 0% - 7% 0.16ms - 5.59ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	25.99ms - 26.45ms	-	unsure 🔍 -2% - +1% -0.47ms - +0.32ms	faster ✔ 12% - 14% 3.53ms - 4.41ms
tip-of-tree tip-of-tree	25.97ms - 26.61ms	unsure 🔍 -1% - +2% -0.32ms - +0.47ms	-	faster ✔ 11% - 14% 3.40ms - 4.39ms
previous-release previous-release	29.81ms - 30.57ms	slower ❌ 13% - 17% 3.53ms - 4.41ms	slower ❌ 13% - 17% 3.40ms - 4.39ms	-

lit-html-repeat

• Browser: chrome-headless 97.0.4692.99
• Sample size: 30
• Built by: Benchmarks #2289

• Commit: bd414ca

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.10ms - 11.50ms	-	unsure 🔍 -2% - +3% -0.27ms - +0.33ms	faster ✔ 9% - 12% 1.11ms - 1.53ms
tip-of-tree tip-of-tree	11.05ms - 11.49ms	unsure 🔍 -3% - +2% -0.33ms - +0.27ms	-	faster ✔ 9% - 12% 1.12ms - 1.58ms
previous-release previous-release	12.56ms - 12.68ms	slower ❌ 10% - 14% 1.11ms - 1.53ms	slower ❌ 10% - 14% 1.12ms - 1.58ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	302.74ms - 306.97ms	-	unsure 🔍 -1% - +1% -2.63ms - +3.01ms	faster ✔ 30% - 31% 131.47ms - 139.54ms
tip-of-tree tip-of-tree	302.81ms - 306.52ms	unsure 🔍 -1% - +1% -3.01ms - +2.63ms	-	faster ✔ 30% - 31% 131.79ms - 139.60ms
previous-release previous-release	436.92ms - 443.79ms	slower ❌ 43% - 46% 131.47ms - 139.54ms	slower ❌ 43% - 46% 131.79ms - 139.60ms	-

lit-html-template-heavy

• Browser: chrome-headless 97.0.4692.99
• Sample size: 50
• Built by: Benchmarks #2289

• Commit: bd414ca

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.44ms - 55.30ms	-	unsure 🔍 -2% - +1% -1.15ms - +0.76ms	faster ✔ 16% - 19% 10.84ms - 12.62ms
tip-of-tree tip-of-tree	54.22ms - 55.92ms	unsure 🔍 -1% - +2% -0.76ms - +1.15ms	-	faster ✔ 16% - 19% 10.38ms - 12.69ms
previous-release previous-release	65.82ms - 67.38ms	slower ❌ 20% - 23% 10.84ms - 12.62ms	slower ❌ 19% - 23% 10.38ms - 12.69ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	120.56ms - 122.79ms	-	unsure 🔍 -1% - +2% -1.00ms - +2.75ms	faster ✔ 12% - 15% 17.25ms - 20.99ms
tip-of-tree tip-of-tree	119.29ms - 122.31ms	unsure 🔍 -2% - +1% -2.75ms - +1.00ms	-	faster ✔ 13% - 16% 17.86ms - 22.12ms
previous-release previous-release	139.28ms - 142.29ms	slower ❌ 14% - 17% 17.25ms - 20.99ms	slower ❌ 15% - 18% 17.86ms - 22.12ms	-

reactive-element-list

• Browser: chrome-headless 97.0.4692.99
• Sample size: 50
• Built by: Benchmarks #2288

• Commit: 899d025

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	73.56ms - 74.82ms	-	unsure 🔍 -3% - +0% -2.31ms - +0.33ms	faster ✔ 0% - 3% 0.09ms - 2.13ms
tip-of-tree tip-of-tree	74.02ms - 76.33ms	unsure 🔍 -0% - +3% -0.33ms - +2.31ms	-	unsure 🔍 -2% - +2% -1.53ms - +1.29ms
previous-release previous-release	74.49ms - 76.10ms	slower ❌ 0% - 3% 0.09ms - 2.13ms	unsure 🔍 -2% - +2% -1.29ms - +1.53ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1039.78ms - 1059.42ms	-	unsure 🔍 -1% - +1% -12.25ms - +14.64ms	unsure 🔍 -1% - +1% -13.27ms - +12.92ms
tip-of-tree tip-of-tree	1039.22ms - 1057.58ms	unsure 🔍 -1% - +1% -14.64ms - +12.25ms	-	unsure 🔍 -1% - +1% -14.00ms - +11.25ms
previous-release previous-release	1041.11ms - 1058.44ms	unsure 🔍 -1% - +1% -12.92ms - +13.27ms	unsure 🔍 -1% - +1% -11.25ms - +14.00ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1136.62ms - 1159.22ms	-	unsure 🔍 -1% - +1% -16.52ms - +11.79ms	unsure 🔍 -1% - +2% -6.82ms - +21.07ms
tip-of-tree tip-of-tree	1141.76ms - 1158.81ms	unsure 🔍 -1% - +1% -11.79ms - +16.52ms	-	unsure 🔍 -0% - +2% -2.32ms - +21.30ms
previous-release previous-release	1132.63ms - 1148.97ms	unsure 🔍 -2% - +1% -21.07ms - +6.82ms	unsure 🔍 -2% - +0% -21.30ms - +2.32ms	-

_{tachometer-reporter-action v2 for Benchmarks}