Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[starter-kits] Add a link to the starter templates so users will know where they should file issues. #2535

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

bicknellr
Copy link
Member

@bicknellr bicknellr commented Feb 14, 2022

I'm going to transfer all of the issues in the starter kit repos to this one and then disable issues. These links should help people find the original repo so they know where to file issues if they need to.

Part of #2536.

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2022

🦋 Changeset detected

Latest commit: 81d8cb9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -1% - +2% (-0.33ms - +0.55ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +1% (-0.90ms - +0.57ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -3% - +1% (-0.79ms - +0.36ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +2% (-0.43ms - +0.25ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.36ms - +0.72ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +2% (-0.41ms - +1.09ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +1% (-7.31ms - +9.54ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -1% - +3% (-1.09ms - +2.49ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +5% (-10.63ms - +14.77ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.20ms - +1.26ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-12.12ms - +6.61ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +1% (-7.62ms - +9.98ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-14.13ms - +5.27ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
74.28ms - 75.28ms-unsure 🔍
-1% - +1%
-0.90ms - +0.57ms
faster ✔
19% - 21%
18.10ms - 19.75ms
tip-of-tree
tip-of-tree
74.41ms - 75.48msunsure 🔍
-1% - +1%
-0.57ms - +0.90ms
-faster ✔
19% - 21%
17.91ms - 19.61ms
previous-release
previous-release
93.05ms - 94.36msslower ❌
24% - 27%
18.10ms - 19.75ms
slower ❌
24% - 26%
17.91ms - 19.61ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
741.44ms - 753.84ms-unsure 🔍
-1% - +1%
-7.31ms - +9.54ms
faster ✔
7% - 10%
59.93ms - 78.62ms
tip-of-tree
tip-of-tree
740.83ms - 752.23msunsure 🔍
-1% - +1%
-9.54ms - +7.31ms
-faster ✔
8% - 10%
61.36ms - 79.41ms
previous-release
previous-release
809.92ms - 823.91msslower ❌
8% - 11%
59.93ms - 78.62ms
slower ❌
8% - 11%
61.36ms - 79.41ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
832.22ms - 844.58ms-unsure 🔍
-1% - +1%
-7.62ms - +9.98ms
faster ✔
4% - 6%
31.64ms - 51.27ms
tip-of-tree
tip-of-tree
830.95ms - 843.48msunsure 🔍
-1% - +1%
-9.98ms - +7.62ms
-faster ✔
4% - 6%
32.77ms - 52.51ms
previous-release
previous-release
872.23ms - 887.49msslower ❌
4% - 6%
31.64ms - 51.27ms
slower ❌
4% - 6%
32.77ms - 52.51ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
29.83ms - 30.57ms-unsure 🔍
-3% - +1%
-0.79ms - +0.36ms
faster ✔
14% - 18%
4.89ms - 6.75ms
tip-of-tree
tip-of-tree
29.97ms - 30.86msunsure 🔍
-1% - +3%
-0.36ms - +0.79ms
-faster ✔
13% - 18%
4.64ms - 6.56ms
previous-release
previous-release
35.17ms - 36.87msslower ❌
16% - 22%
4.89ms - 6.75ms
slower ❌
15% - 22%
4.64ms - 6.56ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
81.03ms - 83.80ms-unsure 🔍
-1% - +3%
-1.09ms - +2.49ms
faster ✔
0% - 7%
0.09ms - 5.70ms
tip-of-tree
tip-of-tree
80.59ms - 82.85msunsure 🔍
-3% - +1%
-2.49ms - +1.09ms
-faster ✔
1% - 7%
0.91ms - 6.28ms
previous-release
previous-release
82.88ms - 87.75msslower ❌
0% - 7%
0.09ms - 5.70ms
slower ❌
1% - 8%
0.91ms - 6.28ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
26.96ms - 27.68ms-unsure 🔍
-1% - +2%
-0.33ms - +0.55ms
faster ✔
8% - 11%
2.54ms - 3.37ms
tip-of-tree
tip-of-tree
26.95ms - 27.47msunsure 🔍
-2% - +1%
-0.55ms - +0.33ms
-faster ✔
9% - 11%
2.72ms - 3.40ms
previous-release
previous-release
30.06ms - 30.49msslower ❌
9% - 12%
2.54ms - 3.37ms
slower ❌
10% - 13%
2.72ms - 3.40ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
11.09ms - 11.57ms-unsure 🔍
-4% - +2%
-0.43ms - +0.25ms
faster ✔
6% - 20%
0.60ms - 2.65ms
tip-of-tree
tip-of-tree
11.18ms - 11.66msunsure 🔍
-2% - +4%
-0.25ms - +0.43ms
-faster ✔
5% - 19%
0.51ms - 2.56ms
previous-release
previous-release
11.96ms - 13.96msslower ❌
5% - 23%
0.60ms - 2.65ms
slower ❌
4% - 22%
0.51ms - 2.56ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
302.42ms - 322.61ms-unsure 🔍
-3% - +5%
-10.63ms - +14.77ms
faster ✔
28% - 34%
124.77ms - 157.18ms
tip-of-tree
tip-of-tree
302.73ms - 318.15msunsure 🔍
-5% - +3%
-14.77ms - +10.63ms
-faster ✔
29% - 34%
128.22ms - 157.88ms
previous-release
previous-release
440.81ms - 466.17msslower ❌
39% - 51%
124.77ms - 157.18ms
slower ❌
41% - 52%
128.22ms - 157.88ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
53.15ms - 54.07ms-unsure 🔍
-1% - +1%
-0.36ms - +0.72ms
faster ✔
17% - 19%
10.71ms - 12.70ms
tip-of-tree
tip-of-tree
53.15ms - 53.72msunsure 🔍
-1% - +1%
-0.72ms - +0.36ms
-faster ✔
17% - 19%
10.95ms - 12.81ms
previous-release
previous-release
64.43ms - 66.20msslower ❌
20% - 24%
10.71ms - 12.70ms
slower ❌
20% - 24%
10.95ms - 12.81ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
114.24ms - 115.90ms-unsure 🔍
-1% - +1%
-1.20ms - +1.26ms
faster ✔
13% - 15%
16.94ms - 20.24ms
tip-of-tree
tip-of-tree
114.12ms - 115.95msunsure 🔍
-1% - +1%
-1.26ms - +1.20ms
-faster ✔
13% - 15%
16.93ms - 20.31ms
previous-release
previous-release
132.23ms - 135.08msslower ❌
15% - 18%
16.94ms - 20.24ms
slower ❌
15% - 18%
16.93ms - 20.31ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.33ms - 56.40ms-unsure 🔍
-1% - +2%
-0.41ms - +1.09ms
slower ❌
0% - 3%
0.19ms - 1.65ms
tip-of-tree
tip-of-tree
55.00ms - 56.05msunsure 🔍
-2% - +1%
-1.09ms - +0.41ms
-unsure 🔍
-0% - +2%
-0.15ms - +1.30ms
previous-release
previous-release
54.44ms - 55.45msfaster ✔
0% - 3%
0.19ms - 1.65ms
unsure 🔍
-2% - +0%
-1.30ms - +0.15ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
742.43ms - 756.30ms-unsure 🔍
-2% - +1%
-12.12ms - +6.61ms
unsure 🔍
-2% - +1%
-12.49ms - +7.06ms
tip-of-tree
tip-of-tree
745.82ms - 758.41msunsure 🔍
-1% - +2%
-6.61ms - +12.12ms
-unsure 🔍
-1% - +1%
-9.29ms - +9.36ms
previous-release
previous-release
745.20ms - 758.97msunsure 🔍
-1% - +2%
-7.06ms - +12.49ms
unsure 🔍
-1% - +1%
-9.36ms - +9.29ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
852.64ms - 865.16ms-unsure 🔍
-2% - +1%
-14.13ms - +5.27ms
unsure 🔍
-1% - +1%
-10.40ms - +9.14ms
tip-of-tree
tip-of-tree
855.91ms - 870.74msunsure 🔍
-1% - +2%
-5.27ms - +14.13ms
-unsure 🔍
-1% - +2%
-6.76ms - +14.34ms
previous-release
previous-release
852.03ms - 867.03msunsure 🔍
-1% - +1%
-9.14ms - +10.40ms
unsure 🔍
-2% - +1%
-14.34ms - +6.76ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bicknellr bicknellr merged commit d135985 into main Feb 14, 2022
@bicknellr bicknellr deleted the starter-main-repo-links branch February 14, 2022 23:02
@bicknellr
Copy link
Member Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants