Enforce use of file extensions in imports

[justinfagnani]

Fixes #2644 and adds an eslint plugin to enforce extensions going forward.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9956573

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-0.46ms - +0.89ms)
  ^{this-change vs tip-of-tree}

render

• lit-element-list: unsure 🔍 -1% - +1% (-1.04ms - +1.03ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -1% - +2% (-0.31ms - +0.85ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -3% - +2% (-0.38ms - +0.26ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.65ms - +1.18ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -17% - +11% (-14.69ms - +10.07ms)
  ^{this-change vs tip-of-tree}

update

• lit-element-list: unsure 🔍 -1% - +5% (-9.14ms - +40.80ms)
  ^{this-change vs tip-of-tree}
• lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-2.12ms - +2.97ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -10% - +4% (-40.12ms - +15.71ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.94ms - +2.92ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -13% - +13% (-157.63ms - +155.16ms)
  ^{this-change vs tip-of-tree}

update-reflect

• lit-element-list: unsure 🔍 -1% - +1% (-4.97ms - +6.46ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -1% - +2% (-11.01ms - +18.39ms)
  ^{this-change vs tip-of-tree}

Results

lit-element-list

• Browser: chrome-headless 100.0.4896.75
• Sample size: 50
• Built by: Benchmarks #2730

• Commit: 7055443

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	85.65ms - 87.12ms	-	unsure 🔍 -1% - +1% -1.04ms - +1.03ms	faster ✔ 17% - 20% 18.14ms - 20.92ms
tip-of-tree tip-of-tree	85.66ms - 87.12ms	unsure 🔍 -1% - +1% -1.03ms - +1.04ms	-	faster ✔ 17% - 20% 18.14ms - 20.92ms
previous-release previous-release	104.73ms - 107.10ms	slower ❌ 21% - 24% 18.14ms - 20.92ms	slower ❌ 21% - 24% 18.14ms - 20.92ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	866.21ms - 915.38ms	-	unsure 🔍 -1% - +5% -9.14ms - +40.80ms	faster ✔ 35% - 38% 487.21ms - 542.63ms
tip-of-tree tip-of-tree	870.58ms - 879.35ms	unsure 🔍 -5% - +1% -40.80ms - +9.14ms	-	faster ✔ 37% - 38% 517.24ms - 544.27ms
previous-release previous-release	1392.93ms - 1418.50ms	slower ❌ 53% - 62% 487.21ms - 542.63ms	slower ❌ 59% - 62% 517.24ms - 544.27ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	847.87ms - 857.12ms	-	unsure 🔍 -1% - +1% -4.97ms - +6.46ms	faster ✔ 8% - 9% 71.53ms - 88.05ms
tip-of-tree tip-of-tree	848.39ms - 855.10ms	unsure 🔍 -1% - +1% -6.46ms - +4.97ms	-	faster ✔ 8% - 9% 72.91ms - 88.16ms
previous-release previous-release	925.43ms - 939.13ms	slower ❌ 8% - 10% 71.53ms - 88.05ms	slower ❌ 9% - 10% 72.91ms - 88.16ms	-

lit-html-kitchen-sink

• Browser: chrome-headless 100.0.4896.75
• Sample size: 30
• Built by: Benchmarks #2730

• Commit: 7055443

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.51ms - 35.08ms	-	unsure 🔍 -1% - +2% -0.31ms - +0.85ms	faster ✔ 13% - 17% 5.16ms - 7.22ms
tip-of-tree tip-of-tree	34.03ms - 35.03ms	unsure 🔍 -2% - +1% -0.85ms - +0.31ms	-	faster ✔ 13% - 18% 5.35ms - 7.57ms
previous-release previous-release	40.00ms - 41.97ms	slower ❌ 15% - 21% 5.16ms - 7.22ms	slower ❌ 15% - 22% 5.35ms - 7.57ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	92.66ms - 96.37ms	-	unsure 🔍 -2% - +3% -2.12ms - +2.97ms	unsure 🔍 -4% - +3% -4.10ms - +3.15ms
tip-of-tree tip-of-tree	92.35ms - 95.83ms	unsure 🔍 -3% - +2% -2.97ms - +2.12ms	-	unsure 🔍 -5% - +3% -4.47ms - +2.66ms
previous-release previous-release	91.88ms - 98.11ms	unsure 🔍 -3% - +4% -3.15ms - +4.10ms	unsure 🔍 -3% - +5% -2.66ms - +4.47ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	30.10ms - 31.02ms	-	unsure 🔍 -2% - +3% -0.46ms - +0.89ms	faster ✔ 8% - 12% 2.78ms - 4.10ms
tip-of-tree tip-of-tree	29.85ms - 30.84ms	unsure 🔍 -3% - +1% -0.89ms - +0.46ms	-	faster ✔ 9% - 13% 2.97ms - 4.34ms
previous-release previous-release	33.53ms - 34.47ms	slower ❌ 9% - 14% 2.78ms - 4.10ms	slower ❌ 10% - 14% 2.97ms - 4.34ms	-

lit-html-repeat

• Browser: chrome-headless 100.0.4896.75
• Sample size: 30
• Built by: Benchmarks #2730

• Commit: 7055443

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	12.17ms - 12.59ms	-	unsure 🔍 -3% - +2% -0.38ms - +0.26ms	faster ✔ 9% - 13% 1.32ms - 1.82ms
tip-of-tree tip-of-tree	12.20ms - 12.68ms	unsure 🔍 -2% - +3% -0.26ms - +0.38ms	-	faster ✔ 9% - 13% 1.23ms - 1.80ms
previous-release previous-release	13.81ms - 14.10ms	slower ❌ 10% - 15% 1.32ms - 1.82ms	slower ❌ 10% - 15% 1.23ms - 1.80ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	372.01ms - 414.00ms	-	unsure 🔍 -10% - +4% -40.12ms - +15.71ms	faster ✔ 21% - 30% 105.34ms - 161.69ms
tip-of-tree tip-of-tree	386.81ms - 423.60ms	unsure 🔍 -4% - +10% -15.71ms - +40.12ms	-	faster ✔ 19% - 27% 95.01ms - 147.61ms
previous-release previous-release	507.73ms - 545.31ms	slower ❌ 25% - 43% 105.34ms - 161.69ms	slower ❌ 22% - 37% 95.01ms - 147.61ms	-

lit-html-template-heavy

• Browser: chrome-headless 100.0.4896.75
• Sample size: 50
• Built by: Benchmarks #2730

• Commit: 7055443

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	61.94ms - 63.19ms	-	unsure 🔍 -1% - +2% -0.65ms - +1.18ms	faster ✔ 14% - 18% 10.61ms - 13.46ms
tip-of-tree tip-of-tree	61.63ms - 62.96ms	unsure 🔍 -2% - +1% -1.18ms - +0.65ms	-	faster ✔ 15% - 18% 10.86ms - 13.74ms
previous-release previous-release	73.31ms - 75.87ms	slower ❌ 17% - 22% 10.61ms - 13.46ms	slower ❌ 17% - 22% 10.86ms - 13.74ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	135.92ms - 138.56ms	-	unsure 🔍 -1% - +2% -1.94ms - +2.92ms	faster ✔ 14% - 17% 22.14ms - 28.02ms
tip-of-tree tip-of-tree	134.71ms - 138.80ms	unsure 🔍 -2% - +1% -2.92ms - +1.94ms	-	faster ✔ 14% - 18% 22.24ms - 28.89ms
previous-release previous-release	159.70ms - 164.95ms	slower ❌ 16% - 20% 22.14ms - 28.02ms	slower ❌ 16% - 21% 22.24ms - 28.89ms	-

reactive-element-list

• Browser: chrome-headless 100.0.4896.75
• Sample size: 50
• Built by: Benchmarks #2730

• Commit: 7055443

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.54ms - 93.96ms	-	unsure 🔍 -17% - +11% -14.69ms - +10.07ms	unsure 🔍 -9% - +21% -7.31ms - +16.60ms
tip-of-tree tip-of-tree	78.76ms - 96.36ms	unsure 🔍 -12% - +17% -10.07ms - +14.69ms	-	unsure 🔍 -7% - +24% -5.06ms - +18.97ms
previous-release previous-release	72.42ms - 88.80ms	unsure 🔍 -19% - +8% -16.60ms - +7.31ms	unsure 🔍 -21% - +5% -18.97ms - +5.06ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1118.24ms - 1335.75ms	-	unsure 🔍 -13% - +13% -157.63ms - +155.16ms	unsure 🔍 -12% - +13% -150.62ms - +163.62ms
tip-of-tree tip-of-tree	1115.83ms - 1340.62ms	unsure 🔍 -13% - +13% -155.16ms - +157.63ms	-	unsure 🔍 -12% - +14% -151.93ms - +167.39ms
previous-release previous-release	1107.10ms - 1333.89ms	unsure 🔍 -13% - +12% -163.62ms - +150.62ms	unsure 🔍 -14% - +12% -167.39ms - +151.93ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	901.60ms - 922.04ms	-	unsure 🔍 -1% - +2% -11.01ms - +18.39ms	unsure 🔍 -2% - +2% -19.68ms - +17.16ms
tip-of-tree tip-of-tree	897.56ms - 918.69ms	unsure 🔍 -2% - +1% -18.39ms - +11.01ms	-	unsure 🔍 -3% - +1% -23.56ms - +13.66ms
previous-release previous-release	897.76ms - 928.40ms	unsure 🔍 -2% - +2% -17.16ms - +19.68ms	unsure 🔍 -2% - +3% -13.66ms - +23.56ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[justinfagnani]

This wasn't ignored before and the examples were causing all kinds of lint errors. Are we correctly running lint on CI? @aomarks