You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While migrating internal to Lit 2, we had these additional options to change how the render function behaved. However these are no longer required as they are not referenced internally.
Testing
Tested internally with a TGP using the same change, and checking for all references of INTERNAL and clearContainerForLit2MigrationOnly. Manually checked that copy.bara wouldn't need changes.
I also removed a unit test that was testing the INTERNAL and clearContainerForLit2MigrationOnly option behavior.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While migrating internal to Lit 2, we had these additional options to change how the
render
function behaved. However these are no longer required as they are not referenced internally.Testing
Tested internally with a TGP using the same change, and checking for all references of
INTERNAL
andclearContainerForLit2MigrationOnly
. Manually checked that copy.bara wouldn't need changes.I also removed a unit test that was testing the
INTERNAL
andclearContainerForLit2MigrationOnly
option behavior.