Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo. #2847

Merged
merged 2 commits into from
May 16, 2022
Merged

Fix typo. #2847

merged 2 commits into from
May 16, 2022

Conversation

arthurevans
Copy link
Contributor

@arthurevans arthurevans commented May 9, 2022

Fix is API doc only, error originally reported in lit/lit.dev#769.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022

🦋 Changeset detected

Latest commit: 7c86274

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-0.42ms - +1.17ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +1% (-0.87ms - +0.75ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -1% - +3% (-0.19ms - +1.02ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +1% (-0.34ms - +0.13ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.33ms - +0.98ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -16% - +10% (-13.46ms - +8.43ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -5% - +2% (-44.73ms - +14.85ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -7% - +3% (-6.35ms - +2.72ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +11% (-10.57ms - +35.25ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.11ms - +1.66ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -12% - +6% (-124.95ms - +60.95ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +1% (-8.85ms - +9.15ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +1% (-27.00ms - +7.94ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
76.00ms - 77.19ms-unsure 🔍
-1% - +1%
-0.87ms - +0.75ms
faster ✔
17% - 20%
15.38ms - 18.57ms
tip-of-tree
tip-of-tree
76.10ms - 77.21msunsure 🔍
-1% - +1%
-0.75ms - +0.87ms
-faster ✔
17% - 20%
15.33ms - 18.50ms
previous-release
previous-release
92.09ms - 95.05msslower ❌
20% - 24%
15.38ms - 18.57ms
slower ❌
20% - 24%
15.33ms - 18.50ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
833.47ms - 868.18ms-unsure 🔍
-5% - +2%
-44.73ms - +14.85ms
faster ✔
33% - 36%
429.21ms - 476.23ms
tip-of-tree
tip-of-tree
841.55ms - 889.98msunsure 🔍
-2% - +5%
-14.85ms - +44.73ms
-faster ✔
32% - 36%
408.83ms - 466.72ms
previous-release
previous-release
1287.69ms - 1319.40msslower ❌
50% - 57%
429.21ms - 476.23ms
slower ❌
46% - 55%
408.83ms - 466.72ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
817.47ms - 831.41ms-unsure 🔍
-1% - +1%
-8.85ms - +9.15ms
faster ✔
7% - 9%
63.88ms - 84.47ms
tip-of-tree
tip-of-tree
818.59ms - 829.98msunsure 🔍
-1% - +1%
-9.15ms - +8.85ms
-faster ✔
7% - 9%
64.86ms - 83.80ms
previous-release
previous-release
891.04ms - 906.18msslower ❌
8% - 10%
63.88ms - 84.47ms
slower ❌
8% - 10%
64.86ms - 83.80ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.28ms - 31.40ms-unsure 🔍
-1% - +3%
-0.19ms - +1.02ms
faster ✔
11% - 17%
3.97ms - 6.20ms
tip-of-tree
tip-of-tree
30.20ms - 30.64msunsure 🔍
-3% - +1%
-1.02ms - +0.19ms
-faster ✔
13% - 18%
4.52ms - 6.49ms
previous-release
previous-release
34.97ms - 36.89msslower ❌
13% - 20%
3.97ms - 6.20ms
slower ❌
15% - 21%
4.52ms - 6.49ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
84.02ms - 88.78ms-unsure 🔍
-7% - +3%
-6.35ms - +2.72ms
unsure 🔍
-6% - +3%
-5.52ms - +2.33ms
tip-of-tree
tip-of-tree
84.36ms - 92.07msunsure 🔍
-3% - +7%
-2.72ms - +6.35ms
-unsure 🔍
-5% - +6%
-4.73ms - +5.18ms
previous-release
previous-release
84.88ms - 91.11msunsure 🔍
-3% - +6%
-2.33ms - +5.52ms
unsure 🔍
-6% - +5%
-5.18ms - +4.73ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
26.67ms - 28.03ms-unsure 🔍
-2% - +4%
-0.42ms - +1.17ms
faster ✔
8% - 13%
2.34ms - 3.90ms
tip-of-tree
tip-of-tree
26.57ms - 27.38msunsure 🔍
-4% - +1%
-1.17ms - +0.42ms
-faster ✔
10% - 13%
2.94ms - 4.05ms
previous-release
previous-release
30.09ms - 30.84msslower ❌
8% - 15%
2.34ms - 3.90ms
slower ❌
11% - 15%
2.94ms - 4.05ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.68ms - 10.95ms-unsure 🔍
-3% - +1%
-0.34ms - +0.13ms
faster ✔
10% - 12%
1.22ms - 1.51ms
tip-of-tree
tip-of-tree
10.73ms - 11.11msunsure 🔍
-1% - +3%
-0.13ms - +0.34ms
-faster ✔
9% - 12%
1.06ms - 1.46ms
previous-release
previous-release
12.12ms - 12.24msslower ❌
11% - 14%
1.22ms - 1.51ms
slower ❌
9% - 14%
1.06ms - 1.46ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
334.10ms - 367.77ms-unsure 🔍
-3% - +11%
-10.57ms - +35.25ms
faster ✔
20% - 29%
88.52ms - 134.17ms
tip-of-tree
tip-of-tree
323.05ms - 354.13msunsure 🔍
-10% - +3%
-35.25ms - +10.57ms
-faster ✔
23% - 31%
101.80ms - 145.58ms
previous-release
previous-release
446.86ms - 477.70msslower ❌
24% - 39%
88.52ms - 134.17ms
slower ❌
29% - 44%
101.80ms - 145.58ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.24ms - 55.20ms-unsure 🔍
-1% - +2%
-0.33ms - +0.98ms
faster ✔
14% - 17%
9.31ms - 11.11ms
tip-of-tree
tip-of-tree
53.95ms - 54.84msunsure 🔍
-2% - +1%
-0.98ms - +0.33ms
-faster ✔
15% - 17%
9.65ms - 11.42ms
previous-release
previous-release
64.17ms - 65.69msslower ❌
17% - 20%
9.31ms - 11.11ms
slower ❌
18% - 21%
9.65ms - 11.42ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
120.93ms - 123.94ms-unsure 🔍
-2% - +1%
-2.11ms - +1.66ms
faster ✔
13% - 16%
17.81ms - 23.17ms
tip-of-tree
tip-of-tree
121.52ms - 123.80msunsure 🔍
-1% - +2%
-1.66ms - +2.11ms
-faster ✔
13% - 16%
17.78ms - 22.76ms
previous-release
previous-release
140.71ms - 145.15msslower ❌
14% - 19%
17.81ms - 23.17ms
slower ❌
14% - 19%
17.78ms - 22.76ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
74.92ms - 90.28ms-unsure 🔍
-16% - +10%
-13.46ms - +8.43ms
unsure 🔍
-17% - +8%
-15.00ms - +6.98ms
tip-of-tree
tip-of-tree
77.32ms - 92.91msunsure 🔍
-10% - +16%
-8.43ms - +13.46ms
-unsure 🔍
-14% - +11%
-12.57ms - +9.57ms
previous-release
previous-release
78.76ms - 94.48msunsure 🔍
-9% - +18%
-6.98ms - +15.00ms
unsure 🔍
-11% - +15%
-9.57ms - +12.57ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
895.50ms - 1023.89ms-unsure 🔍
-12% - +6%
-124.95ms - +60.95ms
unsure 🔍
-19% - +0%
-202.02ms - +9.66ms
tip-of-tree
tip-of-tree
924.47ms - 1058.92msunsure 🔍
-7% - +13%
-60.95ms - +124.95ms
-unsure 🔍
-16% - +4%
-171.89ms - +43.53ms
previous-release
previous-release
971.72ms - 1140.03msunsure 🔍
-1% - +21%
-9.66ms - +202.02ms
unsure 🔍
-5% - +18%
-43.53ms - +171.89ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
882.90ms - 908.13ms-unsure 🔍
-3% - +1%
-27.00ms - +7.94ms
unsure 🔍
-2% - +2%
-17.42ms - +17.17ms
tip-of-tree
tip-of-tree
892.96ms - 917.13msunsure 🔍
-1% - +3%
-7.94ms - +27.00ms
-unsure 🔍
-1% - +3%
-7.51ms - +26.32ms
previous-release
previous-release
883.80ms - 907.48msunsure 🔍
-2% - +2%
-17.17ms - +17.42ms
unsure 🔍
-3% - +1%
-26.32ms - +7.51ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Needs a tiny changeset for lit-html and lit please.

@arthurevans arthurevans merged commit 79d8238 into main May 16, 2022
@arthurevans arthurevans deleted the arthurevans-patch-1 branch May 16, 2022 17:40
This was referenced May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants