Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove changeset for private packages #3105

Merged
merged 1 commit into from Jun 29, 2022

Conversation

augustjk
Copy link
Member

Since we don't need changelogs to be updated for yet to be released packages.

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022

⚠️ No Changeset found

Latest commit: 45a9594

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@augustjk augustjk enabled auto-merge (squash) June 29, 2022 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -5% - +1% (-1.42ms - +0.30ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -2% - +2% (-1.56ms - +1.36ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -0% - +6% (-0.02ms - +1.88ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +6% (-0.21ms - +0.65ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +3% (-0.86ms - +1.73ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-1.43ms - +0.91ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -2% - +1% (-10.65ms - +4.63ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -3% - +4% (-2.82ms - +2.92ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -7% - +5% (-21.05ms - +16.09ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.97ms - +4.23ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-4.99ms - +4.89ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +1% (-8.58ms - +3.82ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +2% (-1.74ms - +14.21ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
73.27ms - 75.24ms-unsure 🔍
-2% - +2%
-1.56ms - +1.36ms
faster ✔
20% - 23%
19.16ms - 22.17ms
tip-of-tree
tip-of-tree
73.27ms - 75.43msunsure 🔍
-2% - +2%
-1.36ms - +1.56ms
-faster ✔
20% - 23%
19.00ms - 22.14ms
previous-release
previous-release
93.78ms - 96.06msslower ❌
26% - 30%
19.16ms - 22.17ms
slower ❌
25% - 30%
19.00ms - 22.14ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
692.35ms - 702.91ms-unsure 🔍
-2% - +1%
-10.65ms - +4.63ms
faster ✔
6% - 8%
44.69ms - 58.34ms
tip-of-tree
tip-of-tree
695.12ms - 706.16msunsure 🔍
-1% - +2%
-4.63ms - +10.65ms
-faster ✔
6% - 7%
41.49ms - 55.51ms
previous-release
previous-release
744.82ms - 753.46msslower ❌
6% - 8%
44.69ms - 58.34ms
slower ❌
6% - 8%
41.49ms - 55.51ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
707.71ms - 716.97ms-unsure 🔍
-1% - +1%
-8.58ms - +3.82ms
faster ✔
4% - 6%
32.11ms - 44.13ms
tip-of-tree
tip-of-tree
710.61ms - 718.84msunsure 🔍
-1% - +1%
-3.82ms - +8.58ms
-faster ✔
4% - 5%
30.11ms - 41.36ms
previous-release
previous-release
746.63ms - 754.29msslower ❌
4% - 6%
32.11ms - 44.13ms
slower ❌
4% - 6%
30.11ms - 41.36ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
29.43ms - 30.99ms-unsure 🔍
-0% - +6%
-0.02ms - +1.88ms
faster ✔
13% - 19%
4.50ms - 7.03ms
tip-of-tree
tip-of-tree
28.74ms - 29.83msunsure 🔍
-6% - +0%
-1.88ms - +0.02ms
-faster ✔
16% - 21%
5.55ms - 7.83ms
previous-release
previous-release
34.98ms - 36.97msslower ❌
15% - 24%
4.50ms - 7.03ms
slower ❌
19% - 27%
5.55ms - 7.83ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
80.87ms - 84.79ms-unsure 🔍
-3% - +4%
-2.82ms - +2.92ms
unsure 🔍
-7% - +0%
-6.02ms - +0.41ms
tip-of-tree
tip-of-tree
80.68ms - 84.87msunsure 🔍
-4% - +3%
-2.92ms - +2.82ms
-unsure 🔍
-7% - +0%
-6.15ms - +0.44ms
previous-release
previous-release
83.09ms - 88.18msunsure 🔍
-1% - +7%
-0.41ms - +6.02ms
unsure 🔍
-1% - +7%
-0.44ms - +6.15ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
25.46ms - 26.40ms-unsure 🔍
-5% - +1%
-1.42ms - +0.30ms
faster ✔
12% - 16%
3.51ms - 5.01ms
tip-of-tree
tip-of-tree
25.77ms - 27.21msunsure 🔍
-1% - +5%
-0.30ms - +1.42ms
-faster ✔
9% - 15%
2.78ms - 4.63ms
previous-release
previous-release
29.61ms - 30.77msslower ❌
13% - 20%
3.51ms - 5.01ms
slower ❌
10% - 18%
2.78ms - 4.63ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.49ms - 11.11ms-unsure 🔍
-2% - +6%
-0.21ms - +0.65ms
faster ✔
7% - 13%
0.84ms - 1.52ms
tip-of-tree
tip-of-tree
10.28ms - 10.88msunsure 🔍
-6% - +2%
-0.65ms - +0.21ms
-faster ✔
9% - 14%
1.07ms - 1.74ms
previous-release
previous-release
11.84ms - 12.13msslower ❌
8% - 14%
0.84ms - 1.52ms
slower ❌
10% - 17%
1.07ms - 1.74ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
275.76ms - 303.55ms-unsure 🔍
-7% - +5%
-21.05ms - +16.09ms
faster ✔
22% - 32%
85.88ms - 130.26ms
tip-of-tree
tip-of-tree
279.82ms - 304.45msunsure 🔍
-6% - +7%
-16.09ms - +21.05ms
-faster ✔
22% - 31%
84.35ms - 126.82ms
previous-release
previous-release
380.43ms - 415.02msslower ❌
28% - 46%
85.88ms - 130.26ms
slower ❌
28% - 44%
84.35ms - 126.82ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.07ms - 56.03ms-unsure 🔍
-2% - +3%
-0.86ms - +1.73ms
faster ✔
18% - 23%
12.30ms - 16.47ms
tip-of-tree
tip-of-tree
53.77ms - 55.47msunsure 🔍
-3% - +2%
-1.73ms - +0.86ms
-faster ✔
19% - 24%
12.79ms - 16.84ms
previous-release
previous-release
67.60ms - 71.27msslower ❌
22% - 30%
12.30ms - 16.47ms
slower ❌
23% - 31%
12.79ms - 16.84ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
118.93ms - 123.33ms-unsure 🔍
-1% - +4%
-0.97ms - +4.23ms
faster ✔
11% - 15%
14.96ms - 21.30ms
tip-of-tree
tip-of-tree
118.12ms - 120.89msunsure 🔍
-3% - +1%
-4.23ms - +0.97ms
-faster ✔
12% - 16%
17.09ms - 22.43ms
previous-release
previous-release
136.98ms - 141.55msslower ❌
12% - 18%
14.96ms - 21.30ms
slower ❌
14% - 19%
17.09ms - 22.43ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.34ms - 56.61ms-unsure 🔍
-3% - +2%
-1.43ms - +0.91ms
unsure 🔍
-1% - +3%
-0.65ms - +1.45ms
tip-of-tree
tip-of-tree
55.25ms - 57.22msunsure 🔍
-2% - +3%
-0.91ms - +1.43ms
-unsure 🔍
-1% - +4%
-0.63ms - +1.95ms
previous-release
previous-release
54.74ms - 56.41msunsure 🔍
-3% - +1%
-1.45ms - +0.65ms
unsure 🔍
-3% - +1%
-1.95ms - +0.63ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
697.65ms - 705.05ms-unsure 🔍
-1% - +1%
-4.99ms - +4.89ms
unsure 🔍
-1% - +1%
-4.52ms - +7.14ms
tip-of-tree
tip-of-tree
698.13ms - 704.66msunsure 🔍
-1% - +1%
-4.89ms - +4.99ms
-unsure 🔍
-1% - +1%
-4.21ms - +6.93ms
previous-release
previous-release
695.53ms - 704.54msunsure 🔍
-1% - +1%
-7.14ms - +4.52ms
unsure 🔍
-1% - +1%
-6.93ms - +4.21ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
807.04ms - 816.41ms-unsure 🔍
-0% - +2%
-1.74ms - +14.21ms
unsure 🔍
-1% - +1%
-10.89ms - +7.76ms
tip-of-tree
tip-of-tree
799.03ms - 811.94msunsure 🔍
-2% - +0%
-14.21ms - +1.74ms
-unsure 🔍
-2% - +0%
-18.13ms - +2.52ms
previous-release
previous-release
805.23ms - 821.35msunsure 🔍
-1% - +1%
-7.76ms - +10.89ms
unsure 🔍
-0% - +2%
-2.52ms - +18.13ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk merged commit 3380417 into main Jun 29, 2022
@augustjk augustjk deleted the remove-private-changeset branch June 29, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants