Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/react] remove StringValued type #3111

Merged
merged 3 commits into from Jul 12, 2022

Conversation

taylor-vann
Copy link
Contributor

This PR removes the StringValued type.

It can be replaced by the Events type.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2022

🦋 Changeset detected

Latest commit: ea1510b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taylor-vann taylor-vann marked this pull request as ready for review July 1, 2022 00:19
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -1% - +5% (-0.38ms - +1.40ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 72.91ms - 73.89ms
  • lit-html-kitchen-sink: slower ❌ 0% - 2% (0.02ms - 0.55ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +2% (-0.13ms - +0.24ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +0% (-1.03ms - +0.27ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-0.53ms - +0.51ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 701.96ms - 706.24ms
  • lit-html-kitchen-sink: unsure 🔍 -1% - +4% (-1.01ms - +3.19ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +1% (-2.81ms - +3.71ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.02ms - +1.22ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-1.09ms - +4.77ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 720.17ms - 724.63ms
  • reactive-element-list: unsure 🔍 -1% - +0% (-6.87ms - +3.29ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
72.91ms - 73.89ms-

update

VersionAvg timevs
701.96ms - 706.24ms-

update-reflect

VersionAvg timevs
720.17ms - 724.63ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
28.84ms - 29.25ms-slower ❌
0% - 2%
0.02ms - 0.55ms
unsure 🔍
-0% - +2%
-0.10ms - +0.47ms
tip-of-tree
tip-of-tree
28.60ms - 28.93msfaster ✔
0% - 2%
0.02ms - 0.55ms
-unsure 🔍
-1% - +1%
-0.36ms - +0.16ms
previous-release
previous-release
28.67ms - 29.06msunsure 🔍
-2% - +0%
-0.47ms - +0.10ms
unsure 🔍
-1% - +1%
-0.16ms - +0.36ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
79.88ms - 83.53ms-unsure 🔍
-1% - +4%
-1.01ms - +3.19ms
unsure 🔍
-3% - +3%
-2.49ms - +2.05ms
tip-of-tree
tip-of-tree
79.59ms - 81.65msunsure 🔍
-4% - +1%
-3.19ms - +1.01ms
-unsure 🔍
-4% - +0%
-3.00ms - +0.39ms
previous-release
previous-release
80.58ms - 83.27msunsure 🔍
-3% - +3%
-2.05ms - +2.49ms
unsure 🔍
-0% - +4%
-0.39ms - +3.00ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
25.85ms - 27.54ms-unsure 🔍
-1% - +5%
-0.38ms - +1.40ms
unsure 🔍
-2% - +5%
-0.45ms - +1.31ms
tip-of-tree
tip-of-tree
25.91ms - 26.46msunsure 🔍
-5% - +1%
-1.40ms - +0.38ms
-unsure 🔍
-2% - +1%
-0.45ms - +0.29ms
previous-release
previous-release
26.02ms - 26.51msunsure 🔍
-5% - +2%
-1.31ms - +0.45ms
unsure 🔍
-1% - +2%
-0.29ms - +0.45ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.30ms - 10.58ms-unsure 🔍
-1% - +2%
-0.13ms - +0.24ms
unsure 🔍
-1% - +2%
-0.12ms - +0.24ms
tip-of-tree
tip-of-tree
10.26ms - 10.50msunsure 🔍
-2% - +1%
-0.24ms - +0.13ms
-unsure 🔍
-2% - +2%
-0.16ms - +0.17ms
previous-release
previous-release
10.26ms - 10.49msunsure 🔍
-2% - +1%
-0.24ms - +0.12ms
unsure 🔍
-2% - +2%
-0.17ms - +0.16ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
272.96ms - 278.59ms-unsure 🔍
-1% - +1%
-2.81ms - +3.71ms
unsure 🔍
-1% - +1%
-2.52ms - +4.01ms
tip-of-tree
tip-of-tree
273.68ms - 276.96msunsure 🔍
-1% - +1%
-3.71ms - +2.81ms
-unsure 🔍
-1% - +1%
-2.04ms - +2.62ms
previous-release
previous-release
273.38ms - 276.69msunsure 🔍
-1% - +1%
-4.01ms - +2.52ms
unsure 🔍
-1% - +1%
-2.62ms - +2.04ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
53.06ms - 53.89ms-unsure 🔍
-2% - +0%
-1.03ms - +0.27ms
unsure 🔍
-2% - +1%
-0.81ms - +0.29ms
tip-of-tree
tip-of-tree
53.36ms - 54.35msunsure 🔍
-1% - +2%
-0.27ms - +1.03ms
-unsure 🔍
-1% - +1%
-0.49ms - +0.73ms
previous-release
previous-release
53.38ms - 54.09msunsure 🔍
-1% - +2%
-0.29ms - +0.81ms
unsure 🔍
-1% - +1%
-0.73ms - +0.49ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
116.55ms - 118.06ms-unsure 🔍
-1% - +1%
-1.02ms - +1.22ms
unsure 🔍
-1% - +1%
-1.34ms - +1.05ms
tip-of-tree
tip-of-tree
116.38ms - 118.03msunsure 🔍
-1% - +1%
-1.22ms - +1.02ms
-unsure 🔍
-1% - +1%
-1.48ms - +0.99ms
previous-release
previous-release
116.53ms - 118.37msunsure 🔍
-1% - +1%
-1.05ms - +1.34ms
unsure 🔍
-1% - +1%
-0.99ms - +1.48ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.93ms - 55.73ms-unsure 🔍
-1% - +1%
-0.53ms - +0.51ms
unsure 🔍
-0% - +1%
-0.22ms - +0.75ms
tip-of-tree
tip-of-tree
55.01ms - 55.67msunsure 🔍
-1% - +1%
-0.51ms - +0.53ms
-unsure 🔍
-0% - +1%
-0.15ms - +0.70ms
previous-release
previous-release
54.79ms - 55.33msunsure 🔍
-1% - +0%
-0.75ms - +0.22ms
unsure 🔍
-1% - +0%
-0.70ms - +0.15ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
706.15ms - 710.77ms-unsure 🔍
-0% - +1%
-1.09ms - +4.77ms
unsure 🔍
-0% - +1%
-2.06ms - +4.24ms
tip-of-tree
tip-of-tree
704.82ms - 708.43msunsure 🔍
-1% - +0%
-4.77ms - +1.09ms
-unsure 🔍
-1% - +0%
-3.54ms - +2.05ms
previous-release
previous-release
705.23ms - 709.51msunsure 🔍
-1% - +0%
-4.24ms - +2.06ms
unsure 🔍
-0% - +1%
-2.05ms - +3.54ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
815.34ms - 822.92ms-unsure 🔍
-1% - +0%
-6.87ms - +3.29ms
unsure 🔍
-1% - +1%
-4.30ms - +6.84ms
tip-of-tree
tip-of-tree
817.53ms - 824.30msunsure 🔍
-0% - +1%
-3.29ms - +6.87ms
-unsure 🔍
-0% - +1%
-2.24ms - +8.36ms
previous-release
previous-release
813.77ms - 821.94msunsure 🔍
-1% - +1%
-6.84ms - +4.30ms
unsure 🔍
-1% - +0%
-8.36ms - +2.24ms
-

tachometer-reporter-action v2 for Benchmarks

@taylor-vann taylor-vann changed the title [labs/react] remove unnecessary types [labs/react] remove StringValued type Jul 11, 2022
@taylor-vann taylor-vann requested a review from sorvell July 11, 2022 23:43
@taylor-vann
Copy link
Contributor Author

Tha ks @justinfagnani ! <3

@taylor-vann taylor-vann merged commit 6158482 into main Jul 12, 2022
@taylor-vann taylor-vann deleted the labs_react__remove_unnecessary_types branch July 12, 2022 23:09
This was referenced Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants