Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/testing] Pass module file urls to worker for Windows compatibility #3175

Merged
merged 3 commits into from Jul 26, 2022

Conversation

augustjk
Copy link
Member

Fixes #3165

In Mac/Linux, process.cwd() returns an absolute file path starting with /.
But in Windows, it returns a path starting with C:\ which Node's import thinks is specifying some invalid protocol. Converting the absolute file paths to file URLs fixes this as it'll always begin with file://.

I also added the test for this package to windows-tools test job.

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

🦋 Changeset detected

Latest commit: 4d81055

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -5% - +7% (-1.73ms - +2.40ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 95.41ms - 100.19ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +2% (-1.83ms - +0.87ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -5% - +5% (-0.62ms - +0.70ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +2% (-2.76ms - +1.58ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-2.27ms - +1.57ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1013.35ms - 1041.16ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +4% (-5.36ms - +4.47ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +2% (-11.77ms - +8.82ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +2% (-8.00ms - +3.08ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +3% (-12.98ms - +28.53ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1008.63ms - 1034.40ms
  • reactive-element-list: unsure 🔍 -0% - +4% (-3.84ms - +43.49ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
95.41ms - 100.19ms-

update

VersionAvg timevs
1013.35ms - 1041.16ms-

update-reflect

VersionAvg timevs
1008.63ms - 1034.40ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
36.66ms - 38.03ms-unsure 🔍
-5% - +2%
-1.83ms - +0.87ms
unsure 🔍
-4% - +2%
-1.60ms - +0.77ms
tip-of-tree
tip-of-tree
36.66ms - 38.99msunsure 🔍
-2% - +5%
-0.87ms - +1.83ms
-unsure 🔍
-4% - +4%
-1.45ms - +1.57ms
previous-release
previous-release
36.80ms - 38.72msunsure 🔍
-2% - +4%
-0.77ms - +1.60ms
unsure 🔍
-4% - +4%
-1.57ms - +1.45ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
105.40ms - 112.60ms-unsure 🔍
-5% - +4%
-5.36ms - +4.47ms
unsure 🔍
-7% - +2%
-8.26ms - +1.99ms
tip-of-tree
tip-of-tree
106.10ms - 112.78msunsure 🔍
-4% - +5%
-4.47ms - +5.36ms
-unsure 🔍
-7% - +2%
-7.63ms - +2.25ms
previous-release
previous-release
108.49ms - 115.77msunsure 🔍
-2% - +8%
-1.99ms - +8.26ms
unsure 🔍
-2% - +7%
-2.25ms - +7.63ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
32.51ms - 35.58ms-unsure 🔍
-5% - +7%
-1.73ms - +2.40ms
unsure 🔍
-2% - +8%
-0.72ms - +2.75ms
tip-of-tree
tip-of-tree
32.33ms - 35.09msunsure 🔍
-7% - +5%
-2.40ms - +1.73ms
-unsure 🔍
-3% - +7%
-0.92ms - +2.28ms
previous-release
previous-release
32.22ms - 33.84msunsure 🔍
-8% - +2%
-2.75ms - +0.72ms
unsure 🔍
-7% - +3%
-2.28ms - +0.92ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.58ms - 13.45ms-unsure 🔍
-5% - +5%
-0.62ms - +0.70ms
unsure 🔍
-7% - +2%
-0.88ms - +0.27ms
tip-of-tree
tip-of-tree
12.48ms - 13.47msunsure 🔍
-5% - +5%
-0.70ms - +0.62ms
-unsure 🔍
-7% - +2%
-0.97ms - +0.28ms
previous-release
previous-release
12.94ms - 13.70msunsure 🔍
-2% - +7%
-0.27ms - +0.88ms
unsure 🔍
-2% - +8%
-0.28ms - +0.97ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
374.01ms - 389.75ms-unsure 🔍
-3% - +2%
-11.77ms - +8.82ms
unsure 🔍
-7% - +0%
-27.01ms - +1.38ms
tip-of-tree
tip-of-tree
376.72ms - 389.99msunsure 🔍
-2% - +3%
-8.82ms - +11.77ms
-unsure 🔍
-6% - +0%
-24.88ms - +2.21ms
previous-release
previous-release
382.89ms - 406.50msunsure 🔍
-0% - +7%
-1.38ms - +27.01ms
unsure 🔍
-1% - +7%
-2.21ms - +24.88ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
68.40ms - 71.04ms-unsure 🔍
-4% - +2%
-2.76ms - +1.58ms
unsure 🔍
-3% - +3%
-2.20ms - +1.84ms
tip-of-tree
tip-of-tree
68.59ms - 72.03msunsure 🔍
-2% - +4%
-1.58ms - +2.76ms
-unsure 🔍
-3% - +4%
-1.89ms - +2.71ms
previous-release
previous-release
68.37ms - 71.43msunsure 🔍
-3% - +3%
-1.84ms - +2.20ms
unsure 🔍
-4% - +3%
-2.71ms - +1.89ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
152.04ms - 159.53ms-unsure 🔍
-5% - +2%
-8.00ms - +3.08ms
unsure 🔍
-4% - +3%
-5.90ms - +4.77ms
tip-of-tree
tip-of-tree
154.17ms - 162.33msunsure 🔍
-2% - +5%
-3.08ms - +8.00ms
-unsure 🔍
-2% - +5%
-3.68ms - +7.48ms
previous-release
previous-release
152.55ms - 160.15msunsure 🔍
-3% - +4%
-4.77ms - +5.90ms
unsure 🔍
-5% - +2%
-7.48ms - +3.68ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.01ms - 68.79ms-unsure 🔍
-3% - +2%
-2.27ms - +1.57ms
unsure 🔍
-3% - +1%
-1.71ms - +0.98ms
tip-of-tree
tip-of-tree
66.56ms - 69.95msunsure 🔍
-2% - +3%
-1.57ms - +2.27ms
-unsure 🔍
-3% - +3%
-1.99ms - +1.96ms
previous-release
previous-release
67.26ms - 69.28msunsure 🔍
-1% - +3%
-0.98ms - +1.71ms
unsure 🔍
-3% - +3%
-1.96ms - +1.99ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1037.07ms - 1067.38ms-unsure 🔍
-1% - +3%
-12.98ms - +28.53ms
unsure 🔍
-2% - +2%
-24.94ms - +16.32ms
tip-of-tree
tip-of-tree
1030.26ms - 1058.64msunsure 🔍
-3% - +1%
-28.53ms - +12.98ms
-unsure 🔍
-3% - +1%
-32.02ms - +7.85ms
previous-release
previous-release
1042.54ms - 1070.54msunsure 🔍
-2% - +2%
-16.32ms - +24.94ms
unsure 🔍
-1% - +3%
-7.85ms - +32.02ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1088.73ms - 1124.08ms-unsure 🔍
-0% - +4%
-3.84ms - +43.49ms
slower ❌
0% - 4%
1.25ms - 46.83ms
tip-of-tree
tip-of-tree
1070.84ms - 1102.31msunsure 🔍
-4% - +0%
-43.49ms - +3.84ms
-unsure 🔍
-2% - +2%
-17.10ms - +25.53ms
previous-release
previous-release
1067.98ms - 1096.74msfaster ✔
0% - 4%
1.25ms - 46.83ms
unsure 🔍
-2% - +2%
-25.53ms - +17.10ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice fix!

@augustjk augustjk merged commit 27e08e5 into main Jul 26, 2022
@augustjk augustjk deleted the testing-pkg-windows branch July 26, 2022 00:23
@lit-robot lit-robot mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/testing] WTR plugin for SSR does not work in Windows
2 participants