Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/ssr] Add URL and URLSearchParams to VM module global #3187

Merged
merged 2 commits into from Jul 28, 2022
Merged

Conversation

augustjk
Copy link
Member

Fixes #3168

Adds URL and URLSearchParams class to the global that's provided to the VM context when instantiating ModuleLoader.

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022

🦋 Changeset detected

Latest commit: 5dbbcc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -9% - +1% (-3.47ms - +0.36ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 113.47ms - 116.00ms
  • lit-html-kitchen-sink: unsure 🔍 -3% - +4% (-1.50ms - +1.99ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -11% - +2% (-1.61ms - +0.38ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.53ms - +0.61ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +1% (-2.77ms - +0.98ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1185.44ms - 1201.07ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +1% (-7.07ms - +1.22ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +8% (-23.88ms - +32.06ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +3% (-1.74ms - +5.00ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-5.37ms - +17.56ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1207.23ms - 1220.39ms
  • reactive-element-list: slower ❌ 0% - 2% (0.04ms - 23.72ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
113.47ms - 116.00ms-

update

VersionAvg timevs
1185.44ms - 1201.07ms-

update-reflect

VersionAvg timevs
1207.23ms - 1220.39ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
46.00ms - 48.56ms-unsure 🔍
-3% - +4%
-1.50ms - +1.99ms
unsure 🔍
-4% - +4%
-1.73ms - +1.94ms
tip-of-tree
tip-of-tree
45.85ms - 48.22msunsure 🔍
-4% - +3%
-1.99ms - +1.50ms
-unsure 🔍
-4% - +3%
-1.91ms - +1.62ms
previous-release
previous-release
45.87ms - 48.49msunsure 🔍
-4% - +4%
-1.94ms - +1.73ms
unsure 🔍
-3% - +4%
-1.62ms - +1.91ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
124.61ms - 129.38ms-unsure 🔍
-5% - +1%
-7.07ms - +1.22ms
unsure 🔍
-5% - +0%
-6.62ms - +0.41ms
tip-of-tree
tip-of-tree
126.53ms - 133.31msunsure 🔍
-1% - +6%
-1.22ms - +7.07ms
-unsure 🔍
-3% - +3%
-4.44ms - +4.08ms
previous-release
previous-release
127.52ms - 132.68msunsure 🔍
-0% - +5%
-0.41ms - +6.62ms
unsure 🔍
-3% - +3%
-4.08ms - +4.44ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
35.52ms - 37.40ms-unsure 🔍
-9% - +1%
-3.47ms - +0.36ms
faster ✔
0% - 8%
0.00ms - 3.25ms
tip-of-tree
tip-of-tree
36.35ms - 39.68msunsure 🔍
-1% - +10%
-0.36ms - +3.47ms
-unsure 🔍
-6% - +5%
-2.20ms - +2.05ms
previous-release
previous-release
36.77ms - 39.41msunsure 🔍
-0% - +9%
+0.00ms - +3.25ms
unsure 🔍
-5% - +6%
-2.05ms - +2.20ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.22ms - 13.90ms-unsure 🔍
-11% - +2%
-1.61ms - +0.38ms
unsure 🔍
-7% - +1%
-1.03ms - +0.19ms
tip-of-tree
tip-of-tree
13.23ms - 15.11msunsure 🔍
-3% - +12%
-0.38ms - +1.61ms
-unsure 🔍
-6% - +9%
-0.87ms - +1.26ms
previous-release
previous-release
13.48ms - 14.48msunsure 🔍
-1% - +8%
-0.19ms - +1.03ms
unsure 🔍
-9% - +6%
-1.26ms - +0.87ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
375.81ms - 420.66ms-unsure 🔍
-6% - +8%
-23.88ms - +32.06ms
unsure 🔍
-6% - +9%
-21.71ms - +35.85ms
tip-of-tree
tip-of-tree
377.43ms - 410.86msunsure 🔍
-8% - +6%
-32.06ms - +23.88ms
-unsure 🔍
-6% - +7%
-21.61ms - +27.58ms
previous-release
previous-release
373.13ms - 409.20msunsure 🔍
-9% - +5%
-35.85ms - +21.71ms
unsure 🔍
-7% - +5%
-27.58ms - +21.61ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
73.78ms - 75.76ms-unsure 🔍
-3% - +1%
-2.53ms - +0.61ms
unsure 🔍
-2% - +2%
-1.25ms - +1.59ms
tip-of-tree
tip-of-tree
74.51ms - 76.94msunsure 🔍
-1% - +3%
-0.61ms - +2.53ms
-unsure 🔍
-1% - +4%
-0.46ms - +2.71ms
previous-release
previous-release
73.58ms - 75.62msunsure 🔍
-2% - +2%
-1.59ms - +1.25ms
unsure 🔍
-4% - +1%
-2.71ms - +0.46ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
174.76ms - 179.47ms-unsure 🔍
-1% - +3%
-1.74ms - +5.00ms
unsure 🔍
-2% - +2%
-3.59ms - +3.26ms
tip-of-tree
tip-of-tree
173.08ms - 177.90msunsure 🔍
-3% - +1%
-5.00ms - +1.74ms
-unsure 🔍
-3% - +1%
-5.25ms - +1.67ms
previous-release
previous-release
174.80ms - 179.77msunsure 🔍
-2% - +2%
-3.26ms - +3.59ms
unsure 🔍
-1% - +3%
-1.67ms - +5.25ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
84.47ms - 87.12ms-unsure 🔍
-3% - +1%
-2.77ms - +0.98ms
unsure 🔍
-1% - +3%
-0.87ms - +2.32ms
tip-of-tree
tip-of-tree
85.36ms - 88.02msunsure 🔍
-1% - +3%
-0.98ms - +2.77ms
-slower ❌
0% - 4%
0.02ms - 3.22ms
previous-release
previous-release
84.19ms - 85.95msunsure 🔍
-3% - +1%
-2.32ms - +0.87ms
faster ✔
0% - 4%
0.02ms - 3.22ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1223.75ms - 1240.07ms-unsure 🔍
-0% - +1%
-5.37ms - +17.56ms
unsure 🔍
-0% - +2%
-1.48ms - +18.89ms
tip-of-tree
tip-of-tree
1217.76ms - 1233.87msunsure 🔍
-1% - +0%
-17.56ms - +5.37ms
-unsure 🔍
-1% - +1%
-7.49ms - +12.71ms
previous-release
previous-release
1217.10ms - 1229.30msunsure 🔍
-2% - +0%
-18.89ms - +1.48ms
unsure 🔍
-1% - +1%
-12.71ms - +7.49ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1268.63ms - 1288.00ms-slower ❌
0% - 2%
0.04ms - 23.72ms
unsure 🔍
-0% - +1%
-5.47ms - +18.34ms
tip-of-tree
tip-of-tree
1259.62ms - 1273.25msfaster ✔
0% - 2%
0.04ms - 23.72ms
-unsure 🔍
-1% - +0%
-15.16ms - +4.26ms
previous-release
previous-release
1264.96ms - 1278.80msunsure 🔍
-1% - +0%
-18.34ms - +5.47ms
unsure 🔍
-0% - +1%
-4.26ms - +15.16ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@augustjk augustjk merged commit 84437af into main Jul 28, 2022
@augustjk augustjk deleted the dom-shim-url branch July 28, 2022 23:19
@lit-robot lit-robot mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/ssr] URL is missing in the dom-shim
3 participants