Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/ssr] Use url module to convert file url to path #3204

Merged
merged 1 commit into from Aug 6, 2022

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Aug 6, 2022

Fixes #3202

This will allow SSR with VM modules on Windows machines.

Along with #3203, this should fix eleventy-plugin-lit running in vm mode for Windows users as well.

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2022

🦋 Changeset detected

Latest commit: 6956117

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +1% (-0.55ms - +0.35ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 72.16ms - 75.38ms
  • lit-html-kitchen-sink: unsure 🔍 -1% - +1% (-0.34ms - +0.19ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -10% - +5% (-1.10ms - +0.56ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-0.94ms - +0.48ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-0.57ms - +0.81ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 673.35ms - 682.79ms
  • lit-html-kitchen-sink: unsure 🔍 -3% - +1% (-2.64ms - +1.12ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +0% (-4.46ms - +0.84ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.25ms - +0.75ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-4.55ms - +1.51ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 688.84ms - 696.40ms
  • reactive-element-list: unsure 🔍 -0% - +2% (-1.34ms - +15.30ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
72.16ms - 75.38ms-

update

VersionAvg timevs
673.35ms - 682.79ms-

update-reflect

VersionAvg timevs
688.84ms - 696.40ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
27.94ms - 28.23ms-unsure 🔍
-1% - +1%
-0.34ms - +0.19ms
unsure 🔍
-1% - +1%
-0.18ms - +0.19ms
tip-of-tree
tip-of-tree
27.94ms - 28.39msunsure 🔍
-1% - +1%
-0.19ms - +0.34ms
-unsure 🔍
-1% - +1%
-0.17ms - +0.33ms
previous-release
previous-release
27.96ms - 28.20msunsure 🔍
-1% - +1%
-0.19ms - +0.18ms
unsure 🔍
-1% - +1%
-0.33ms - +0.17ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
75.95ms - 78.63ms-unsure 🔍
-3% - +1%
-2.64ms - +1.12ms
unsure 🔍
-2% - +3%
-1.74ms - +2.04ms
tip-of-tree
tip-of-tree
76.73ms - 79.37msunsure 🔍
-1% - +3%
-1.12ms - +2.64ms
-unsure 🔍
-1% - +4%
-0.97ms - +2.78ms
previous-release
previous-release
75.81ms - 78.47msunsure 🔍
-3% - +2%
-2.04ms - +1.74ms
unsure 🔍
-4% - +1%
-2.78ms - +0.97ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
24.95ms - 25.42ms-unsure 🔍
-2% - +1%
-0.55ms - +0.35ms
unsure 🔍
-2% - +1%
-0.50ms - +0.22ms
tip-of-tree
tip-of-tree
24.90ms - 25.67msunsure 🔍
-1% - +2%
-0.35ms - +0.55ms
-unsure 🔍
-2% - +2%
-0.51ms - +0.43ms
previous-release
previous-release
25.06ms - 25.60msunsure 🔍
-1% - +2%
-0.22ms - +0.50ms
unsure 🔍
-2% - +2%
-0.43ms - +0.51ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.30ms - 10.61ms-unsure 🔍
-10% - +5%
-1.10ms - +0.56ms
unsure 🔍
-1% - +2%
-0.15ms - +0.25ms
tip-of-tree
tip-of-tree
9.91ms - 11.54msunsure 🔍
-5% - +11%
-0.56ms - +1.10ms
-unsure 🔍
-5% - +11%
-0.50ms - +1.15ms
previous-release
previous-release
10.28ms - 10.52msunsure 🔍
-2% - +1%
-0.25ms - +0.15ms
unsure 🔍
-10% - +4%
-1.15ms - +0.50ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
269.32ms - 273.03ms-unsure 🔍
-2% - +0%
-4.46ms - +0.84ms
unsure 🔍
-2% - +0%
-5.89ms - +0.81ms
tip-of-tree
tip-of-tree
271.09ms - 274.87msunsure 🔍
-0% - +2%
-0.84ms - +4.46ms
-unsure 🔍
-1% - +1%
-4.10ms - +2.65ms
previous-release
previous-release
270.92ms - 276.50msunsure 🔍
-0% - +2%
-0.81ms - +5.89ms
unsure 🔍
-1% - +2%
-2.65ms - +4.10ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
51.93ms - 53.11ms-unsure 🔍
-2% - +1%
-0.94ms - +0.48ms
unsure 🔍
-1% - +2%
-0.48ms - +0.92ms
tip-of-tree
tip-of-tree
52.36ms - 53.15msunsure 🔍
-1% - +2%
-0.48ms - +0.94ms
-unsure 🔍
-0% - +2%
-0.09ms - +0.99ms
previous-release
previous-release
51.93ms - 52.68msunsure 🔍
-2% - +1%
-0.92ms - +0.48ms
unsure 🔍
-2% - +0%
-0.99ms - +0.09ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
108.57ms - 109.81ms-unsure 🔍
-1% - +1%
-1.25ms - +0.75ms
unsure 🔍
-1% - +1%
-0.63ms - +1.13ms
tip-of-tree
tip-of-tree
108.66ms - 110.22msunsure 🔍
-1% - +1%
-0.75ms - +1.25ms
-unsure 🔍
-0% - +1%
-0.50ms - +1.49ms
previous-release
previous-release
108.32ms - 109.56msunsure 🔍
-1% - +1%
-1.13ms - +0.63ms
unsure 🔍
-1% - +0%
-1.49ms - +0.50ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
53.99ms - 54.98ms-unsure 🔍
-1% - +1%
-0.57ms - +0.81ms
unsure 🔍
-1% - +2%
-0.35ms - +1.06ms
tip-of-tree
tip-of-tree
53.89ms - 54.85msunsure 🔍
-1% - +1%
-0.81ms - +0.57ms
-unsure 🔍
-1% - +2%
-0.46ms - +0.94ms
previous-release
previous-release
53.63ms - 54.64msunsure 🔍
-2% - +1%
-1.06ms - +0.35ms
unsure 🔍
-2% - +1%
-0.94ms - +0.46ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
675.70ms - 680.09ms-unsure 🔍
-1% - +0%
-4.55ms - +1.51ms
faster ✔
0% - 1%
0.63ms - 6.26ms
tip-of-tree
tip-of-tree
677.33ms - 681.50msunsure 🔍
-0% - +1%
-1.51ms - +4.55ms
-unsure 🔍
-1% - +0%
-4.66ms - +0.81ms
previous-release
previous-release
679.58ms - 683.11msslower ❌
0% - 1%
0.63ms - 6.26ms
unsure 🔍
-0% - +1%
-0.81ms - +4.66ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
785.93ms - 796.34ms-unsure 🔍
-0% - +2%
-1.34ms - +15.30ms
unsure 🔍
-0% - +2%
-0.70ms - +16.34ms
tip-of-tree
tip-of-tree
777.66ms - 790.64msunsure 🔍
-2% - +0%
-15.30ms - +1.34ms
-unsure 🔍
-1% - +1%
-8.53ms - +10.20ms
previous-release
previous-release
776.57ms - 790.06msunsure 🔍
-2% - +0%
-16.34ms - +0.70ms
unsure 🔍
-1% - +1%
-10.20ms - +8.53ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk merged commit 19d7bd2 into main Aug 6, 2022
@augustjk augustjk deleted the module-loader-windows branch August 6, 2022 00:59
@lit-robot lit-robot mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/ssr] ModuleLoader is not able to handle file urls in Windows
2 participants