Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Prepare vue-utils for release, remove test prod deps, add publishConfig.access #3227

Merged
merged 5 commits into from Aug 18, 2022

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Aug 18, 2022

  • I forgot @lit-labs/vue-utils in [cli] Prepare for CLI 0.1.0 release #3225, so that's now private and has a changeset so that the next publish will release it as 0.1.0.
  • Removed a couple of prod dependencies on @lit-internal/tests, which should have been devDependencies.
  • Add missing publishConfig.access to new packages package.json files.

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022

🦋 Changeset detected

Latest commit: 707c15a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit-labs/vue-utils Minor
@lit-labs/gen-wrapper-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-0.46ms - +1.44ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 88.19ms - 94.29ms
  • lit-html-kitchen-sink: unsure 🔍 -0% - +4% (-0.08ms - +1.22ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +5% (-0.19ms - +0.58ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +2% (-1.06ms - +1.18ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +3% (-0.68ms - +1.87ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 919.61ms - 939.68ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-2.29ms - +3.17ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +2% (-2.67ms - +7.63ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.85ms - +1.99ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-3.67ms - +12.74ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 922.21ms - 934.73ms
  • reactive-element-list: unsure 🔍 -2% - +2% (-22.74ms - +24.47ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
88.19ms - 94.29ms-

update

VersionAvg timevs
919.61ms - 939.68ms-

update-reflect

VersionAvg timevs
922.21ms - 934.73ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
34.28ms - 35.36ms-unsure 🔍
-0% - +4%
-0.08ms - +1.22ms
unsure 🔍
-4% - +2%
-1.25ms - +0.67ms
tip-of-tree
tip-of-tree
33.88ms - 34.62msunsure 🔍
-3% - +0%
-1.22ms - +0.08ms
-unsure 🔍
-5% - -0%
-1.74ms - +0.01ms
previous-release
previous-release
34.32ms - 35.91msunsure 🔍
-2% - +4%
-0.67ms - +1.25ms
unsure 🔍
-0% - +5%
-0.01ms - +1.74ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
93.82ms - 97.32ms-unsure 🔍
-2% - +3%
-2.29ms - +3.17ms
unsure 🔍
-2% - +3%
-1.72ms - +3.02ms
tip-of-tree
tip-of-tree
93.03ms - 97.23msunsure 🔍
-3% - +2%
-3.17ms - +2.29ms
-unsure 🔍
-3% - +3%
-2.43ms - +2.84ms
previous-release
previous-release
93.33ms - 96.51msunsure 🔍
-3% - +2%
-3.02ms - +1.72ms
unsure 🔍
-3% - +3%
-2.84ms - +2.43ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
29.26ms - 30.89ms-unsure 🔍
-2% - +5%
-0.46ms - +1.44ms
unsure 🔍
-2% - +4%
-0.48ms - +1.32ms
tip-of-tree
tip-of-tree
29.10ms - 30.07msunsure 🔍
-5% - +1%
-1.44ms - +0.46ms
-unsure 🔍
-2% - +2%
-0.69ms - +0.55ms
previous-release
previous-release
29.27ms - 30.04msunsure 🔍
-4% - +2%
-1.32ms - +0.48ms
unsure 🔍
-2% - +2%
-0.55ms - +0.69ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.18ms - 12.81ms-unsure 🔍
-2% - +5%
-0.19ms - +0.58ms
unsure 🔍
-2% - +4%
-0.29ms - +0.53ms
tip-of-tree
tip-of-tree
12.08ms - 12.52msunsure 🔍
-5% - +1%
-0.58ms - +0.19ms
-unsure 🔍
-3% - +2%
-0.41ms - +0.26ms
previous-release
previous-release
12.12ms - 12.63msunsure 🔍
-4% - +2%
-0.53ms - +0.29ms
unsure 🔍
-2% - +3%
-0.26ms - +0.41ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
350.48ms - 357.23ms-unsure 🔍
-1% - +2%
-2.67ms - +7.63ms
unsure 🔍
-1% - +1%
-4.07ms - +4.52ms
tip-of-tree
tip-of-tree
347.48ms - 355.27msunsure 🔍
-2% - +1%
-7.63ms - +2.67ms
-unsure 🔍
-2% - +1%
-6.97ms - +2.45ms
previous-release
previous-release
350.98ms - 356.29msunsure 🔍
-1% - +1%
-4.52ms - +4.07ms
unsure 🔍
-1% - +2%
-2.45ms - +6.97ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
64.34ms - 65.72ms-unsure 🔍
-2% - +2%
-1.06ms - +1.18ms
unsure 🔍
-1% - +2%
-0.68ms - +1.22ms
tip-of-tree
tip-of-tree
64.08ms - 65.85msunsure 🔍
-2% - +2%
-1.18ms - +1.06ms
-unsure 🔍
-1% - +2%
-0.89ms - +1.31ms
previous-release
previous-release
64.11ms - 65.40msunsure 🔍
-2% - +1%
-1.22ms - +0.68ms
unsure 🔍
-2% - +1%
-1.31ms - +0.89ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
138.09ms - 140.70ms-unsure 🔍
-1% - +1%
-1.85ms - +1.99ms
unsure 🔍
-1% - +2%
-1.87ms - +2.60ms
tip-of-tree
tip-of-tree
137.91ms - 140.74msunsure 🔍
-1% - +1%
-1.99ms - +1.85ms
-unsure 🔍
-1% - +2%
-2.00ms - +2.60ms
previous-release
previous-release
137.21ms - 140.84msunsure 🔍
-2% - +1%
-2.60ms - +1.87ms
unsure 🔍
-2% - +1%
-2.60ms - +2.00ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
65.07ms - 66.84ms-unsure 🔍
-1% - +3%
-0.68ms - +1.87ms
unsure 🔍
-3% - +1%
-1.73ms - +0.85ms
tip-of-tree
tip-of-tree
64.44ms - 66.27msunsure 🔍
-3% - +1%
-1.87ms - +0.68ms
-unsure 🔍
-4% - +0%
-2.35ms - +0.28ms
previous-release
previous-release
65.45ms - 67.33msunsure 🔍
-1% - +3%
-0.85ms - +1.73ms
unsure 🔍
-0% - +4%
-0.28ms - +2.35ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
943.52ms - 955.84ms-unsure 🔍
-0% - +1%
-3.67ms - +12.74ms
unsure 🔍
-0% - +1%
-3.81ms - +13.08ms
tip-of-tree
tip-of-tree
939.72ms - 950.56msunsure 🔍
-1% - +0%
-12.74ms - +3.67ms
-unsure 🔍
-1% - +1%
-7.82ms - +8.02ms
previous-release
previous-release
939.27ms - 950.81msunsure 🔍
-1% - +0%
-13.08ms - +3.81ms
unsure 🔍
-1% - +1%
-8.02ms - +7.82ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1013.03ms - 1046.14ms-unsure 🔍
-2% - +2%
-22.74ms - +24.47ms
unsure 🔍
-3% - +1%
-31.23ms - +14.04ms
tip-of-tree
tip-of-tree
1011.88ms - 1045.55msunsure 🔍
-2% - +2%
-24.47ms - +22.74ms
-unsure 🔍
-3% - +1%
-32.30ms - +13.37ms
previous-release
previous-release
1022.75ms - 1053.61msunsure 🔍
-1% - +3%
-14.04ms - +31.23ms
unsure 🔍
-1% - +3%
-13.37ms - +32.30ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk
Copy link
Member

Since we're fixing things.. I think all the to-be-released packages also need

  "publishConfig": {
    "access": "public"
  }

in their package.json to be published under the scoped name.

@aomarks
Copy link
Member Author

aomarks commented Aug 18, 2022

Since we're fixing things.. I think all the to-be-released packages also need

  "publishConfig": {
    "access": "public"
  }

in their package.json to be published under the scoped name.

Good catch! Done.

@aomarks aomarks changed the title [cli] Add missing vue-utils package to release, and remove test prod deps [cli] Prepare vue-utils for release, remove test prod deps, add publishConfig.access Aug 18, 2022
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aomarks aomarks enabled auto-merge (squash) August 18, 2022 22:06
@aomarks aomarks merged commit 26cfefd into main Aug 18, 2022
@aomarks aomarks deleted the cli-release branch August 18, 2022 22:07
@lit-robot lit-robot mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants