Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/gen-wrapper-vue] Add lib files to npm package #3233

Merged
merged 2 commits into from Aug 19, 2022

Conversation

augustjk
Copy link
Member

The lit labs gen command with --framework=vue was not working due to missing lib files. This fix adds those to the npm package.

I've only included the .js files inline with the existing index.js and omission of declaration and sourcemaps.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2022

🦋 Changeset detected

Latest commit: 8997828

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/gen-wrapper-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-0.44ms - +0.69ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 74.54ms - 78.39ms
  • lit-html-kitchen-sink: unsure 🔍 -0% - +1% (-0.10ms - +0.18ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +3% (-0.09ms - +0.33ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -0% - +2% (-0.16ms - +0.82ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-1.65ms - +1.08ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 793.83ms - 808.49ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +1% (-3.07ms - +1.12ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +2% (-1.73ms - +4.39ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.97ms - +2.19ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-12.09ms - +10.61ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 800.45ms - 809.44ms
  • reactive-element-list: unsure 🔍 -2% - +2% (-19.99ms - +22.46ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
74.54ms - 78.39ms-

update

VersionAvg timevs
793.83ms - 808.49ms-

update-reflect

VersionAvg timevs
800.45ms - 809.44ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
28.84ms - 29.06ms-unsure 🔍
-0% - +1%
-0.10ms - +0.18ms
unsure 🔍
-2% - +0%
-0.45ms - +0.07ms
tip-of-tree
tip-of-tree
28.82ms - 29.00msunsure 🔍
-1% - +0%
-0.18ms - +0.10ms
-unsure 🔍
-2% - +0%
-0.48ms - +0.03ms
previous-release
previous-release
28.90ms - 29.37msunsure 🔍
-0% - +2%
-0.07ms - +0.45ms
unsure 🔍
-0% - +2%
-0.03ms - +0.48ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
79.52ms - 81.63ms-unsure 🔍
-4% - +1%
-3.07ms - +1.12ms
unsure 🔍
-1% - +4%
-0.60ms - +3.37ms
tip-of-tree
tip-of-tree
79.75ms - 83.36msunsure 🔍
-1% - +4%
-1.12ms - +3.07ms
-unsure 🔍
-0% - +6%
-0.11ms - +4.83ms
previous-release
previous-release
77.51ms - 80.87msunsure 🔍
-4% - +1%
-3.37ms - +0.60ms
unsure 🔍
-6% - +0%
-4.83ms - +0.11ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
24.82ms - 25.68ms-unsure 🔍
-2% - +3%
-0.44ms - +0.69ms
unsure 🔍
-2% - +3%
-0.45ms - +0.83ms
tip-of-tree
tip-of-tree
24.77ms - 25.48msunsure 🔍
-3% - +2%
-0.69ms - +0.44ms
-unsure 🔍
-2% - +3%
-0.52ms - +0.65ms
previous-release
previous-release
24.59ms - 25.52msunsure 🔍
-3% - +2%
-0.83ms - +0.45ms
unsure 🔍
-3% - +2%
-0.65ms - +0.52ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.22ms - 10.54ms-unsure 🔍
-1% - +3%
-0.09ms - +0.33ms
unsure 🔍
-1% - +3%
-0.10ms - +0.33ms
tip-of-tree
tip-of-tree
10.12ms - 10.39msunsure 🔍
-3% - +1%
-0.33ms - +0.09ms
-unsure 🔍
-2% - +2%
-0.20ms - +0.18ms
previous-release
previous-release
10.13ms - 10.40msunsure 🔍
-3% - +1%
-0.33ms - +0.10ms
unsure 🔍
-2% - +2%
-0.18ms - +0.20ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
291.13ms - 296.26ms-unsure 🔍
-1% - +2%
-1.73ms - +4.39ms
unsure 🔍
-1% - +1%
-1.62ms - +4.09ms
tip-of-tree
tip-of-tree
290.69ms - 294.03msunsure 🔍
-1% - +1%
-4.39ms - +1.73ms
-unsure 🔍
-1% - +1%
-2.19ms - +1.99ms
previous-release
previous-release
291.20ms - 293.72msunsure 🔍
-1% - +1%
-4.09ms - +1.62ms
unsure 🔍
-1% - +1%
-1.99ms - +2.19ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
53.82ms - 54.46ms-unsure 🔍
-0% - +2%
-0.16ms - +0.82ms
unsure 🔍
-1% - +1%
-0.27ms - +0.66ms
tip-of-tree
tip-of-tree
53.43ms - 54.19msunsure 🔍
-2% - +0%
-0.82ms - +0.16ms
-unsure 🔍
-1% - +1%
-0.64ms - +0.37ms
previous-release
previous-release
53.61ms - 54.28msunsure 🔍
-1% - +0%
-0.66ms - +0.27ms
unsure 🔍
-1% - +1%
-0.37ms - +0.64ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
117.11ms - 119.31ms-unsure 🔍
-1% - +2%
-0.97ms - +2.19ms
unsure 🔍
-1% - +1%
-1.59ms - +1.64ms
tip-of-tree
tip-of-tree
116.46ms - 118.73msunsure 🔍
-2% - +1%
-2.19ms - +0.97ms
-unsure 🔍
-2% - +1%
-2.23ms - +1.06ms
previous-release
previous-release
117.00ms - 119.37msunsure 🔍
-1% - +1%
-1.64ms - +1.59ms
unsure 🔍
-1% - +2%
-1.06ms - +2.23ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.45ms - 57.08ms-unsure 🔍
-3% - +2%
-1.65ms - +1.08ms
unsure 🔍
-2% - +2%
-1.11ms - +0.97ms
tip-of-tree
tip-of-tree
55.46ms - 57.65msunsure 🔍
-2% - +3%
-1.08ms - +1.65ms
-unsure 🔍
-2% - +3%
-1.06ms - +1.49ms
previous-release
previous-release
55.69ms - 56.98msunsure 🔍
-2% - +2%
-0.97ms - +1.11ms
unsure 🔍
-3% - +2%
-1.49ms - +1.06ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
808.58ms - 826.99ms-unsure 🔍
-1% - +1%
-12.09ms - +10.61ms
unsure 🔍
-1% - +2%
-4.64ms - +16.05ms
tip-of-tree
tip-of-tree
811.89ms - 825.16msunsure 🔍
-1% - +1%
-10.61ms - +12.09ms
-unsure 🔍
-0% - +2%
-1.69ms - +14.58ms
previous-release
previous-release
807.37ms - 816.79msunsure 🔍
-2% - +1%
-16.05ms - +4.64ms
unsure 🔍
-2% - +0%
-14.58ms - +1.69ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
889.58ms - 922.89ms-unsure 🔍
-2% - +2%
-19.99ms - +22.46ms
unsure 🔍
-2% - +2%
-21.11ms - +20.71ms
tip-of-tree
tip-of-tree
891.85ms - 918.16msunsure 🔍
-2% - +2%
-22.46ms - +19.99ms
-unsure 🔍
-2% - +2%
-19.68ms - +16.81ms
previous-release
previous-release
893.80ms - 919.08msunsure 🔍
-2% - +2%
-20.71ms - +21.11ms
unsure 🔍
-2% - +2%
-16.81ms - +19.68ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk merged commit fc3304d into main Aug 19, 2022
@augustjk augustjk deleted the fix-vue-wrapper-package branch August 19, 2022 21:58
@lit-robot lit-robot mentioned this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants