Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/virtualizer] Added missing events.js.map sourcemap file to package.json #3527

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

usergenic
Copy link
Contributor

Fixes missing sourcemap file in package.json.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2022

🦋 Changeset detected

Latest commit: a41a018

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/virtualizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -3% - +4% (-0.98ms - +1.17ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 107.19ms - 111.22ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +3% (-2.93ms - +1.41ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -12% - +4% (-1.76ms - +0.70ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.68ms - +2.59ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-2.11ms - +1.58ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1072.52ms - 1092.27ms
  • lit-html-kitchen-sink: unsure 🔍 -1% - +8% (-1.22ms - +8.68ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +5% (-7.69ms - +18.06ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +0% (-6.71ms - +0.30ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-17.96ms - +12.93ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1073.32ms - 1093.63ms
  • reactive-element-list: unsure 🔍 -1% - +2% (-13.66ms - +19.88ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
107.19ms - 111.22ms-

update

VersionAvg timevs
1072.52ms - 1092.27ms-

update-reflect

VersionAvg timevs
1073.32ms - 1093.63ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
42.62ms - 45.68ms-unsure 🔍
-6% - +3%
-2.93ms - +1.41ms
unsure 🔍
-7% - +3%
-3.14ms - +1.33ms
tip-of-tree
tip-of-tree
43.37ms - 46.45msunsure 🔍
-3% - +7%
-1.41ms - +2.93ms
-unsure 🔍
-5% - +5%
-2.38ms - +2.10ms
previous-release
previous-release
43.42ms - 46.68msunsure 🔍
-3% - +7%
-1.33ms - +3.14ms
unsure 🔍
-5% - +5%
-2.10ms - +2.38ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
113.07ms - 120.21ms-unsure 🔍
-1% - +8%
-1.22ms - +8.68ms
unsure 🔍
-0% - +9%
-0.01ms - +9.45ms
tip-of-tree
tip-of-tree
109.49ms - 116.33msunsure 🔍
-7% - +1%
-8.68ms - +1.22ms
-unsure 🔍
-3% - +5%
-3.63ms - +5.60ms
previous-release
previous-release
108.82ms - 115.02msunsure 🔍
-8% - -0%
-9.45ms - +0.01ms
unsure 🔍
-5% - +3%
-5.60ms - +3.63ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
28.39ms - 29.97ms-unsure 🔍
-3% - +4%
-0.98ms - +1.17ms
unsure 🔍
-3% - +5%
-0.85ms - +1.33ms
tip-of-tree
tip-of-tree
28.35ms - 29.82msunsure 🔍
-4% - +3%
-1.17ms - +0.98ms
-unsure 🔍
-3% - +4%
-0.90ms - +1.19ms
previous-release
previous-release
28.20ms - 29.69msunsure 🔍
-5% - +3%
-1.33ms - +0.85ms
unsure 🔍
-4% - +3%
-1.19ms - +0.90ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.73ms - 15.45ms-unsure 🔍
-12% - +4%
-1.76ms - +0.70ms
unsure 🔍
-10% - +3%
-1.57ms - +0.49ms
tip-of-tree
tip-of-tree
14.24ms - 16.00msunsure 🔍
-5% - +12%
-0.70ms - +1.76ms
-unsure 🔍
-7% - +7%
-1.05ms - +1.04ms
previous-release
previous-release
14.56ms - 15.69msunsure 🔍
-4% - +11%
-0.49ms - +1.57ms
unsure 🔍
-7% - +7%
-1.04ms - +1.05ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
347.02ms - 366.71ms-unsure 🔍
-2% - +5%
-7.69ms - +18.06ms
unsure 🔍
-3% - +5%
-9.94ms - +16.31ms
tip-of-tree
tip-of-tree
343.39ms - 359.97msunsure 🔍
-5% - +2%
-18.06ms - +7.69ms
-unsure 🔍
-4% - +3%
-14.00ms - +10.01ms
previous-release
previous-release
345.00ms - 362.35msunsure 🔍
-5% - +3%
-16.31ms - +9.94ms
unsure 🔍
-3% - +4%
-10.01ms - +14.00ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.81ms - 70.51ms-unsure 🔍
-1% - +4%
-0.68ms - +2.59ms
unsure 🔍
-1% - +4%
-0.77ms - +2.61ms
tip-of-tree
tip-of-tree
67.29ms - 69.12msunsure 🔍
-4% - +1%
-2.59ms - +0.68ms
-unsure 🔍
-2% - +2%
-1.40ms - +1.32ms
previous-release
previous-release
67.23ms - 69.25msunsure 🔍
-4% - +1%
-2.61ms - +0.77ms
unsure 🔍
-2% - +2%
-1.32ms - +1.40ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
142.33ms - 146.79ms-unsure 🔍
-5% - +0%
-6.71ms - +0.30ms
unsure 🔍
-5% - +1%
-6.79ms - +0.96ms
tip-of-tree
tip-of-tree
145.06ms - 150.48msunsure 🔍
-0% - +5%
-0.30ms - +6.71ms
-unsure 🔍
-3% - +3%
-3.88ms - +4.46ms
previous-release
previous-release
144.31ms - 150.64msunsure 🔍
-1% - +5%
-0.96ms - +6.79ms
unsure 🔍
-3% - +3%
-4.46ms - +3.88ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
79.40ms - 81.94ms-unsure 🔍
-3% - +2%
-2.11ms - +1.58ms
slower ❌
0% - 5%
0.37ms - 3.67ms
tip-of-tree
tip-of-tree
79.59ms - 82.27msunsure 🔍
-2% - +3%
-1.58ms - +2.11ms
-slower ❌
1% - 5%
0.58ms - 3.99ms
previous-release
previous-release
77.59ms - 79.70msfaster ✔
0% - 5%
0.37ms - 3.67ms
faster ✔
1% - 5%
0.58ms - 3.99ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1104.30ms - 1127.66ms-unsure 🔍
-2% - +1%
-17.96ms - +12.93ms
unsure 🔍
-1% - +2%
-11.19ms - +20.33ms
tip-of-tree
tip-of-tree
1108.39ms - 1128.60msunsure 🔍
-1% - +2%
-12.93ms - +17.96ms
-unsure 🔍
-1% - +2%
-7.54ms - +21.72ms
previous-release
previous-release
1100.83ms - 1121.99msunsure 🔍
-2% - +1%
-20.33ms - +11.19ms
unsure 🔍
-2% - +1%
-21.72ms - +7.54ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1147.01ms - 1170.60ms-unsure 🔍
-1% - +2%
-13.66ms - +19.88ms
unsure 🔍
-2% - +1%
-19.49ms - +10.44ms
tip-of-tree
tip-of-tree
1143.78ms - 1167.61msunsure 🔍
-2% - +1%
-19.88ms - +13.66ms
-unsure 🔍
-2% - +1%
-22.69ms - +7.43ms
previous-release
previous-release
1154.12ms - 1172.54msunsure 🔍
-1% - +2%
-10.44ms - +19.49ms
unsure 🔍
-1% - +2%
-7.43ms - +22.69ms
-

tachometer-reporter-action v2 for Benchmarks

@usergenic usergenic changed the title Added missing events.js.map sourcemap file to package.json [labs/virtualizer] Added missing events.js.map sourcemap file to package.json Dec 15, 2022
Copy link
Contributor

@graynorton graynorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@usergenic usergenic merged commit feb2494 into main Dec 15, 2022
@usergenic usergenic deleted the virtualizer-add-missing-sourcemap branch December 15, 2022 19:54
This was referenced Dec 15, 2022
43081j pushed a commit to 43081j/lit-html that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants