You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replace of extends HTMLElement with extends (globalThis.HTMLElement ?? HTMLElement) was not happening due to the includes option for @rollup/plugin-replace not working properly. Updating the version fixes this.
Note: To keep a single version of the plugin in the monorepo, the version was also updated for the starter kits.
I added another test in the vein of the node-import tests. It feels like there are a lot of scripts for the node tests now but unsure if there's a better way to do this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3559
The replace of
extends HTMLElement
withextends (globalThis.HTMLElement ?? HTMLElement)
was not happening due to theincludes
option for@rollup/plugin-replace
not working properly. Updating the version fixes this.Note: To keep a single version of the plugin in the monorepo, the version was also updated for the starter kits.
Now the outputs look like:
Dev Node build:
Prod Node build:
I added another test in the vein of the node-import tests. It feels like there are a lot of scripts for the node tests now but unsure if there's a better way to do this.