Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/virtualizer] Trigger reflow after padding is set #3606

Merged
merged 2 commits into from Jan 26, 2023

Conversation

Westbrook
Copy link
Contributor

fixes #3285

Ensure that the layout for the Virtualizer is updated when a new padding value is provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2023

🦋 Changeset detected

Latest commit: 9ec4bec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/virtualizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@usergenic usergenic changed the title Trigger reflow after padding is set [labs/virtualizer] Trigger reflow after padding is set Jan 26, 2023
@usergenic
Copy link
Contributor

Hey @Westbrook thanks for the PR! To get this to pass the linter, can you run npx changeset --empty to create an empty changeset file?

@usergenic
Copy link
Contributor

@Westbrook sorry I didn't realize I could do that. Added changeset.

Copy link
Contributor

@usergenic usergenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We don't have very good tests around reflow behavior as such so I won't gate this on those, but I'll go to add them immediately after this comes in.

@usergenic usergenic merged commit 441baca into lit:main Jan 26, 2023
@Westbrook Westbrook deleted the patch-2 branch January 26, 2023 04:38
@lit-robot lit-robot mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/virtualizer] Padding does not trigger layout like gap does
2 participants