New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[labs/nextjs] Add Next.js plugin for Lit SSR #3613
Conversation
🦋 Changeset detectedLatest commit: d79abf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultslit-element-list
render
update
update-reflect
lit-html-kitchen-sink
render
update
nop-update
lit-html-repeat
render
update
lit-html-template-heavy
render
update
reactive-element-list
render
update
update-reflect
|
aab935d
to
41be4c1
Compare
9a4d490
to
c42d491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-emptive LGTM, assuming my minor comments will be addressed.
7244d4a
to
bd85206
Compare
Really excited to see this coming! I'm building a lit design system for nextjs and this could be the solution that's I'm looking for! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question, otherwise LGTM (to the extend I grok it all).
Co-authored-by: Justin Fagnani <justinfagnani@google.com>
To follow #3605
Resolves #3589
Lacking tests. It probably makes more sense to test this e2e with the example project. PR that updates/adds usage example will follow.
A known issue is that due to the shimmed custom elements registry throwing an error on repeat registrations, when running
npm run dev
, the re-run after modifying a file can cause errors that's only cleared by restarting the dev server.