Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[labs/analyzer] Don't extract JSDoc types in TS. Port type tests to JS. #3658

Merged
merged 5 commits into from
Feb 9, 2023
Merged

[labs/analyzer] Don't extract JSDoc types in TS. Port type tests to JS. #3658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
886dd4b
TS already takes into account JSDoc comments when determining types, …
bicknellr Feb 8, 2023
0c39638
Remove incorrect JSDoc type tests. (...)
bicknellr Feb 8, 2023
c98dab8
Copy TS type tests and port to JS.
bicknellr Feb 8, 2023
8849501
Remove a comment that no longer applies.
bicknellr Feb 8, 2023
70e8068
Add a changeset.
bicknellr Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-ravens-drop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lit-labs/analyzer': minor
---

JSDoc types in TS files now have no effect on the analyzer's output, matching TS itself.
7 changes: 1 addition & 6 deletions packages/labs/analyzer/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,8 @@ export const getTypeForNode = (
node: ts.Node,
analyzer: AnalyzerInterface
): Type => {
// Since getTypeAtLocation will return `any` for an untyped node, to support
// jsdoc @type for JS (TBD), we look at the jsdoc type first.
const jsdocType = ts.getJSDocType(node);
return getTypeForType(
jsdocType
? analyzer.program.getTypeChecker().getTypeFromTypeNode(jsdocType)
: analyzer.program.getTypeChecker().getTypeAtLocation(node),
analyzer.program.getTypeChecker().getTypeAtLocation(node),
node,
analyzer
);
Expand Down