Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few things in the labs/ssr readme #3712

Merged
merged 1 commit into from Mar 8, 2023
Merged

Conversation

justinfagnani
Copy link
Collaborator

Fixes #2665

@justinfagnani justinfagnani enabled auto-merge (squash) March 8, 2023 19:17
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 1193866

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -12% - +18% (-2.96ms - +4.40ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 115.11ms - 118.53ms
  • lit-html-kitchen-sink: unsure 🔍 -7% - +14% (-3.41ms - +6.76ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -12% - +3% (-1.90ms - +0.46ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: faster ✔ 0% - 6% (0.04ms - 4.61ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +2% (-1.90ms - +1.77ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1165.92ms - 1181.56ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +11% (-6.94ms - +12.66ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +2% (-12.52ms - +8.38ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-4.23ms - +3.49ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-18.71ms - +8.44ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1158.39ms - 1177.96ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-10.60ms - +16.47ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
115.11ms - 118.53ms-

update

VersionAvg timevs
1165.92ms - 1181.56ms-

update-reflect

VersionAvg timevs
1158.39ms - 1177.96ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
48.90ms - 54.91ms-unsure 🔍
-7% - +14%
-3.41ms - +6.76ms
unsure 🔍
-4% - +12%
-1.96ms - +6.13ms
tip-of-tree
tip-of-tree
46.13ms - 54.33msunsure 🔍
-13% - +6%
-6.76ms - +3.41ms
-unsure 🔍
-9% - +11%
-4.50ms - +5.32ms
previous-release
previous-release
47.12ms - 52.52msunsure 🔍
-12% - +4%
-6.13ms - +1.96ms
unsure 🔍
-11% - +9%
-5.32ms - +4.50ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
115.55ms - 131.87ms-unsure 🔍
-6% - +11%
-6.94ms - +12.66ms
unsure 🔍
-5% - +12%
-5.54ms - +14.40ms
tip-of-tree
tip-of-tree
115.42ms - 126.28msunsure 🔍
-10% - +5%
-12.66ms - +6.94ms
-unsure 🔍
-5% - +8%
-6.31ms - +9.46ms
previous-release
previous-release
113.55ms - 125.00msunsure 🔍
-11% - +4%
-14.40ms - +5.54ms
unsure 🔍
-8% - +5%
-9.46ms - +6.31ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
22.29ms - 28.13ms-unsure 🔍
-12% - +18%
-2.96ms - +4.40ms
unsure 🔍
-14% - +19%
-3.39ms - +4.54ms
tip-of-tree
tip-of-tree
22.24ms - 26.73msunsure 🔍
-17% - +11%
-4.40ms - +2.96ms
-unsure 🔍
-15% - +14%
-3.65ms - +3.35ms
previous-release
previous-release
21.94ms - 27.32msunsure 🔍
-18% - +13%
-4.54ms - +3.39ms
unsure 🔍
-14% - +15%
-3.35ms - +3.65ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
14.52ms - 15.57ms-unsure 🔍
-12% - +3%
-1.90ms - +0.46ms
faster ✔
1% - 10%
0.14ms - 1.61ms
tip-of-tree
tip-of-tree
14.72ms - 16.82msunsure 🔍
-3% - +13%
-0.46ms - +1.90ms
-unsure 🔍
-8% - +6%
-1.32ms - +1.02ms
previous-release
previous-release
15.41ms - 16.43msslower ❌
1% - 11%
0.14ms - 1.61ms
unsure 🔍
-7% - +8%
-1.02ms - +1.32ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
376.81ms - 393.41ms-unsure 🔍
-3% - +2%
-12.52ms - +8.38ms
unsure 🔍
-2% - +3%
-8.98ms - +11.80ms
tip-of-tree
tip-of-tree
380.83ms - 393.53msunsure 🔍
-2% - +3%
-8.38ms - +12.52ms
-unsure 🔍
-1% - +3%
-5.43ms - +12.39ms
previous-release
previous-release
377.46ms - 389.96msunsure 🔍
-3% - +2%
-11.80ms - +8.98ms
unsure 🔍
-3% - +1%
-12.39ms - +5.43ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
73.02ms - 75.95ms-faster ✔
0% - 6%
0.04ms - 4.61ms
faster ✔
1% - 8%
0.48ms - 6.23ms
tip-of-tree
tip-of-tree
75.06ms - 78.57msslower ❌
0% - 6%
0.04ms - 4.61ms
-unsure 🔍
-5% - +3%
-4.06ms - +2.00ms
previous-release
previous-release
75.37ms - 80.31msslower ❌
1% - 8%
0.48ms - 6.23ms
unsure 🔍
-3% - +5%
-2.00ms - +4.06ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
158.86ms - 164.06ms-unsure 🔍
-3% - +2%
-4.23ms - +3.49ms
unsure 🔍
-4% - +1%
-7.00ms - +1.41ms
tip-of-tree
tip-of-tree
158.97ms - 164.68msunsure 🔍
-2% - +3%
-3.49ms - +4.23ms
-unsure 🔍
-4% - +1%
-6.79ms - +1.94ms
previous-release
previous-release
160.94ms - 167.56msunsure 🔍
-1% - +4%
-1.41ms - +7.00ms
unsure 🔍
-1% - +4%
-1.94ms - +6.79ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
77.70ms - 80.33ms-unsure 🔍
-2% - +2%
-1.90ms - +1.77ms
unsure 🔍
-3% - +2%
-2.59ms - +1.43ms
tip-of-tree
tip-of-tree
77.79ms - 80.36msunsure 🔍
-2% - +2%
-1.77ms - +1.90ms
-unsure 🔍
-3% - +2%
-2.51ms - +1.48ms
previous-release
previous-release
78.07ms - 81.12msunsure 🔍
-2% - +3%
-1.43ms - +2.59ms
unsure 🔍
-2% - +3%
-1.48ms - +2.51ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1180.87ms - 1200.86ms-unsure 🔍
-2% - +1%
-18.71ms - +8.44ms
unsure 🔍
-1% - +1%
-17.91ms - +10.87ms
tip-of-tree
tip-of-tree
1186.82ms - 1205.18msunsure 🔍
-1% - +2%
-8.44ms - +18.71ms
-unsure 🔍
-1% - +1%
-12.22ms - +15.45ms
previous-release
previous-release
1184.03ms - 1204.74msunsure 🔍
-1% - +2%
-10.87ms - +17.91ms
unsure 🔍
-1% - +1%
-15.45ms - +12.22ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1225.63ms - 1242.10ms-unsure 🔍
-1% - +1%
-10.60ms - +16.47ms
unsure 🔍
-1% - +1%
-14.80ms - +13.40ms
tip-of-tree
tip-of-tree
1220.19ms - 1241.67msunsure 🔍
-1% - +1%
-16.47ms - +10.60ms
-unsure 🔍
-2% - +1%
-19.33ms - +12.06ms
previous-release
previous-release
1223.12ms - 1246.01msunsure 🔍
-1% - +1%
-13.40ms - +14.80ms
unsure 🔍
-1% - +2%
-12.06ms - +19.33ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani merged commit f2eb979 into main Mar 8, 2023
@justinfagnani justinfagnani deleted the ssr-readme-fixes branch March 8, 2023 19:26
@lit-robot lit-robot mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/ssr] SSR Docs unclear regarding LitElement hydration
2 participants