Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit-html] Remove @types/web-ie11 dependency #3758

Merged
merged 1 commit into from Mar 24, 2023
Merged

Conversation

justinfagnani
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

⚠️ No Changeset found

Latest commit: 99efcca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-0.37ms - +0.76ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 78.18ms - 81.60ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +4% (-1.70ms - +1.29ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -5% - +9% (-0.52ms - +0.96ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +3% (-1.66ms - +1.45ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +2% (-2.38ms - +1.35ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 820.35ms - 827.33ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +2% (-3.49ms - +1.71ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -12% - +7% (-37.29ms - +23.79ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.93ms - +4.06ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-7.69ms - +1.37ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 787.73ms - 793.19ms
  • reactive-element-list: unsure 🔍 -1% - +0% (-6.74ms - +2.12ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
78.18ms - 81.60ms-

update

VersionAvg timevs
820.35ms - 827.33ms-

update-reflect

VersionAvg timevs
787.73ms - 793.19ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
31.87ms - 34.02ms-unsure 🔍
-5% - +4%
-1.70ms - +1.29ms
unsure 🔍
-8% - +3%
-2.67ms - +1.02ms
tip-of-tree
tip-of-tree
32.11ms - 34.19msunsure 🔍
-4% - +5%
-1.29ms - +1.70ms
-unsure 🔍
-7% - +3%
-2.45ms - +1.20ms
previous-release
previous-release
32.28ms - 35.27msunsure 🔍
-3% - +8%
-1.02ms - +2.67ms
unsure 🔍
-4% - +7%
-1.20ms - +2.45ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
84.38ms - 88.42ms-unsure 🔍
-4% - +2%
-3.49ms - +1.71ms
unsure 🔍
-4% - +3%
-3.86ms - +2.73ms
tip-of-tree
tip-of-tree
85.65ms - 88.93msunsure 🔍
-2% - +4%
-1.71ms - +3.49ms
-unsure 🔍
-3% - +4%
-2.76ms - +3.40ms
previous-release
previous-release
84.36ms - 89.57msunsure 🔍
-3% - +4%
-2.73ms - +3.86ms
unsure 🔍
-4% - +3%
-3.40ms - +2.76ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
16.17ms - 17.21ms-unsure 🔍
-2% - +5%
-0.37ms - +0.76ms
unsure 🔍
-7% - +3%
-1.16ms - +0.53ms
tip-of-tree
tip-of-tree
16.27ms - 16.72msunsure 🔍
-5% - +2%
-0.76ms - +0.37ms
-unsure 🔍
-7% - +1%
-1.21ms - +0.20ms
previous-release
previous-release
16.34ms - 17.66msunsure 🔍
-3% - +7%
-0.53ms - +1.16ms
unsure 🔍
-1% - +7%
-0.20ms - +1.21ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.88ms - 11.94ms-unsure 🔍
-5% - +9%
-0.52ms - +0.96ms
unsure 🔍
-8% - +4%
-1.00ms - +0.43ms
tip-of-tree
tip-of-tree
10.68ms - 11.71msunsure 🔍
-8% - +4%
-0.96ms - +0.52ms
-unsure 🔍
-10% - +2%
-1.20ms - +0.20ms
previous-release
previous-release
11.22ms - 12.17msunsure 🔍
-4% - +9%
-0.43ms - +1.00ms
unsure 🔍
-2% - +11%
-0.20ms - +1.20ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
293.37ms - 334.24ms-unsure 🔍
-12% - +7%
-37.29ms - +23.79ms
unsure 🔍
-15% - +5%
-51.98ms - +16.54ms
tip-of-tree
tip-of-tree
297.86ms - 343.26msunsure 🔍
-8% - +12%
-23.79ms - +37.29ms
-unsure 🔍
-14% - +7%
-46.63ms - +24.69ms
previous-release
previous-release
304.03ms - 359.03msunsure 🔍
-5% - +17%
-16.54ms - +51.98ms
unsure 🔍
-8% - +15%
-24.69ms - +46.63ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
56.13ms - 58.20ms-unsure 🔍
-3% - +3%
-1.66ms - +1.45ms
unsure 🔍
-3% - +2%
-1.95ms - +1.29ms
tip-of-tree
tip-of-tree
56.11ms - 58.43msunsure 🔍
-3% - +3%
-1.45ms - +1.66ms
-unsure 🔍
-3% - +3%
-1.93ms - +1.48ms
previous-release
previous-release
56.24ms - 58.75msunsure 🔍
-2% - +3%
-1.29ms - +1.95ms
unsure 🔍
-3% - +3%
-1.48ms - +1.93ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
128.74ms - 133.43ms-unsure 🔍
-1% - +3%
-0.93ms - +4.06ms
unsure 🔍
-1% - +3%
-1.78ms - +3.45ms
tip-of-tree
tip-of-tree
128.66ms - 130.39msunsure 🔍
-3% - +1%
-4.06ms - +0.93ms
-unsure 🔍
-2% - +1%
-2.18ms - +0.73ms
previous-release
previous-release
129.08ms - 131.42msunsure 🔍
-3% - +1%
-3.45ms - +1.78ms
unsure 🔍
-1% - +2%
-0.73ms - +2.18ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
52.34ms - 55.20ms-unsure 🔍
-4% - +2%
-2.38ms - +1.35ms
unsure 🔍
-3% - +4%
-1.64ms - +2.00ms
tip-of-tree
tip-of-tree
53.09ms - 55.49msunsure 🔍
-3% - +4%
-1.35ms - +2.38ms
-unsure 🔍
-2% - +4%
-0.95ms - +2.33ms
previous-release
previous-release
52.47ms - 54.72msunsure 🔍
-4% - +3%
-2.00ms - +1.64ms
unsure 🔍
-4% - +2%
-2.33ms - +0.95ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
849.80ms - 856.32ms-unsure 🔍
-1% - +0%
-7.69ms - +1.37ms
unsure 🔍
-1% - +0%
-6.61ms - +2.71ms
tip-of-tree
tip-of-tree
853.08ms - 859.37msunsure 🔍
-0% - +1%
-1.37ms - +7.69ms
-unsure 🔍
-0% - +1%
-3.36ms - +5.79ms
previous-release
previous-release
851.69ms - 858.34msunsure 🔍
-0% - +1%
-2.71ms - +6.61ms
unsure 🔍
-1% - +0%
-5.79ms - +3.36ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
834.54ms - 840.11ms-unsure 🔍
-1% - +0%
-6.74ms - +2.12ms
unsure 🔍
-0% - +1%
-2.20ms - +6.98ms
tip-of-tree
tip-of-tree
836.19ms - 843.08msunsure 🔍
-0% - +1%
-2.12ms - +6.74ms
-unsure 🔍
-0% - +1%
-0.32ms - +9.72ms
previous-release
previous-release
831.29ms - 838.59msunsure 🔍
-1% - +0%
-6.98ms - +2.20ms
unsure 🔍
-1% - +0%
-9.72ms - +0.32ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani changed the title Remove @types/web-ie11 dependency [lit-html] Remove @types/web-ie11 dependency Mar 24, 2023
@augustjk
Copy link
Member

augustjk commented Mar 24, 2023

Something in the lockfile change brought in here might be messed up. Build is failing.
https://github.com/lit/lit/actions/runs/4513406151/jobs/7948195040?pr=3758#step:7:953

i think it might be better to redo this one by freshly branching again from main and doing npm rm @types/web-ie11 -w lit-html

Base automatically changed from 3.0-turndown-ie to 3.0 March 24, 2023 19:23
@justinfagnani justinfagnani merged commit f26de47 into 3.0 Mar 24, 2023
6 checks passed
@justinfagnani justinfagnani deleted the 3.0-remove-ie-types branch March 24, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants