[labs/observers] Change filenames to match project convention #3771

justinfagnani · 2023-03-30T01:18:37Z

I noticed that @lit-labs/observers was using a different naming convention that we use for the rest of the project. It's a breaking change to fix, but figure it's better to change it now than later with more users.

changeset-bot · 2023-03-30T01:18:40Z

🦋 Changeset detected

Latest commit: 33b1933

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/observers	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-03-30T01:19:04Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -6% - +2% (-0.96ms - +0.41ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 75.56ms - 80.89ms
lit-html-kitchen-sink: slower ❌ 2% - 17% (0.83ms - 5.00ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -4% - +8% (-0.45ms - +0.89ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -0% - +5% (-0.11ms - +2.56ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -5% - +1% (-2.46ms - +0.60ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 648.02ms - 657.48ms
lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-2.93ms - +2.38ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -4% - +5% (-10.42ms - +11.77ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.96ms - +1.99ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +0% (-4.40ms - +1.55ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 626.98ms - 633.56ms
reactive-element-list: unsure 🔍 -1% - +0% (-3.87ms - +1.71ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 111.0.5563.110
Sample size: 50
Built by: Benchmarks #4595
Commit: 93723cb

render

Version	Avg time	vs
	75.56ms - 80.89ms	-

update

Version	Avg time	vs
	648.02ms - 657.48ms	-

update-reflect

Version	Avg time	vs
	626.98ms - 633.56ms	-

lit-html-kitchen-sink

Browser: chrome-headless 111.0.5563.110
Sample size: 30
Built by: Benchmarks #4595
Commit: 93723cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.58ms - 34.45ms	-	slower ❌ 2% - 17% 0.83ms - 5.00ms	unsure 🔍 -2% - +12% -0.48ms - +3.79ms
tip-of-tree tip-of-tree	28.59ms - 31.60ms	faster ✔ 3% - 15% 0.83ms - 5.00ms	-	unsure 🔍 -11% - +3% -3.44ms - +0.92ms
previous-release previous-release	29.78ms - 32.94ms	unsure 🔍 -11% - +1% -3.79ms - +0.48ms	unsure 🔍 -3% - +12% -0.92ms - +3.44ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.43ms - 75.31ms	-	unsure 🔍 -4% - +3% -2.93ms - +2.38ms	unsure 🔍 -3% - +5% -2.40ms - +3.28ms
tip-of-tree tip-of-tree	71.83ms - 75.46ms	unsure 🔍 -3% - +4% -2.38ms - +2.93ms	-	unsure 🔍 -3% - +5% -2.04ms - +3.47ms
previous-release previous-release	70.86ms - 75.00ms	unsure 🔍 -4% - +3% -3.28ms - +2.40ms	unsure 🔍 -5% - +3% -3.47ms - +2.04ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	15.45ms - 16.29ms	-	unsure 🔍 -6% - +2% -0.96ms - +0.41ms	unsure 🔍 -6% - +4% -0.94ms - +0.61ms
tip-of-tree tip-of-tree	15.61ms - 16.69ms	unsure 🔍 -3% - +6% -0.41ms - +0.96ms	-	unsure 🔍 -5% - +6% -0.73ms - +0.95ms
previous-release previous-release	15.39ms - 16.69ms	unsure 🔍 -4% - +6% -0.61ms - +0.94ms	unsure 🔍 -6% - +5% -0.95ms - +0.73ms	-

lit-html-repeat

Browser: chrome-headless 111.0.5563.110
Sample size: 30
Built by: Benchmarks #4595
Commit: 93723cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.62ms - 11.59ms	-	unsure 🔍 -4% - +8% -0.45ms - +0.89ms	unsure 🔍 -5% - +8% -0.49ms - +0.88ms
tip-of-tree tip-of-tree	10.43ms - 11.34ms	unsure 🔍 -8% - +4% -0.89ms - +0.45ms	-	unsure 🔍 -6% - +6% -0.69ms - +0.64ms
previous-release previous-release	10.43ms - 11.39ms	unsure 🔍 -8% - +4% -0.88ms - +0.49ms	unsure 🔍 -6% - +6% -0.64ms - +0.69ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	250.32ms - 260.70ms	-	unsure 🔍 -4% - +5% -10.42ms - +11.77ms	unsure 🔍 -1% - +4% -2.28ms - +10.86ms
tip-of-tree tip-of-tree	245.02ms - 264.64ms	unsure 🔍 -5% - +4% -11.77ms - +10.42ms	-	unsure 🔍 -3% - +6% -6.99ms - +14.22ms
previous-release previous-release	247.19ms - 255.25ms	unsure 🔍 -4% - +1% -10.86ms - +2.28ms	unsure 🔍 -6% - +3% -14.22ms - +6.99ms	-

lit-html-template-heavy

Browser: chrome-headless 111.0.5563.110
Sample size: 50
Built by: Benchmarks #4595
Commit: 93723cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	53.05ms - 54.95ms	-	unsure 🔍 -0% - +5% -0.11ms - +2.56ms	unsure 🔍 -1% - +4% -0.79ms - +1.99ms
tip-of-tree tip-of-tree	51.84ms - 53.71ms	unsure 🔍 -5% - +0% -2.56ms - +0.11ms	-	unsure 🔍 -4% - +1% -2.00ms - +0.75ms
previous-release previous-release	52.39ms - 54.41ms	unsure 🔍 -4% - +1% -1.99ms - +0.79ms	unsure 🔍 -1% - +4% -0.75ms - +2.00ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	99.39ms - 101.72ms	-	unsure 🔍 -1% - +2% -0.96ms - +1.99ms	unsure 🔍 -2% - +1% -2.09ms - +1.29ms
tip-of-tree tip-of-tree	99.13ms - 100.93ms	unsure 🔍 -2% - +1% -1.99ms - +0.96ms	-	unsure 🔍 -2% - +1% -2.44ms - +0.60ms
previous-release previous-release	99.73ms - 102.18ms	unsure 🔍 -1% - +2% -1.29ms - +2.09ms	unsure 🔍 -1% - +2% -0.60ms - +2.44ms	-

reactive-element-list

Browser: chrome-headless 111.0.5563.110
Sample size: 50
Built by: Benchmarks #4595
Commit: 93723cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	49.34ms - 51.35ms	-	unsure 🔍 -5% - +1% -2.46ms - +0.60ms	unsure 🔍 -3% - +3% -1.65ms - +1.47ms
tip-of-tree tip-of-tree	50.12ms - 52.43ms	unsure 🔍 -1% - +5% -0.60ms - +2.46ms	-	unsure 🔍 -2% - +5% -0.82ms - +2.50ms
previous-release previous-release	49.24ms - 51.63ms	unsure 🔍 -3% - +3% -1.47ms - +1.65ms	unsure 🔍 -5% - +2% -2.50ms - +0.82ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	649.80ms - 653.76ms	-	unsure 🔍 -1% - +0% -4.40ms - +1.55ms	unsure 🔍 -1% - +0% -3.73ms - +2.60ms
tip-of-tree tip-of-tree	650.98ms - 655.43ms	unsure 🔍 -0% - +1% -1.55ms - +4.40ms	-	unsure 🔍 -0% - +1% -2.46ms - +4.19ms
previous-release previous-release	649.87ms - 654.81ms	unsure 🔍 -0% - +1% -2.60ms - +3.73ms	unsure 🔍 -1% - +0% -4.19ms - +2.46ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	653.61ms - 656.89ms	-	unsure 🔍 -1% - +0% -3.87ms - +1.71ms	unsure 🔍 -1% - +0% -3.74ms - +0.90ms
tip-of-tree tip-of-tree	654.07ms - 658.59ms	unsure 🔍 -0% - +1% -1.71ms - +3.87ms	-	unsure 🔍 -0% - +0% -3.14ms - +2.46ms
previous-release previous-release	655.02ms - 658.32ms	unsure 🔍 -0% - +1% -0.90ms - +3.74ms	unsure 🔍 -0% - +0% -2.46ms - +3.14ms	-

_{tachometer-reporter-action v2 for Benchmarks}

rictic · 2023-03-30T05:00:10Z

packages/labs/observers/tsconfig.json

@@ -20,7 +20,8 @@
    "moduleResolution": "NodeNext",
    "allowSyntheticDefaultImports": true,
    "experimentalDecorators": true,
-    "noImplicitOverride": true
+    "noImplicitOverride": true,
+    "noEmitOnError": false


intentional?

Change filenames to match project convention

f4c2453

justinfagnani requested review from rictic and sorvell March 30, 2023 01:18

justinfagnani changed the title ~~Change filenames to match project convention~~ [labs/observers] Change filenames to match project convention Mar 30, 2023

justinfagnani mentioned this pull request Mar 30, 2023

[lit-labs/observers] add base class #3386

Open

rictic approved these changes Mar 30, 2023

View reviewed changes

oops

33b1933

justinfagnani merged commit 89da3d8 into main Mar 30, 2023
6 of 7 checks passed

justinfagnani deleted the observers-file-names branch March 30, 2023 15:38

lit-robot mentioned this pull request Apr 3, 2023

Version Packages #3778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[labs/observers] Change filenames to match project convention #3771

[labs/observers] Change filenames to match project convention #3771

justinfagnani commented Mar 30, 2023

changeset-bot bot commented Mar 30, 2023 •

edited

github-actions bot commented Mar 30, 2023 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

rictic Mar 30, 2023

justinfagnani Mar 30, 2023

[labs/observers] Change filenames to match project convention #3771

[labs/observers] Change filenames to match project convention #3771

Conversation

justinfagnani commented Mar 30, 2023

changeset-bot bot commented Mar 30, 2023 • edited

🦋 Changeset detected

github-actions bot commented Mar 30, 2023 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

rictic Mar 30, 2023

Choose a reason for hiding this comment

justinfagnani Mar 30, 2023

Choose a reason for hiding this comment

changeset-bot bot commented Mar 30, 2023 •

edited

github-actions bot commented Mar 30, 2023 •

edited